RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1511091 - vdo create --vdoLogicalThreads 0 does not check if --vdoPhysicalThreads and --vdoHashZoneThreads are both 0
Summary: vdo create --vdoLogicalThreads 0 does not check if --vdoPhysicalThreads and -...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: vdo
Version: 7.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Ken Raeburn
QA Contact: Jakub Krysl
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-08 16:13 UTC by Jakub Krysl
Modified: 2019-03-06 00:59 UTC (History)
3 users (show)

Fixed In Version: 6.1.0.45
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-10 15:47:46 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2018:0871 0 None None None 2018-04-10 15:48:08 UTC

Description Jakub Krysl 2017-11-08 16:13:47 UTC 
Description of problem:
As subject says, creating VDO with only 1 of those options specified leads to VDO actually trying to create it and device-mapper catching the error.

# vdo create --device /dev/sdc --name vdo --verbose --vdoLogicalThreads 0
Creating VDO vdo
    modprobe kvdo
    vdoformat --uds-checkpoint-frequency=0 --uds-memory-size=0.25 /dev/sdc
    vdodumpconfig /dev/sdc
Starting VDO vdo
    dmsetup status vdo
    modprobe kvdo
    dmsetup create vdo --table '0 11721045168 dedupe /dev/sdc 4096 disabled 0 32768 16380 on sync vdo ack=1,bio=4,bioRotationInterval=64,cpu=2,hash=1,logical=0,physical=1'
vdo: ERROR - Could not set up device mapper for vdo
Removing VDO vdo
Stopping VDO vdo
    dmsetup status vdo
vdo: ERROR - device-mapper: reload ioctl on vdo  failed: Invalid argument

console:
[B[22976.417374] device-mapper: table: 253:2: dedupe: Logical, physical, and hash zones counts must all be zero or all non-zero                                                                                    
[22976.428426] device-mapper: ioctl: error adding target to table                                        


# vdo create --device /dev/sdc --name vdo --verbose --vdoPhysicalThreads 0
Creating VDO vdo
    modprobe kvdo
    vdoformat --uds-checkpoint-frequency=0 --uds-memory-size=0.25 /dev/sdc
    vdodumpconfig /dev/sdc
Starting VDO vdo
    dmsetup status vdo
    modprobe kvdo
    dmsetup create vdo --table '0 11721045168 dedupe /dev/sdc 4096 disabled 0 32768 16380 on sync vdo ack=1,bio=4,bioRotationInterval=64,cpu=2,hash=1,logical=1,physical=0'
vdo: ERROR - Could not set up device mapper for vdo
Removing VDO vdo
Stopping VDO vdo
    dmsetup status vdo
vdo: ERROR - device-mapper: reload ioctl on vdo  failed: Invalid argument
[root@storageqe-24 raid]#

console:
[23218.818914] device-mapper: table: 253:2: dedupe: Logical, physical, and hash zones counts must all be zero or all non-zero                                                                                      
[23218.829947] device-mapper: ioctl: error adding target to table  

--vdoHashZoneThreads produce different error, more in BZ 1511085.

Version-Release number of selected component (if applicable):
vdo-6.1.0.34-8

How reproducible:
100%

Steps to Reproduce:
1.vdo create --device /dev/sdc --name vdo --verbose --vdoPhysicalThreads 0 
2.vdo create --device /dev/sdc --name vdo --verbose --vdoLogicalThreads 0

Actual results:
device-mapper catching error, giving info in console. Not enough info in terminal

Expected results:
vdo catching the error, requesting all 3 to be 0

Additional info:
Comment 2 Ken Raeburn 2017-11-10 23:55:20 UTC 
New check for consistent option values added.
Comment 4 Jakub Krysl 2017-11-14 14:49:41 UTC 
Tested with vdo-6.1.0.46-9:

# vdo create --name vdo --device /dev/sda3 --vdoLogicalThreads 0
vdo: ERROR - Options --vdoHashZoneThreads, --vdoLogicalThreads, and --vdoPhysicalThreads must either all be zero or all be nonzero

# vdo create --name vdo --device /dev/sda3 --vdoLogicalThreads 0 --vdoPhysicalThreads 0 --vdoHashZoneThreads 0 --verbose
Creating VDO vdo
    modprobe kvdo
    vdoformat --uds-checkpoint-frequency=0 --uds-memory-size=0.25 /dev/sda3
    vdodumpconfig /dev/sda3
Starting VDO vdo
    dmsetup status vdo
    modprobe kvdo
    dmsetup create vdo --table '0 940036096 dedupe /dev/sda3 4096 disabled 0 32768 16380 on sync vdo ack=1,bio=4,bioRotationInterval=64,cpu=2,hash=0,logical=0,physical=0'
    dmsetup status vdo
Starting compression on VDO vdo
    dmsetup message vdo 0 compression on
    dmsetup status vdo
VDO instance 3 volume is ready at /dev/mapper/vdo
Comment 7 errata-xmlrpc 2018-04-10 15:47:46 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0871
Note You need to log in before you can comment on or make changes to this bug.