Bug 1511632 - Review Request: nim - statically typed, imperative programming language
Summary: Review Request: nim - statically typed, imperative programming language
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1512228
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-09 18:40 UTC by Sergey Avseyev
Modified: 2017-12-12 11:19 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-12 11:19:26 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Sergey Avseyev 2017-11-09 18:40:04 UTC
Spec URL: https://avsej.fedorapeople.org/nim/0/nim.spec
SRPM URL: https://avsej.fedorapeople.org/nim/0/nim-0.17.2-1.fc28.src.rpm
Description: Nim (formerly known as "Nimrod") is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nim's design focuses on efficiency, expressiveness, elegance (in the order of priority).

Fedora Account System Username: avsej
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23020327

Comment 1 Robert-André Mauchin 🐧 2017-11-10 18:40:38 UTC
 - Simplify %files:

%files
%license copying.txt dist/nimble/license.txt
%doc %{_docdir}/nim/
%{_bindir}/nim*
%config(noreplace) %{_sysconfdir}/*.cfg
%{_datadir}/nim/
%{_datadir}/nimble/
%{_mandir}/man1/nim*.1*
%{bashcompdir}/nim*

%attr(0755, root, root) is not needed as it is the default.


 - You might want to consider creating your own RPM macros for this new languaqe in /usr/lib/rpm/macros.d/ , like %nim_arches for defining ExclusiveArches of nim and others to ease the packaging of nim apps.

Comment 2 Sergey Avseyev 2017-11-10 21:56:35 UTC
Thank you for your notes. I've fixed file list, and added macro, although nim.spec itself still using ExcludeArch. I believe later, macro file will be transferred to redhat-rpm-config, or I will extract it to separate package, or just port nim to s390x :)

Spec URL: https://avsej.fedorapeople.org/nim/1/nim.spec
SRPM URL: https://avsej.fedorapeople.org/nim/1/nim-0.17.2-1.fc28.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23051441

Comment 3 Robert-André Mauchin 🐧 2017-11-10 22:18:21 UTC
I don't see any changes in %files.

I didn't mean you should add the macros to this package, you could create a separate package, like nim-packaging, for the macros. I don't know how nim package are built, but you could provide other macros in the future for %build, %install, %check and so on if they are standardized.

Comment 4 Sergey Avseyev 2017-11-10 22:38:02 UTC
I see. I haven't packaged any library which using nim-specific package distribution (nimble), but I was going to do it. It makes sense to do before compiler itself will be approved.

Regarding %files, I've removed %attr. What do you mean, when you say "simplify"?

Comment 5 Robert-André Mauchin 🐧 2017-11-10 22:59:53 UTC
See what I posted above: remove the %dir and remove the asterisk after the directories:

%files
%license copying.txt dist/nimble/license.txt
%doc %{_docdir}/nim/
%{_bindir}/nim*
%config(noreplace) %{_sysconfdir}/*.cfg
%{_datadir}/nim/
%{_datadir}/nimble/
%{_mandir}/man1/nim*.1*
%{bashcompdir}/nim*

Comment 6 Sergey Avseyev 2017-11-11 21:43:12 UTC
I have created separate another package in https://bugzilla.redhat.com/show_bug.cgi?id=1512228, and now I will try to buildroot-override to rebuild this package

Comment 7 Sergey Avseyev 2017-11-16 04:45:21 UTC
I have updated file list and added more fixes and enhancements, like forcing Fedora hardened compiler flags, building HTML docs, extracting optional tools into separate package etc.

Spec URL: https://avsej.fedorapeople.org/nim/2/nim.spec
SRPM URL: https://avsej.fedorapeople.org/nim/2/nim-0.17.2-1.fc28.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23151579

Comment 8 Robert-André Mauchin 🐧 2017-11-16 14:36:13 UTC
All good, package accepted.

Comment 9 Gwyn Ciesla 2017-11-16 14:45:19 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nim. You may commit to the branch "f27" in about 10 minutes.

Comment 10 Fedora Update System 2017-11-30 10:29:51 UTC
nim-0.17.2-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fdd61480bc

Comment 11 Fedora Update System 2017-12-02 19:53:33 UTC
nim-0.17.2-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fdd61480bc

Comment 12 Fedora Update System 2017-12-12 11:19:26 UTC
nim-0.17.2-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.