Bug 1512440 - [atomic registry] Should always populate tags of new image for imagestream
Summary: [atomic registry] Should always populate tags of new image for imagestream
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Registry Console
Version: 3.7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 3.11.z
Assignee: Martin Pitt
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On: 1373332
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-13 09:13 UTC by Yadan Pei
Modified: 2021-06-10 13:33 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2020-05-13 17:58:20 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Yadan Pei 2017-11-13 09:13:01 UTC
Description of problem:
Should always populate tags of new image for imagestream

Version-Release number of selected component (if applicable):
OCP 3.7.7
Cockpit 155

How reproducible:
Always

Steps to Reproduce:
1.Create ImageStream, set it to "Sync all tags from a remote image repository" and Pull from "docker.io/openshift/hello-openshift" 
2.Edit ImageStream, set Pull from "docker.io/yapei/busybox"

Actual results:
2.Still show Tags for old image "docker.io/openshift/hello-openshift"

Expected results:
2. After imagestream pulling repository changed, should pull new images and sync its tags

Additional info:

Comment 1 Ryan Howe 2017-11-21 20:57:20 UTC
Work around would be use the cli. 
 # oc import-image NAME --all --confirm 

I was able to reproduce as well with the registry console as well.

Comment 3 Yadan Pei 2017-11-22 08:39:51 UTC
We found this issue recently because we missed the checkpoint in test case, and I think it's not a release blocker for registry console

Comment 7 Martin Pitt 2018-01-02 09:51:04 UTC
Peter fixed this at least partially in https://github.com/cockpit-project/cockpit/pull/8308 . @Peter: What aspect is left?

Comment 8 Peter 2018-01-02 14:12:25 UTC
The pulling part is fixed. But the removing tags part doesn't work well. Needs to fixed along with #1373332.

Comment 11 Yanping Zhang 2018-01-26 06:01:17 UTC
The bug still exists on OCP v3.7.26.

Comment 12 Martin Pitt 2018-02-14 09:56:41 UTC
bugzilla keeps complaining about "missing doc text"; this is a small bug fix (and there isn't even a fix yet), so disabling the doc update for now.

Comment 14 Martin Pitt 2018-03-12 16:56:35 UTC
As said above, tag syncing on pulling should work in the current release. The cleanup on removing tags depends on 1373332 which needs an API in OpenShift. Thus this part is blocked and definitively won't be fixed in 3.7.z, so moving milestone.

Comment 15 Taneem Ibrahim 2018-03-12 21:34:42 UTC
(In reply to Martin Pitt from comment #14)
> As said above, tag syncing on pulling should work in the current release.
> The cleanup on removing tags depends on 1373332 which needs an API in
> OpenShift. Thus this part is blocked and definitively won't be fixed in
> 3.7.z, so moving milestone.

When you say current release, what release version exactly are you implying to? The current release is v3.7.23. I believe the bug still exists there.

Comment 16 Martin Pitt 2018-03-13 16:17:02 UTC
@Taneem: The pull fix landed in Cockpit 159 on Jan 10, and got built for RHEL on the same day (https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=638219). I don't have insights into which cockpit version went into which RHEL Container Platform release, though - I understand releasing involves grabbing a current Cockpit brew build and including that?

Comment 17 Brenton Leanhardt 2018-03-16 13:17:14 UTC
Hi Martin,

If I'm understanding correctly, what needs to happen is for OpenShift's build to ensure it's pulling in the latest GA version of cockpit.  It looks like 160 was release recently.  I'm make sure the OpenShift build team knows.

Comment 18 Brenton Leanhardt 2018-03-16 13:21:01 UTC
To be clear, is any fix required in the OpenShift codebase or is this limited to cockpit?

Comment 19 Martin Pitt 2018-03-16 14:55:57 UTC
@Brenton: For that part of the fix it's only Cockpit (≥ 159). I see you are pulling in 160, that seems fine.

Comment 20 Brenton Leanhardt 2018-03-16 15:01:21 UTC
Hi Martin, I apologize if I wasn't clear.  Does any OpenShift code need to be fixed to resolve this bug?

When you say, "that part of the fix" it makes me think there is another part that I'm not understanding.

Comment 21 Martin Pitt 2018-03-16 15:13:00 UTC
Ah, sorry; the "other part" refers to bug 1373332, but I think it's fine to restrict the scope of *this* bug to the already fixed part, and keep 1373332 for the other one (that needs OpenShift fixes, or at least documentation how to do it with the API).

Comment 22 Martin Pitt 2018-03-16 15:13:35 UTC
> it's fine to restrict the scope of *this* bug to the already fixed part

... which is a fix only in Cockpit, no OpenShift change necessary.

Comment 24 Yadan Pei 2018-03-30 01:44:29 UTC
Since bug is targeted to 3.11 and issue still reproduce on latest v3.7.42, I think it should be dropped from errata 32336, right?

Comment 25 Yadan Pei 2018-03-30 02:35:30 UTC
Move back to MODIFIED

Comment 26 Yadan Pei 2018-03-30 02:36:04 UTC
Sorry should be ASSIGNED

Comment 28 Martin Pitt 2018-04-11 10:07:02 UTC
> I think it should be dropped from errata 32336

Right, and this happened. Clearing needinfo request.

Comment 32 Martin Pitt 2020-05-13 17:58:20 UTC
Minor feature/bug, not relevant any more for current OpenShift, and this product is in low-maintenance mode.


Note You need to log in before you can comment on or make changes to this bug.