Bug 1512451 - Not able to create snapshot
Summary: Not able to create snapshot
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: snapshot
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Sunny Kumar
QA Contact:
URL:
Whiteboard:
: 1512450 (view as bug list)
Depends On: 1507394
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-13 09:28 UTC by Kotresh HR
Modified: 2018-03-15 11:20 UTC (History)
9 users (show)

Fixed In Version: glusterfs-4.0.0
Clone Of: 1507394
Environment:
Last Closed: 2018-03-15 11:20:54 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kotresh HR 2017-11-13 09:28:34 UTC
+++ This bug was initially created as a clone of Bug #1507394 +++

Description of problem:

The snapshot creation failing after brick reset was done. The reset brick was done due to file system corruption on brick disk. 
'gluster snapshot create' command is failing with below errors
failed to get snap UUID , Failed to create snapshot , Snapshot Commit Failed , Failed to aggregate response from  node/brick

Version-Release number of selected component (if applicable):
mainline


How reproducible:


Actual results:
Not able to create snapshot


Expected results:
Able to create snapshot

Comment 1 Kotresh HR 2017-11-13 09:51:37 UTC
*** Bug 1512450 has been marked as a duplicate of this bug. ***

Comment 2 Worker Ant 2017-11-13 10:37:53 UTC
REVIEW: https://review.gluster.org/18730 (snapshot : snapshot creation failed after brick reset/replace) posted (#1) for review on master by Sunny Kumar

Comment 3 Worker Ant 2017-11-28 07:28:02 UTC
COMMIT: https://review.gluster.org/18730 committed in master by  with a commit message- snapshot : snapshot creation failed after brick reset/replace

Problem : snapshot creation was failing after brick reset/replace

Fix : changed code to set mount_dir value in rsp_dict during prerequisites
      phase i.e glusterd_brick_op_prerequisites call and removed form prevalidate
      phase.
Signed-off-by: Sunny Kumar <sunkumar>

Change-Id: Ief5d0fafe882a7eb1a7da8535b7c7ce6f011604c
BUG: 1512451

Comment 4 Worker Ant 2017-12-19 07:29:07 UTC
REVIEW: https://review.gluster.org/19049 (snapshot : after brick reset/replace snapshot creation fails) posted (#1) for review on master by Sunny Kumar

Comment 5 Worker Ant 2017-12-29 09:50:12 UTC
COMMIT: https://review.gluster.org/19049 committed in master by \"Sunny Kumar\" <sunkumar> with a commit message- snapshot : after brick reset/replace snapshot creation fails

Problem : after brick reset/replace snapshot creation fails

Solution : During brick reset/replace when we validate and aggrigate
           dictionary data from another node it was rewriting
           'mount_dir' value to NULL which is critical for snapshot
           creation.

Change-Id: Iabefbfcef7d8ac4cbd2a241e821c0e51492c093e
BUG: 1512451
Signed-off-by: Sunny Kumar <sunkumar>

Comment 6 Shyamsundar 2018-03-15 11:20:54 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.0.0, please open a new bug report.

glusterfs-4.0.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-March/000092.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.