RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1512844 - cache_restore tool may corrupt cache metadata
Summary: cache_restore tool may corrupt cache metadata
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: device-mapper-persistent-data
Version: 7.5
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: rc
: ---
Assignee: LVM and device-mapper development team
QA Contact: Jakub Krysl
URL:
Whiteboard:
Depends On:
Blocks: 1515109
TreeView+ depends on / blocked
 
Reported: 2017-11-14 09:36 UTC by Marian Csontos
Modified: 2021-09-03 12:06 UTC (History)
8 users (show)

Fixed In Version: device-mapper-persistent-data-0.7.3-3.el7
Doc Type: If docs needed, set a value
Doc Text:
Previously, the cache_restore utility passed incorrect arguments to a function. Additionally, it missed a call to flush dirty bits when version 2 metadata of the cache was used. As a consequence, the utility corrupted the cache metadata. With this update, cache_restore now handles the arguments correctly and adds the missing call. As a result, the utility no longer corrupts version 2 metadata.
Clone Of:
: 1515109 (view as bug list)
Environment:
Last Closed: 2018-04-10 13:18:38 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2018:0776 0 None None None 2018-04-10 13:18:47 UTC

Description Marian Csontos 2017-11-14 09:36:38 UTC
Description of problem:
Under some circumstances cache_restore tool corrupts metadata.

Version-Release number of selected component (if applicable):
device-mapper-persistent-data-0.7.3

Sorry for being so vague. Waiting for devel to fill in reproducer.

Comment 2 Joe Thornber 2017-11-14 09:43:31 UTC
v0.7.0 of the tools introduced support for cache metadata v2.

However cache restore was not writing a crucial field to the superblock.  So the kernel cannot load the metadata.

This patch fixes it:

https://github.com/jthornber/thin-provisioning-tools/commit/e3b7d825696c23c23f6bd867de4dbda69be38db8

The bug wasn't discovered for a long time because a separate bug meant v1 metadata was always being written even if v2 was requested.

v0.7.5 behaves correctly.

Comment 5 Jakub Krysl 2017-11-20 13:30:10 UTC
before:
# cache_restore -V
0.7.0-0.1.rc6.el7
# cache_restore -i metadata -o /dev/mapper/vgtest-swapvol --debug-override-metadata-version 2
cache_restore: /usr/include/boost/optional/optional.hpp:631: boost::optional<T>::reference_type boost::optional<T>::get() [with T = long unsigned int; boost::optional<T>::reference_type = long unsigned int&]: Assertion `this->is_initialized()' failed.
Aborted (core dumped)

with this patch:
# cache_restore -V
0.7.0-0.1.rc6.el7_4.1
# cache_restore -i metadata -o /dev/mapper/vgtest-swapvol --debug-override-metadata-version 2
Restoring: [==================================================]   100%

Comment 8 errata-xmlrpc 2018-04-10 13:18:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0776


Note You need to log in before you can comment on or make changes to this bug.