Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1512901

Summary:	[CodeChange] Refactor DeactivateStorageDomainWithOvfUpdateCommand to use CoCo framework and steps
Product:	[oVirt] ovirt-engine	Reporter:	Eyal Shenitzky <eshenitz>
Component:	BLL.Storage	Assignee:	Eyal Shenitzky <eshenitz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Elad <ebenahar>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.2.0	CC:	bugs, ebenahar, eshenitz
Target Milestone:	ovirt-4.3.0	Keywords:	CodeChange
Target Release:	4.3.0	Flags:	rule-engine: ovirt-4.3+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.3.0_alpha	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-13 07:46:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eyal Shenitzky 2017-11-14 12:14:45 UTC

Description of problem:

Currently in our code DeactivateStorageDomainWithOvfUpdateCommand doesn't use CoCo properlly.

There are internal calls in the command that should be managed by steps and callbacks.

A refactor work is required in order to make full use of the CoCo framework.


Version-Release number of selected component (if applicable):
4.2 - from commit 94a367e890bc95afdc6427893481c76ed3954c9a

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:
Partial use in the CoCo framework

Expected results:
Command should use the CoCo framework 


Additional info:

Comment 2 Elad 2018-11-20 08:28:54 UTC

Any specific scenario we should cover?

Comment 3 Eyal Shenitzky 2018-11-20 08:30:40 UTC

(In reply to Elad from comment #2)
> Any specific scenario we should cover?

Only regression tests

Comment 4 Elad 2018-12-06 12:56:26 UTC

Moving to VERIFIED as no related regressions were found in 4.3 alpha build regression automation cycles.


rhv-4.3.0-5
ovirt-engine-4.3.0-0.5.alpha1.el7.noarch
vdsm-4.30.3-1.el7ev.x86_64

Comment 5 Sandro Bonazzola 2019-02-13 07:46:35 UTC

This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.