Bug 1513005 - removing last vNIC by the VM selects the first one left, but selection is not visible
Summary: removing last vNIC by the VM selects the first one left, but selection is not...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.2.0
: ---
Assignee: Alexander Wels
QA Contact: Lucie Leistnerova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-14 15:09 UTC by Lucie Leistnerova
Modified: 2017-12-20 11:00 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2017-12-20 11:00:49 UTC
oVirt Team: UX
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)
removing vnic (89.63 KB, image/png)
2017-11-14 15:09 UTC, Lucie Leistnerova
no flags Details
removing vnic 2 (111.74 KB, image/png)
2017-11-20 14:49 UTC, Lucie Leistnerova
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 84277 0 master MERGED webadmin: remove vnics 2020-02-12 13:19:25 UTC
oVirt gerrit 84755 0 master MERGED webadmin: fix double selection when removing nics 2020-02-12 13:19:25 UTC

Description Lucie Leistnerova 2017-11-14 15:09:14 UTC
Created attachment 1352020 [details]
removing vnic

Description of problem:
When I remove the last vNIC by the VM, nothing new seems to be selected. But Remove button is active and clicking on it removes the first one in list.

Version-Release number of selected component (if applicable):
ovirt-engine-webadmin-portal-4.2.0-0.0.master.20171113223918.git25568c3.el7.centos.noarch

How reproducible: always


Steps to Reproduce:
1. have VM with Network Interfaces - vnic1, vnic2, vnic3 (displayed in this order)
2. remove vnic3, vnic3 is removed and nothing new selected
3. click on Remove

Actual results: vnic1 is the one to be removed, but is not selected, see attachment


Expected results: Remove button shouldn't be active or the vnic1 should be selected

Comment 1 Alexander Wels 2017-11-16 20:13:22 UTC
Note there is some code that auto selects the first vnic if none are selected. The patch will properly display the selected vnic.

Comment 2 Lucie Leistnerova 2017-11-20 14:49:00 UTC
When last vNIC is removed, first one is selected. But it selects first one and other vNIC at once when other vNIC is removed than the last one.

Steps to reproduce:
1. by the VM create nic2, nic3, nic4, in that order are displayed
2. remove nic3

Result: nic1 and nic4 are selected and will be both deleted, see attachment

tested in 
ovirt-engine-webadmin-portal-4.2.0-0.0.master.20171119135709.git6d448d3.el7.centos.noarch

Comment 3 Lucie Leistnerova 2017-11-20 14:49:32 UTC
Created attachment 1355882 [details]
removing vnic 2

Comment 4 Lucie Leistnerova 2017-12-07 10:59:08 UTC
Now is always only one interface selected

verified in ovirt-engine-webadmin-portal-4.2.0-0.6.el7.noarch

Comment 5 Sandro Bonazzola 2017-12-20 11:00:49 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.