Bug 1513040 - Create rpm macro %{_modprobedir} in /usr/lib/rpm/macros.d/macros.kmod
Summary: Create rpm macro %{_modprobedir} in /usr/lib/rpm/macros.d/macros.kmod
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: kmod
Version: 28
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: kmod development team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-14 16:07 UTC by Jaroslav Kysela
Modified: 2019-05-28 19:37 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-05-28 19:37:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jaroslav Kysela 2017-11-14 16:07:03 UTC
Description of problem:

Some packages (alsa-lib, b43-openfwwf, hwdata) use hardcoded path /lib/modprobe.d for the additional modprobe configuration files. It would be more appropriate to use the path defined by a rpm macro. Example of rpmlint errors:

alsa-lib.src:108: E: hardcoded-library-path in /lib/modprobe.d/dist-*

Example contents of macros.kmod file:

  # RPM macros for packages with additional kernel module configurations

  %_depmodconfdir %{_sysconfdir}/depmod.d
  %_modprobeconfdir %{_sysconfdir}/modprobe.d
  %_modprobedir /lib/modprobe.d

Note:

The kmod package should create also usr/lib/rpm/macros.d directory in case when the rpm package is not installed! See selinux-policy for example:

  $ rpm -qf /usr/lib/rpm/macros.d
  javapackages-tools-4.7.0-17.fc26.noarch
  selinux-policy-3.13.1-260.13.fc26.noarch
  rpm-4.13.0.2-1.fc26.x86_64

Comment 1 Josh Boyer 2017-11-15 17:55:20 UTC
Why would we do this in the kmod package itself, vs in redhat-rpm-config?  We already ship some kmod related files in the latter, so it would make more sense to consolidate that there.  Plus, this seems to be a distro-specific change not something directly related to kmod, correct?

Comment 2 Jaroslav Kysela 2017-11-15 18:26:57 UTC
It's just a proposal. Anyway, systemd (and many other core-system packages) like systemd and selinux-policy contains those macros, too. And I believe that's the purpose of the /usr/lib/rpm/macros.d directory. The kmod package uses those paths, so it should define them, too.

I added Florian for comments.

Comment 3 Fedora End Of Life 2018-02-20 15:32:32 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 4 Ben Cotton 2019-05-02 22:04:02 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Ben Cotton 2019-05-28 19:37:00 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.