Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1513477

Summary:	Check of lock in periodic task is incorrect
Product:	Red Hat OpenStack	Reporter:	Michel Peterson <mpeterso>
Component:	python-networking-odl	Assignee:	Michel Peterson <mpeterso>
Status:	CLOSED ERRATA	QA Contact:	Itzik Brown <itbrown>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	12.0 (Pike)	CC:	jschluet, mkolesni, nyechiel
Target Milestone:	beta	Keywords:	Triaged
Target Release:	13.0 (Queens)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-networking-odl-12.0.1-0.20180228140714.8733cf6.el7ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:	N/A
Last Closed:	2018-06-27 13:39:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michel Peterson 2017-11-15 13:57:33 UTC

Description of problem:

A refactor patch [1] introduced an error in the logic of the `execute_ops` of `PeriodicTask` [2] (L100) where it no longer tests for a `False` condition but instead for a `True`.

[1] https://review.openstack.org/#/c/500584/
[2] https://review.openstack.org/#/c/500584/13/networking_odl/journal/periodic_task.py


Version-Release number of selected component (if applicable): n/a


How reproducible: 100%


Steps to Reproduce:
1. Run neutron
2. Look at the logs


Actual results:

The periodic task is locked but at the same time it's logged that the task is locked and no operations are run. Next iteration operations will be run and then unlocked.

Expected results:

The periodic task is locked, operations are executed and then unlocked.
Additional info:

Comment 2 Michel Peterson 2017-11-22 13:05:44 UTC

Fix merged in master and stable/pike

Comment 9 Mike Kolesnik 2018-04-01 12:28:13 UTC

I checked it on Itzik's deployment, this is fine now as the maintenance task is executing normally as it should by it's defined interval.

Comment 11 errata-xmlrpc 2018-06-27 13:39:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:2086