Bug 1513477 – Check of lock in periodic task is incorrect

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1513477 - Check of lock in periodic task is incorrect

Summary:	Check of lock in periodic task is incorrect

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat OpenStack
Classification:	Red Hat
Component:	python-networking-odl (Show other bugs)
Sub Component:
Version:	12.0 (Pike)
Hardware:	Unspecified Unspecified

Priority	urgent Severity urgent
Target Milestone:	beta
Target Release:	13.0 (Queens)
Assigned To:	Michel Peterson
QA Contact:	Itzik Brown
Docs Contact:

URL:
Whiteboard:
Keywords:	Triaged

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2017-11-15 08:57 EST by Michel Peterson
Modified:	2018-10-18 03:19 EDT (History)
CC List:	3 users (show)

See Also:
Fixed In Version:	python-networking-odl-12.0.1-0.20180228140714.8733cf6.el7ost
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:	N/A
Last Closed:	2018-06-27 09:39:31 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Launchpad	1731893	None	None	None	2017-11-15 08:58 EST
OpenStack gerrit	519384	None	master: MERGED	networking-odl: Fix on PeriodicTask locking mechanism (I4288274bced051236e163f5786b91fe408f8453d)	2018-03-29 12:04 EDT
OpenStack gerrit	520572	None	stable/pike: MERGED	networking-odl: Fix on PeriodicTask locking mechanism (I4288274bced051236e163f5786b91fe408f8453d)	2018-03-29 12:04 EDT
Red Hat Product Errata	RHEA-2018:2086	None	None	None	2018-06-27 09:40 EDT

Groups: None (edit)

Description Michel Peterson 2017-11-15 08:57:33 EST

Description of problem:

A refactor patch [1] introduced an error in the logic of the `execute_ops` of `PeriodicTask` [2] (L100) where it no longer tests for a `False` condition but instead for a `True`.

[1] https://review.openstack.org/#/c/500584/
[2] https://review.openstack.org/#/c/500584/13/networking_odl/journal/periodic_task.py


Version-Release number of selected component (if applicable): n/a


How reproducible: 100%


Steps to Reproduce:
1. Run neutron
2. Look at the logs


Actual results:

The periodic task is locked but at the same time it's logged that the task is locked and no operations are run. Next iteration operations will be run and then unlocked.

Expected results:

The periodic task is locked, operations are executed and then unlocked.
Additional info:

Comment 2 Michel Peterson 2017-11-22 08:05:44 EST

Fix merged in master and stable/pike

Comment 9 Mike Kolesnik 2018-04-01 08:28:13 EDT

I checked it on Itzik's deployment, this is fine now as the maintenance task is executing normally as it should by it's defined interval.

Comment 11 errata-xmlrpc 2018-06-27 09:39:31 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:2086

Note You need to log in before you can comment on or make changes to this bug.