Bug 1514722

I was comparing the code is OSP 8 and later versions

From OSP 8 
~~~
/usr/share/openstack-tripleo-heat-templates/liberty/extraconfig
~~~
 46 # Special-case OVS for https://bugs.launchpad.net/tripleo/+bug/1635205
 47 if [[ -n $(rpm -q --scripts openvswitch | awk '/postuninstall/,/*/' | grep "systemctl.*try-restart") ]]; then
 48     echo "Manual upgrade of openvswitch - restart in postun detected"
 49     mkdir OVS_UPGRADE || true
 50     pushd OVS_UPGRADE
 51     echo "Attempting to downloading latest openvswitch with yumdownloader"
 52     yumdownloader --resolve openvswitch
 53     echo "Updating openvswitch with nopostun option"
 54     rpm -U --replacepkgs --nopostun ./*.rpm
 55     popd
 56 else
 57     echo "Skipping manual upgrade of openvswitch - no restart in postun detected"
 58 fi
~~~

In OSP 9 we run a cleanup :
~~~
     64 # Special-case OVS for https://bugs.launchpad.net/tripleo/+bug/1635205
     65 function special_case_ovs_upgrade_if_needed {
     66     if [[ -n $(rpm -q --scripts openvswitch | awk '/postuninstall/,/*/' | grep "systemctl.*try-restart") ]]; then
     67         echo "Manual upgrade of openvswitch - restart in postun detected" 
     68         rm -rf OVS_UPGRADE   <<============= 
     69         mkdir OVS_UPGRADE && pushd OVS_UPGRADE
     70         echo "Attempting to downloading latest openvswitch with yumdownloader"
     71         yumdownloader --resolve openvswitch
     72         for pkg in $(ls -1 *.rpm);  do
     73             if rpm -U --test $pkg 2>&1 | grep "already installed" ; then
     74                 echo "Looks like newer version of $pkg is already installed, skipping"
     75             else
     76                 echo "Updating $pkg with nopostun option"
     77                 rpm -U --replacepkgs --nopostun $pkg
     78             fi
     79         done
     80         popd
     81     else
     82         echo "Skipping manual upgrade of openvswitch - no restart in postun detected"
     83     fi
     84 
     85 }

~~~

In OSP 10 also we run the cleanup :
~~~
301 # Special-case OVS for https://bugs.launchpad.net/tripleo/+bug/1635205
302 # Update condition and add --notriggerun for +bug/1669714
303 function special_case_ovs_upgrade_if_needed {
304     # Always ensure yum has full cache
305     yum makecache || echo "Yum makecache failed. This can cause failure later on."
306     if rpm -qa | grep "^openvswitch-2.5.0-14" || rpm -q --scripts openvswitch | awk '/postuninstall/,/*/' | grep "systemctl.*try-restart" ; then
307         echo "Manual upgrade of openvswitch - ovs-2.5.0-14 or restart in postun detected"
308         rm -rf OVS_UPGRADE <<=========
309         mkdir OVS_UPGRADE && pushd OVS_UPGRADE
310         echo "Attempting to downloading latest openvswitch with yumdownloader"
311         yumdownloader --resolve openvswitch
312         for pkg in $(ls -1 *.rpm);  do
313             if rpm -U --test $pkg 2>&1 | grep "already installed" ; then
314                 echo "Looks like newer version of $pkg is already installed, skipping"
315             else
316                 echo "Updating $pkg with --nopostun --notriggerun"
317                 rpm -U --replacepkgs --nopostun --notriggerun $pkg
318             fi
319         done
320         popd
321     else
322         echo "Skipping manual upgrade of openvswitch - no restart in postun detected"
323     fi
324 
325 }

~~~

Thanks Shatadru Bandyopadhyay - comment #2 is right .. we landed something to make the manual ovs upgrade more robust and cherrypicked to OSP9 but not OSP8 it seems. I'm going to post it and we can use this BZ for tracking that

As per comment #2 this is in OSP9 with https://code.engineering.redhat.com/gerrit/#/c/112974/ ... so if this is upgrade of OSP8 to OSP9 they should already have this ^^ in their openstack-tripleo-heat-templates? 

I'm going to post the OSP8 cherrypick anyway, but if they upgrade their undercloud to OSP9 then they should have latest OSP9 tht with the more robust ovs upgrade from /#/c/112974/

According to our records, this should be resolved by openstack-tripleo-heat-templates-2.0.0-67.el7ost.  This build is available now.