Description of problem:
Step 4 fails (all compute nodes) with
Error: Could not set 'file' on ensure: No such file or directory - /etc/nova/migration/authorized_keys20171117-202194-zyg2kc.lock at 187:/etc/puppet/modules/tripleo/manifests/profile/base/nova.pp
when updating Overcloud that is in production. I tested Overcloud deploy with new RHOSP image released in z6 and I don't see this error, so looking deep into this issue I see that directory /etc/nova/migration/ is already create in the new overcloud image released with z6 but old Images used in production today does not have that directory, and that is the reason overcloud update fails, see below in a site that was not updated to z6

[root@ ~]# cd /etc/nova/
[root@ nova]# ll
total 308
-rw-r-----. 1 root nova   2717 Dec 19  2016 api-paste.ini
-rw-r-----. 1 root nova   3562 Nov 14 23:13 nova.conf
-rw-r-----. 1 root nova 289245 Feb  7  2017 nova.conf.rpmnew
-rw-r-----. 1 root nova      4 Nov 14 23:13 policy.json
-rw-r-----. 1 root root      4 Nov 14 23:13 policy.json.bk
-rw-r--r--. 1 root root     71 Feb  7  2017 release
-rw-r-----. 1 root nova    966 Dec 19  2016 rootwrap.conf
[root@ nova]#

so /etc/puppet/modules/tripleo/manifests/profile/base/nova.pp is trying to create keys files without checking if directory is there or not

      file { '/etc/nova/migration/authorized_keys':
        content => $migration_authorized_keys,
        mode    => '0640',
        owner   => 'root',
        group   => 'nova_migration',
        require => Package['openstack-nova-migration']
      }

      file { '/etc/nova/migration/identity':
        content => $migration_identity,
        mode    => '0600',
        owner   => 'nova',
        group   => 'nova',
        require => Package['openstack-nova-migration']
      }

Version-Release number of selected component (if applicable):


How reproducible:
every time