Bug 1514906
| Summary: | Race between adding storage domains and a host leaves host as non-operational | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Yaniv Kaul <ykaul> | ||||
| Component: | BLL.Storage | Assignee: | Allon Mureinik <amureini> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Raz Tamir <ratamir> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 4.2.0 | CC: | bugs, dron, nsoffer | ||||
| Target Milestone: | --- | Flags: | sbonazzo:
ovirt-4.2-
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-11-27 11:08:02 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Yaniv Kaul
2017-11-19 11:48:20 UTC
A host must be connected to all storage domains, so adding a host and storage domain in the same time is likely to cause trouble. The host may not have access to the storage domain since it was not asked to connect to it yet (the host did not exist when engine added the storage domain). For system tests, it is best to add the storage domains only after the hosts were added, or add all the storage domains before adding the extra host, but not mix the two flows. In a real setup, new host becoming non-operational will recover automatically after several minutes, so this may not be a real issue. In the tests, we don't want to wait for several minutes until a host recovers. System tests should not test esoteric edge cases but the normal flow. (In reply to Nir Soffer from comment #1) > A host must be connected to all storage domains, so adding a host and > storage > domain in the same time is likely to cause trouble. The host may not have > access > to the storage domain since it was not asked to connect to it yet (the host > did > not exist when engine added the storage domain). > > For system tests, it is best to add the storage domains only after the hosts > were > added, or add all the storage domains before adding the extra host, but not > mix > the two flows. > > In a real setup, new host becoming non-operational will recover automatically > after several minutes, so this may not be a real issue. In the tests, we > don't want > to wait for several minutes until a host recovers. System tests should not > test > esoteric edge cases but the normal flow. You are probably right - I was trying to make the suite run faster - so I wait for the 1st host to be up and then use it to create the master storage domain and the then the other storage domains. What bothers me is that it did not fail until last week or so - it worked well for quite some time. Posted https://gerrit.ovirt.org/84397 to ensure all hosts are added before secondary domains are added. (In reply to Yaniv Kaul from comment #2) > (In reply to Nir Soffer from comment #1) > > A host must be connected to all storage domains, so adding a host and > > storage > > domain in the same time is likely to cause trouble. The host may not have > > access > > to the storage domain since it was not asked to connect to it yet (the host > > did > > not exist when engine added the storage domain). > > > > For system tests, it is best to add the storage domains only after the hosts > > were > > added, or add all the storage domains before adding the extra host, but not > > mix > > the two flows. > > > > In a real setup, new host becoming non-operational will recover automatically > > after several minutes, so this may not be a real issue. In the tests, we > > don't want > > to wait for several minutes until a host recovers. System tests should not > > test > > esoteric edge cases but the normal flow. > > You are probably right - I was trying to make the suite run faster - so I > wait for the 1st host to be up and then use it to create the master storage > domain and the then the other storage domains. > > What bothers me is that it did not fail until last week or so - it worked > well for quite some time. Perhaps you made it work too fast :-) Targetting to 4.2.1 - this doesn't seem to be an oVirt GA blocker. Having said that - QE/PM - please weigh in here. (In reply to Yaniv Kaul from comment #3) > Posted https://gerrit.ovirt.org/84397 to ensure all hosts are added before > secondary domains are added. Closing as it doesn't seem a very interesting scenario and the above eliminated it from ovirt-system-tests. |