1514915 – Unable to create location with organization_ids: [1] - Organizations is invalid

Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1514915 - Unable to create location with organization_ids: [1] - Organizations is invalid

Summary: Unable to create location with organization_ids: [1] - Organizations is invalid

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Satellite
Classification:	Red Hat
Component:	Organizations and Locations
Sub Component:
Version:	6.3.0
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	medium
Target Milestone:	Unspecified
Assignee:	Tomer Brisker
QA Contact:	Roman Plevka
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2017-11-19 12:38 UTC by Roman Plevka
Modified:	2019-08-12 14:37 UTC (History)
CC List:	8 users (show)
Fixed In Version:	foreman-1.15.6.26-1
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2018-02-21 16:54:37 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Foreman Issue Tracker	22043	0	None	None	None	2017-12-20 16:55:30 UTC

Description Roman Plevka 2017-11-19 12:38:01 UTC

Description of problem:
this seems to be a regression since 6.2:

# curl -sku admin:changeme -d '{"location": {"name": "foo6", "organization_ids": [1]}}' -H 'Content-Type: application/json' https://$(hostname)/api/v2/locations 
{
  "error": {"id":null,"errors":{"organizations":["is invalid"]},"full_messages":["Organizations is invalid"]}
}

- specifying other (existing) organization id(s) works as expected

Version-Release number of selected component (if applicable):
6.3.0-25

How reproducible:
always

Actual results:
Organizations is invalid

Expected results:
Location created and assigned to Default Organization

Comment 1 Justin Sherrill 2017-11-20 16:13:24 UTC

Are you sure the organization has an id of 1?

Comment 4 Tomer Brisker 2017-11-21 09:53:51 UTC

I tested this with 6.3 and upstream, this does fail in 6.3 but not in upstream. I made sure the organization id existed before sending the request, if it doesn't the message is different - "Resource location not found by id ''"

Comment 5 Roman Plevka 2017-11-21 11:06:53 UTC

(In reply to Justin Sherrill from comment #1)
> Are you sure the organization has an id of 1?

yes.
# hammer organization list --search="id=1"
---|----------------------|----------------------|-------------|----------------------|------------
ID | TITLE                | NAME                 | DESCRIPTION | LABEL                | DESCRIPTION
---|----------------------|----------------------|-------------|----------------------|------------
1  | Default Organization | Default Organization |             | Default_Organization |            
---|----------------------|----------------------|-------------|----------------------|------------
[root@cisco-b200m1-04 ~]# curl -sku admin:changeme -d '{"location": {"name": "foo6", "organization_ids": [1]}}' -H 'Content-Type: application/json' https://$(hostname)/api/v2/locations
{
  "error": {"id":null,"errors":{"organizations":["is invalid"]},"full_messages":["Organizations is invalid"]}
}

Comment 6 Roman Plevka 2017-11-22 19:27:41 UTC

(In reply to Tomer Brisker from comment #4)
> I tested this with 6.3 and upstream, this does fail in 6.3 but not in
> upstream. I made sure the organization id existed before sending the
> request, if it doesn't the message is different - "Resource location not
> found by id ''"


I have the reproducer:

To make organization "invalid", just create 1 org and 1 loc and make sure, the org does NOT have the loc assigned. Now make the loc a default location for newly subscribed hosts. Then, register some content host to the Org.

This will effectively bring inconsistency into the org, since its host is restricted to a location which does not belong to the Org.

You can't use such organization for new location assignments until you fix the discrepency by assigning the loc to the org, or remove the the host.

Comment 8 Tomer Brisker 2017-12-20 14:47:40 UTC

Correction, this is also present upstream. The condition is that the organization being assigned has to be invalid - eg. has a hosts that are assigned resources which aren't in the organization.

Comment 10 Tomer Brisker 2017-12-20 16:55:27 UTC

Created redmine issue http://projects.theforeman.org/issues/22043 from this bug

Comment 11 Satellite Program 2017-12-20 17:24:59 UTC

Upstream bug assigned to tbrisker

Comment 12 Satellite Program 2017-12-20 17:25:04 UTC

Upstream bug assigned to tbrisker

Comment 13 Satellite Program 2018-01-02 17:26:47 UTC

Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/22043 has been resolved.

Comment 14 Roman Plevka 2018-01-09 08:49:34 UTC

FAILED QA:

this now also accepts non-existent locations - if the location does not exist, it will automatically create it, which is most probably not a desired behavior (at least it's inconsistent with the rest of the resource behavior).

# hammer location list --search="name=foo"
---|-------|------|------------
ID | TITLE | NAME | DESCRIPTION
---|-------|------|------------
[root@zzzap ~]# curl -sku admin:changeme -d '{"location": {"name": "foo", "organization_ids": [6]}}' -H 'Content-Type: application/json' https://$(hostname)/api/v2/locations >/dev/null
[root@zzzap ~]# hammer location list --search="name=foo"
---|-------|------|------------
ID | TITLE | NAME | DESCRIPTION
---|-------|------|------------
10 | foo   | foo  |            
---|-------|------|------------

Comment 15 Roman Plevka 2018-01-09 08:59:21 UTC

VERIFIED
on sat6.3.0-31

(In reply to Roman Plevka from comment #14)
> FAILED QA:
> 
> this now also accepts non-existent locations - if the location does not
> exist, it will automatically create it, which is most probably not a desired
> behavior (at least it's inconsistent with the rest of the resource behavior).
> 
> # hammer location list --search="name=foo"
> ---|-------|------|------------
> ID | TITLE | NAME | DESCRIPTION
> ---|-------|------|------------
> [root@zzzap ~]# curl -sku admin:changeme -d '{"location": {"name": "foo",
> "organization_ids": [6]}}' -H 'Content-Type: application/json'
> https://$(hostname)/api/v2/locations >/dev/null
> [root@zzzap ~]# hammer location list --search="name=foo"
> ---|-------|------|------------
> ID | TITLE | NAME | DESCRIPTION
> ---|-------|------|------------
> 10 | foo   | foo  |            
> ---|-------|------|------------


I'm sorry, (lack of coffee), i did not realized I'm doing POST request (thought i was doing PUT all the time). This is ofc the desired behavior and i can VERIFY this

Comment 16 Satellite Program 2018-02-21 16:54:37 UTC

Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA.
> > 
> > For information on the advisory, and where to find the updated files, follow the link below.
> > 
> > If the solution does not work for you, open a new bug report.
> > 
> > https://access.redhat.com/errata/RHSA-2018:0336

Note You need to log in before you can comment on or make changes to this bug.