Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-parameterized.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-parameterized-0.6.1-1.fc28.src.rpm Description: Parameterized testing with any Python test framework. Fedora Account System Username: ignatenkobrain
Taking this review.
I get this error while attempting to build the package (while running the unit tests): ====================================================================== Traceback (most recent call last): File "/usr/bin/nosetests-2.7", line 11, in <module> load_entry_point('nose==1.3.7', 'console_scripts', 'nosetests')() File "/usr/lib/python2.7/site-packages/nose/core.py", line 121, in __init__ **extra_args) File "/usr/lib64/python2.7/unittest/main.py", line 95, in __init__ self.runTests() File "/usr/lib/python2.7/site-packages/nose/core.py", line 207, in runTests result = self.testRunner.run(self.test) File "/usr/lib/python2.7/site-packages/nose/core.py", line 66, in run result.printErrors() File "/usr/lib/python2.7/site-packages/nose/result.py", line 103, in printErrors _TextTestResult.printErrors(self) File "/usr/lib64/python2.7/unittest/runner.py", line 108, in printErrors self.printErrorList('ERROR', self.errors) File "/usr/lib64/python2.7/unittest/runner.py", line 114, in printErrorList self.stream.writeln("%s: %s" % (flavour,self.getDescription(test))) File "/usr/lib64/python2.7/unittest/runner.py", line 24, in writeln self.write(arg) UnicodeEncodeError: 'ascii' codec can't encode character u'\xf6' in position 8: ordinal not in range(128)
try again, added export LC_ALL=C.UTF-8
It's still failing the same way...
Disabled tests for now..
Review notes: - Package is named properly - Package follows Python packaging guidelines - License is marked correctly - No notable issues from fedora-review or rpmlint PACKAGE APPROVED.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-parameterized