Red Hat Bugzilla – Bug 1515308
[RFE] [HC] Disable unrelated gluster hooks during host deploy
Last modified: 2018-05-14 11:10:30 EDT
Description of problem: While adding hosts to a hyperconverged cluster, gluster hooks that are not needed for this deployment should be disabled , that is, hooks related to SMB, NFS-Ganesha and CTDB. (similar to the flow in cockpit-gdeploy plugin, see https://github.com/gluster/gdeploy/blob/master/extras/scripts/disable-gluster-hooks.sh) Version-Release number of selected component (if applicable): NA
(In reply to Sahina Bose from comment #0) > Description of problem: > > While adding hosts to a hyperconverged cluster, gluster hooks that are not > needed for this deployment should be disabled , that is, hooks related to > SMB, NFS-Ganesha and CTDB. > > (similar to the flow in cockpit-gdeploy plugin, see > https://github.com/gluster/gdeploy/blob/master/extras/scripts/disable- > gluster-hooks.sh) > This is a bit ugly, no? Isn't there a cleaner way? Perhaps provide the content of above script as an official gluster command or something like that? If one day you need to rename any of these files, or add another one, do you really want to have to patch both ovirt-host-deploy and gdeploy? Should we fail if the renames fail? Is there any way to undo/rollback? Or if you want to use the machine for SMB/Ganesha/etc you are supposed to reinstall it?
(In reply to Yedidyah Bar David from comment #1) > (In reply to Sahina Bose from comment #0) > > Description of problem: > > > > While adding hosts to a hyperconverged cluster, gluster hooks that are not > > needed for this deployment should be disabled , that is, hooks related to > > SMB, NFS-Ganesha and CTDB. > > > > (similar to the flow in cockpit-gdeploy plugin, see > > https://github.com/gluster/gdeploy/blob/master/extras/scripts/disable- > > gluster-hooks.sh) > > > > This is a bit ugly, no? Isn't there a cleaner way? Perhaps provide the > content of above script as an official gluster command or something like > that? If one day you need to rename any of these files, or add another one, > do you really want to have to patch both ovirt-host-deploy and gdeploy? Unfortunately, this is currently the only way to disable hooks. > > Should we fail if the renames fail? I think no. > > Is there any way to undo/rollback? Or if you want to use the machine for > SMB/Ganesha/etc you are supposed to reinstall it? We do have a way to enable the hooks from oVirt via UI/API.
Tested with RHV 4.2.3-6 and gluster-3.12 1. When the nodes are added in to hyperconverged cluster, the gluster hooks are disabled. State of hooks post adding the host to the hyperconverged cluster [root@localhost ~]# tree /var/lib/glusterd/hooks/ /var/lib/glusterd/hooks/ └── 1 ├── add-brick │ ├── post │ │ ├── disabled-quota-root-xattr-heal.sh │ │ └── S13create-subdir-mounts.sh │ └── pre │ └── S28Quota-enable-root-xattr-heal.sh ├── create │ ├── post │ └── pre ├── delete │ ├── post │ │ └── S57glusterfind-delete-post -> /usr/libexec/glusterfs/glusterfind/S57glusterfind-delete-post.py │ └── pre ├── gsync-create │ ├── post │ │ └── S56glusterd-geo-rep-create-post.sh │ └── pre ├── remove-brick │ ├── post │ └── pre ├── reset │ ├── post │ └── pre ├── set │ ├── post │ │ ├── D30samba-set.sh │ │ └── S32gluster_enable_shared_storage.sh │ └── pre ├── start │ ├── post │ │ ├── D29CTDBsetup.sh │ │ └── D30samba-start.sh │ └── pre └── stop ├── post └── pre ├── D29CTDB-teardown.sh └── D30samba-stop.sh 28 directories, 11 files
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018. Since the problem described in this bug report should be resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.