Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1515746

Summary: Fail to install when specify openshift_builddefaults_json
Product: OpenShift Container Platform Reporter: liujia <jiajliu>
Component: InstallerAssignee: Scott Dodson <sdodson>
Status: CLOSED NOTABUG QA Contact: Gan Huang <ghuang>
Severity: high Docs Contact:
Priority: high    
Version: 3.7.0CC: aos-bugs, erich, ghuang, jokerman, knakayam, mmccomas, msomasun, wmeng
Target Milestone: ---Keywords: Reopened
Target Release: 3.7.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-11 13:21:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description liujia 2017-11-21 09:59:31 UTC
Description of problem:
Fail to install when specify openshift_builddefaults_json in hosts file.

TASK [openshift_builddefaults : Set builddefaults config structure] ************
Tuesday 21 November 2017  09:38:17 +0000 (0:00:02.222)       0:08:17.156 ****** 
fatal: [x.x.x.x]: FAILED! => {"changed": false, "failed": true, "module_stderr": "Shared connection to qe-jliu-37rpm1-master-etcd-1.1121-8yw.qe.rhcloud.com closed.\r\n", "module_stdout": "Traceback (most recent call last):\r\n  File \"/tmp/ansible_bvvA3a/ansible_module_openshift_facts.py\", line 2470, in <module>\r\n    main()\r\n  File \"/tmp/ansible_bvvA3a/ansible_module_openshift_facts.py\", line 2457, in main\r\n    protected_facts_to_overwrite)\r\n  File \"/tmp/ansible_bvvA3a/ansible_module_openshift_facts.py\", line 1830, in __init__\r\n    protected_facts_to_overwrite)\r\n  File \"/tmp/ansible_bvvA3a/ansible_module_openshift_facts.py\", line 1892, in generate_facts\r\n    facts = set_builddefaults_facts(facts)\r\n  File \"/tmp/ansible_bvvA3a/ansible_module_openshift_facts.py\", line 1599, in set_builddefaults_facts\r\n    facts['master']['admission_plugin_config'].update(builddefaults['config'])\r\nValueError: dictionary update sequence element #0 has length 1; 2 is required\r\n", "msg": "MODULE FAILURE", "rc": 0}


Version-Release number of the following components:
openshift-ansible-3.7.9-1.git.4.d445616.el7.noarch.rpm

How reproducible:
always

Steps to Reproduce:
1. Install with openshift_builddefaults_json specified in hosts.
 openshift_builddefaults_json: {"BuildDefaults":{"configuration":{"apiVersion":"v1","nodeSelector":{"registry": "enabled"},"kind":"BuildDefaultsConfig"}}}
2.
3.

Actual results:
Install failed.

Expected results:
Install succeed.

Additional info:
Please attach logs from ansible-playbook with the -vvv flag

Comment 1 liujia 2017-11-21 10:00:35 UTC
For v3.5, v3.6 fresh install has the same issue.

Comment 2 Gan Huang 2017-12-08 02:23:20 UTC
Verified in openshift-ansible-3.7.13-1.git.0.a8e2fcb.el7.noarch.rpm

Unable to reproduce with the parameter set:

openshift_builddefaults_json={"BuildDefaults":{"configuration":{"apiVersion":"v1","nodeSelector":{"registry": "enabled"},"kind":"BuildDefaultsConfig"}}}

Please feel free to reopen if it happens again.