Bug 1515954 - Gerrit vs GitHub mirror inconsistency for Nagios components
Summary: Gerrit vs GitHub mirror inconsistency for Nagios components
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: project-infrastructure
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-21 16:51 UTC by Niels de Vos
Modified: 2018-04-16 04:37 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-16 04:37:28 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2017-11-21 16:51:51 UTC
There are a few repositories involved in the Nagios integration for Gluster. These are maintained on review.gluster.org, but are not correctly mirrored to GitHub.

On http://git.gluster.org/cgit/ :

gluster-nagios
gluster-nagios-addons
gluster-nagios-common

On https://github.com/gluster/?q=nagios :

gluster-nagios-common
nagios-plugins-gluster
nagios-server-plugins-gluster

Referring users to the repositories is pretty confusing. Not only the names of the repositories are different, also the most recent modifications.

@Sahina, could you provide your preferred approach to address this?

Comment 1 Nigel Babu 2017-12-04 02:47:53 UTC
There's no action for infra to do. Once you folks decide, please re-open the bug.

Comment 2 Sahina Bose 2018-01-09 07:11:37 UTC
The repos used for gluster-nagios integration are:
gluster-nagios-common
gluster-nagios-addons
nagios-server-addons

These are mirrored to github as well, though the repo names are not in sync. I donot recall the reason why we did it that way

gluster-nagios-common --> gluster-nagios-common
gluster-nagios-addons --> nagios-plugins-gluster
nagios-server-addons --> nagios-server-plugins-gluster

Can we remove the gluster-nagios and nagios-gluster-addons repository from http://git.gluster.org/cgit/ 

Also, if we can rename the mirrored repository on Github to match the ones hosted on review.gluster.org, we can avoid the confusion. Is that possible?

Comment 3 Nigel Babu 2018-01-10 08:35:03 UTC
I would highly prefer not to remove them from Gerrit unless the primary source of truth for that code is Github. Removing it from git.gluster.org/cgit = removing it from Gerrit (at least in the current scenario). git.gluster.org is the web viewer for repos hosted with Gerrit.

We can change names at Gerrit or Github. That's your call. Github will redirect clones and pushes from old repo to new one. Gerrit won't. But then, I don't expect many people to use Gerrit for those repos.

In conclusion,
1. Do we want to delete these repos from Gerrit?
2. Is Github the source of truth?
3. Do want to rename the repos on Github or Gerrit to match the other? If so, which one?

Comment 4 Sahina Bose 2018-01-10 08:54:01 UTC
(In reply to Nigel Babu from comment #3)
> I would highly prefer not to remove them from Gerrit unless the primary
> source of truth for that code is Github. Removing it from
> git.gluster.org/cgit = removing it from Gerrit (at least in the current
> scenario). git.gluster.org is the web viewer for repos hosted with Gerrit.
> 
> We can change names at Gerrit or Github. That's your call. Github will
> redirect clones and pushes from old repo to new one. Gerrit won't. But then,
> I don't expect many people to use Gerrit for those repos.
> 
> In conclusion,
> 1. Do we want to delete these repos from Gerrit?

Delete gluster-nagios and nagios-gluster-addons from gerrit . These are not used and not mirrored to github either

> 2. Is Github the source of truth?

See above. Github is mirror for gerrit.

> 3. Do want to rename the repos on Github or Gerrit to match the other? If
> so, which one?

Rename the github repos to match gerrit.
So
nagios-plugins-gluster --> gluster-nagios-addons
nagios-server-plugins-gluster --> nagios-server-addons

Hope it's clear now?

Comment 5 Nigel Babu 2018-01-29 12:41:15 UTC
> Delete gluster-nagios and nagios-gluster-addons from gerrit . These are not
> used and not mirrored to github either

I've hidden them both. It's too complicated to delete Gerrit repos, but far easier to hide them. So I've done that.


> Rename the github repos to match gerrit.
> So
> nagios-plugins-gluster --> gluster-nagios-addons
> nagios-server-plugins-gluster --> nagios-server-addons

This is done.

Sahina also pointed out that should be synced in Gerrit, which it isn't anymore. I guess the old configs were commented out at some point. When I did the migration, I deleted the commented out configs. Fixing the autosync requires a Gerrit restart, so I'm leaving this bug open until we fix auto-sync. In the meanwhile, I'll manually sync over the repos.


Note You need to log in before you can comment on or make changes to this bug.