Bug 1517245 - [ALL_LANG] Truncated column names appear on volumes -> bricks -> advanced details -> memory pools page
Summary: [ALL_LANG] Truncated column names appear on volumes -> bricks -> advanced det...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ovirt-4.3.0
: 4.3.0
Assignee: Alexander Wels
QA Contact: samuel macko
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-24 11:32 UTC by Bhushan Barve
Modified: 2019-03-19 10:08 UTC (History)
6 users (show)

Fixed In Version: ovirt-engine-4.3.0_alpha
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-19 10:08:44 UTC
oVirt Team: UX
Embargoed:
tjelinek: ovirt-4.3?
bbarve: planning_ack?
rule-engine: devel_ack+
bbarve: testing_ack+


Attachments (Terms of Use)
column_names_truncated (76.93 KB, image/png)
2017-11-24 11:32 UTC, Bhushan Barve
no flags Details
ja_JP_truncation (65.50 KB, image/png)
2018-02-02 08:19 UTC, Bhushan Barve
no flags Details
de_DE_truncation_beta2 (191.15 KB, image/png)
2018-02-02 08:20 UTC, Bhushan Barve
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 86006 0 master MERGED webadmin: volume advanced details 2018-01-05 13:06:44 UTC
oVirt gerrit 87354 0 master MERGED webadmin: advanced brick properties grid 2018-02-09 13:07:38 UTC

Description Bhushan Barve 2017-11-24 11:32:12 UTC
Created attachment 1358638 [details]
column_names_truncated

Description of problem: Truncated column names appear on volumes -> bricks -> advanced details -> memory pools page. This is observed for all locales including en_US. The columns are not resizeable, so user is not able to view the full name. Please refer attached screenshot. 


Version-Release number of selected component (if applicable):
4.2.0-0.5.master.el7

How reproducible:
always

Steps to Reproduce:
1. Login to admin portal
2. Go to volumes -> bricks -> advanced details -> memory pools
3. Observe column names

Actual results:
The column names appear truncated with columns not resizeable.

Expected results:
The column names should be visible properly.

Additional info:

Comment 1 Alexander Wels 2017-11-28 21:01:18 UTC
So not quite sure what to do about this, some of the table headers are long, and adding 200px to the width wasn't enough to show them all properly in English, let alone other languages.

@Oved,
What do you want me to do? add even more width?

Comment 2 Greg Sheremeta 2017-11-28 21:53:15 UTC
In https://gerrit.ovirt.org/#/c/84771/, which is very similar, I set overflow: auto and removed the height set. So now the titles can wrap and the header can grow vertically.

Comment 3 Oved Ourfali 2017-11-29 04:32:12 UTC
Can we add the three dots and when you stand on it you see the text in a tooltip?

Comment 4 Oved Ourfali 2017-11-29 04:32:57 UTC
Or maybe we should shorten the text? (I mean the gluster team)

Comment 5 Oved Ourfali 2017-11-29 07:16:54 UTC
Only now noticed Greg's suggestion. Sounds better.

Comment 6 Alexander Wels 2017-12-11 13:04:18 UTC
Well don't think that will work as it will wrap the text in some columns and not others and the layout will be wonky. I believe Greg reverted his patch for https://gerrit.ovirt.org/#/c/84771/ as that was producing wonky results as well.

Comment 7 Greg Sheremeta 2017-12-11 13:25:38 UTC
Yes, ignore my previous suggestion.
revert = https://gerrit.ovirt.org/#/c/84938/
Shani's fix = https://gerrit.ovirt.org/#/c/84715/

Comment 8 Bhushan Barve 2018-02-02 08:19:11 UTC
Checked with the following build - 4.2.1.3-0.1.el7

Although there's much improvement in the mentioned truncation issue, still some column names appear truncated for locales other than zh_CN and ko_KR. For these two locales, it looks fine now.

Please refer attached screenshot.

Comment 9 Bhushan Barve 2018-02-02 08:19:41 UTC
Created attachment 1390008 [details]
ja_JP_truncation

Comment 10 Bhushan Barve 2018-02-02 08:20:09 UTC
Created attachment 1390009 [details]
de_DE_truncation_beta2

Comment 11 Greg Sheremeta 2018-03-10 13:39:15 UTC
f07b3c9 needs backport

greg@dauntless:/home/greg/projects/ovirt-engine(ovirt-engine-4.2|…) % git log master |grep Ib7795c6b82ba8588793ae430ed061b355dd46974
    Change-Id: Ib7795c6b82ba8588793ae430ed061b355dd46974
greg@dauntless:/home/greg/projects/ovirt-engine(ovirt-engine-4.2|…) % git log ovirt-engine-4.2 |grep Ib7795c6b82ba8588793ae430ed061b355dd46974
greg@dauntless:/home/greg/projects/ovirt-engine(ovirt-engine-4.2|…) %

Comment 12 RHV bug bot 2018-03-16 15:02:14 UTC
INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Tag 'ovirt-engine-4.2.2.4' doesn't contain patch 'https://gerrit.ovirt.org/86006']
gitweb: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/ovirt-engine-4.2.2.4

For more info please contact: infra

Comment 13 Tomas Jelinek 2018-03-19 14:34:55 UTC
it has been like this for a long while, enough if it ends up in 4.3, retargeting.

Comment 14 samuel macko 2019-03-15 13:10:05 UTC
Verified on ovirt-engine-4.3.0.4-0.1.el7.noarch.
Verified by following the reproducer for languages en_US, ja_JP, de_DE.

Comment 15 Sandro Bonazzola 2019-03-19 10:08:44 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.