Spec URL: https://nathans.fedorapeople.org/rmtest/python-rmtest.spec SRPM URL: https://nathans.fedorapeople.org/rmtest/python-rmtest-0.6.6-1.fc27.src.rpm Description: Simple framework for testing Redis modules using python unit test, and a disposable ephemeral Redis sub-process. Fedora Account System Username: nathans
Couple of additional notes for reviewers: - there's a patch included in the spec which fixes up a trivial python3 issue. https://github.com/RedisLabs/rmtest/pull/5 - the LICENSE and README.md files are not in the source tarball (yet). I've pulled these in from the github repository as %source1 and %source2. https://github.com/RedisLabs/rmtest/issues/6 cheers.
Running fedora-review on the above... ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). [...] Diff spec file in url and in SRPM --------------------------------- --- /home/lberk/src/fedora-scm/review/1517993-python-rmtest/srpm/python-rmtest.spec 2017-11-29 15:40:08.286849396 -0500 +++ /home/lberk/src/fedora-scm/review/1517993-python-rmtest/srpm-unpacked/python-rmtest.spec 2017-11-26 23:48:18.000000000 -0500 @@ -18,6 +18,4 @@ BuildRequires: python2-devel python3-devel BuildRequires: python-redis python3-redis -BuildRequires: redis-devel -Requires: redis >= 4 %description
Whoops, thanks Lukas - I've updated the SRPM at the same location above to match that change to the spec. cheers.
- Everything is okay except this minor issue: python-rmtest.src:21: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 21) Remove the tab you've added line 21. Package is accepted.
| Remove the tab you've added line 21. Will, do - thanks!
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rmtest
python-rmtest-0.6.6-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4ba4b53084
python-rmtest-0.6.6-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8e24053bdc
python-rmtest-0.6.6-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3742361d6b
python-rmtest-0.6.6-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3742361d6b
python-rmtest-0.6.6-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4ba4b53084
python-rmtest-0.6.6-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8e24053bdc
python-rmtest-0.6.6-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
python-rmtest-0.6.6-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.