Red Hat Bugzilla – Bug 1518066
ovirt-engine-backend contains jar files that shouldn't be there
Last modified: 2018-05-15 13:47:49 EDT
Description of problem: $ rpm -qlvp ovirt-engine-backend-4.2.0-0.5.master.el7.noarch.rpm| grep jar | grep -v ^l -rw-r--r-- 1 root root 64075 nov 14 15:02 /usr/share/java/ovirt-engine/aaa.jar -rw-r--r-- 1 root root 4361961 nov 14 15:02 /usr/share/java/ovirt-engine/bll.jar -rw-r--r-- 1 root root 9569 nov 14 15:02 /usr/share/java/ovirt-engine/builtin.jar -rw-r--r-- 1 root root 1104823 nov 14 15:02 /usr/share/java/ovirt-engine/dal.jar -rw-r--r-- 1 root root 27454 nov 14 15:02 /usr/share/java/ovirt-engine/scheduler.jar -rw-r--r-- 1 root root 131235 nov 14 15:02 /usr/share/java/ovirt-engine/searchbackend.jar -rw-r--r-- 1 root root 942849 nov 14 15:02 /usr/share/java/ovirt-engine/vdsbroker.jar -rw-rw-r-- 1 root root 9024 nov 14 13:39 /usr/share/ovirt-engine/engine.ear/docs.war/WEB-INF/lib/docs.jar -rw-rw-r-- 1 root root 158534 nov 14 13:37 /usr/share/ovirt-engine/engine.ear/enginesso.war/WEB-INF/lib/enginesso.jar -rw-rw-r-- 1 root root 23308 nov 14 13:37 /usr/share/ovirt-engine/engine.ear/services.war/WEB-INF/lib/branding.jar -rw-rw-r-- 1 root root 23528 nov 14 13:39 /usr/share/ovirt-engine/engine.ear/services.war/WEB-INF/lib/services.jar -rw-rw-r-- 1 root root 18537 nov 14 13:39 /usr/share/ovirt-engine/engine.ear/welcome.war/WEB-INF/lib/welcome.jar -rw-rw-r-- 1 root root 77761 nov 14 13:36 /usr/share/ovirt-engine/modules/common/com/netflix/config/main/archaius-core.jar -rw-rw-r-- 1 root root 16442 nov 14 13:36 /usr/share/ovirt-engine/modules/common/com/netflix/hystrix/contrib/main/hystrix-metrics-event-stream.jar -rw-rw-r-- 1 root root 290223 nov 14 13:36 /usr/share/ovirt-engine/modules/common/com/netflix/hystrix/main/hystrix-core.jar -rw-rw-r-- 1 root root 257224 nov 14 13:36 /usr/share/ovirt-engine/modules/common/com/nimbusds/main/nimbus-jose-jwt.jar -rw-rw-r-- 1 root root 738300 nov 14 13:36 /usr/share/ovirt-engine/modules/common/io/reactivex/rxjava/main/rxjava.jar -rw-rw-r-- 1 root root 77882 nov 14 13:36 /usr/share/ovirt-engine/modules/common/net/minidev/main/json-smart.jar -rw-rw-r-- 1 root root 6571 nov 14 13:36 /usr/share/ovirt-engine/modules/common/org/ovirt/engine/api/metamodel-server/main/metamodel-server.jar -rw-rw-r-- 1 root root 7117 nov 14 13:37 /usr/share/ovirt-engine/modules/common/org/ovirt/engine/core/auth-plugin/main/auth-plugin.jar -rw-rw-r-- 1 root root 3995 nov 14 13:39 /usr/share/ovirt-engine/modules/common/org/ovirt/engine/core/logger/main/logger.jar Version-Release number of selected component (if applicable): 4.2.0-0.5.master.el7 How reproducible: 100% Actual results: 3rd party jars are bundled within ovirt-engine-backend Expected results: 3rd party packages should be in rhvm-dependencies and symlinked in ovirt-engine-backend
I addressed some of the jars in upstream spec file, still to be addressed at least in downstream packaging: -rw-rw-r-- 1 root root 257224 nov 14 13:36 /usr/share/ovirt-engine/modules/common/com/nimbusds/main/nimbus-jose-jwt.jar -rw-rw-r-- 1 root root 77882 nov 14 13:36 /usr/share/ovirt-engine/modules/common/net/minidev/main/json-smart.jar -rw-rw-r-- 1 root root 6571 nov 14 13:36 /usr/share/ovirt-engine/modules/common/org/ovirt/engine/api/metamodel-server/main/metamodel-server.jar -rw-rw-r-- 1 root root 7117 nov 14 13:37 /usr/share/ovirt-engine/modules/common/org/ovirt/engine/core/auth-plugin/main/auth-plugin.jar -rw-rw-r-- 1 root root 3995 nov 14 13:39 /usr/share/ovirt-engine/modules/common/org/ovirt/engine/core/logger/main/logger.jar
Would be interesting to understand how they got here in the first place.
nimbus-jose-jwt.jar has been added solving bug #1416491 in patch https://gerrit.ovirt.org/#/c/71200/
json-smart.jar has been added in the same patch as in comment #3
About those in common/org/ovirt/engine/core: they're not built from ovirt-engine code so they shouldn't be here. Any reason for having these built outside ovirt-engine code tree?
(In reply to Sandro Bonazzola from comment #3) > nimbus-jose-jwt.jar has been added solving bug #1416491 in patch > https://gerrit.ovirt.org/#/c/71200/ (In reply to Sandro Bonazzola from comment #4) > json-smart.jar has been added in the same patch as in comment #3 Yes, AFAIK they are not packaged anywhere, we have forgotten to add them rhvm-dependencies, I will post a patch today
(In reply to Sandro Bonazzola from comment #1) > I addressed some of the jars in upstream spec file, still to be addressed at > least in downstream packaging: > > -rw-rw-r-- 1 root root 3995 nov 14 13:39 > /usr/share/ovirt-engine/modules/common/org/ovirt/engine/core/logger/main/ > logger.jar Content of the jar is created from sources within ovirt-engine project, looking at git log this jar is needed for ovirt-engine-extension-logger-log4j and it hasn't been changed in 4.2, so that shouldn't been an issue for 4.2.0 Anyway Ravi, do you remember why is this class org.ovirt.engine.core.logger.LoggerHandler packaged in logger.jar and it's not part of other existing engine JARs?
(In reply to Sandro Bonazzola from comment #1) > I addressed some of the jars in upstream spec file, still to be addressed at > least in downstream packaging: > > /usr/share/ovirt-engine/modules/common/org/ovirt/engine/api/metamodel-server/ > main/metamodel-server.jar Juan, do we have a reason why metamodel-server.jar is not provided by standalone RPM and it's packaged within ovirt-engine?
(In reply to Sandro Bonazzola from comment #1) > I addressed some of the jars in upstream spec file, still to be addressed at > least in downstream packaging: > > -rw-rw-r-- 1 root root 7117 nov 14 13:37 > /usr/share/ovirt-engine/modules/common/org/ovirt/engine/core/auth-plugin/ > main/auth-plugin.jar auth-plugin was added by https://gerrit.ovirt.org/29693 but its content is being built from ovirt-engine sources. Am I right, Roy?
The reason for including the metamodel-server.jar in the engine RPM is that it doesn't have a RPM packaging itself. Changing that would mean more work and no benefit. My advice is to leave it as it is.
(In reply to Martin Perina from comment #9) > (In reply to Sandro Bonazzola from comment #1) > > I addressed some of the jars in upstream spec file, still to be addressed at > > least in downstream packaging: > > > > -rw-rw-r-- 1 root root 7117 nov 14 13:37 > > /usr/share/ovirt-engine/modules/common/org/ovirt/engine/core/auth-plugin/ > > main/auth-plugin.jar > > auth-plugin was added by https://gerrit.ovirt.org/29693 but its content is > being built from ovirt-engine sources. Am I right, Roy? Yes. Nothing to address here.
Based on above the JAR file which is not build from ovirt-engine source is the metamodel and we have control on that project, so we can have it as JAR inside ovirt-engine
VErified [root@10-37-137-34 ~]# rpm -qlv ovirt-engine-backend-4.2.0.2-0.1.el7.noarch | grep jar | grep -v ^l -rw-r--r-- 1 root root 64120 Dec 12 15:54 /usr/share/java/ovirt-engine/aaa.jar -rw-r--r-- 1 root root 4396494 Dec 12 15:54 /usr/share/java/ovirt-engine/bll.jar -rw-r--r-- 1 root root 9571 Dec 12 15:54 /usr/share/java/ovirt-engine/builtin.jar -rw-r--r-- 1 root root 1093301 Dec 12 15:54 /usr/share/java/ovirt-engine/dal.jar -rw-r--r-- 1 root root 27458 Dec 12 15:54 /usr/share/java/ovirt-engine/scheduler.jar -rw-r--r-- 1 root root 131447 Dec 12 15:54 /usr/share/java/ovirt-engine/searchbackend.jar -rw-r--r-- 1 root root 946096 Dec 12 15:54 /usr/share/java/ovirt-engine/vdsbroker.jar -rw-rw-r-- 1 root root 9024 Dec 12 14:23 /usr/share/ovirt-engine/engine.ear/docs.war/WEB-INF/lib/docs.jar -rw-rw-r-- 1 root root 158760 Dec 12 14:21 /usr/share/ovirt-engine/engine.ear/enginesso.war/WEB-INF/lib/enginesso.jar -rw-rw-r-- 1 root root 23311 Dec 12 14:21 /usr/share/ovirt-engine/engine.ear/services.war/WEB-INF/lib/branding.jar -rw-rw-r-- 1 root root 23528 Dec 12 14:23 /usr/share/ovirt-engine/engine.ear/services.war/WEB-INF/lib/services.jar -rw-rw-r-- 1 root root 18604 Dec 12 14:23 /usr/share/ovirt-engine/engine.ear/welcome.war/WEB-INF/lib/welcome.jar -rw-rw-r-- 1 root root 6574 Dec 12 14:20 /usr/share/ovirt-engine/modules/common/org/ovirt/engine/api/metamodel-server/main/metamodel-server.jar -rw-rw-r-- 1 root root 7120 Dec 12 14:22 /usr/share/ovirt-engine/modules/common/org/ovirt/engine/core/auth-plugin/main/auth-plugin.jar -rw-rw-r-- 1 root root 3999 Dec 12 14:23 /usr/share/ovirt-engine/modules/common/org/ovirt/engine/core/logger/main/logger.jar Packages solo packaged: https://bugzilla.redhat.com/show_bug.cgi?id=1482469 https://bugzilla.redhat.com/show_bug.cgi?id=1482434 https://bugzilla.redhat.com/show_bug.cgi?id=1483623
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2018:1488