Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1518091

Summary: [NMCI] lease not renewed for external DHCP connection
Product: Red Hat Enterprise Linux 7 Reporter: Beniamino Galvani <bgalvani>
Component: NetworkManagerAssignee: Beniamino Galvani <bgalvani>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.5CC: atragler, bgalvani, fgiudici, lmiksik, lrintel, rkhan, sukulkar, thaller, vbenes
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: NetworkManager-1.10.2-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 13:34:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
[NM PATCH] device: add "indicated" argument to nm_utils_match_connection()
none
[CI PATCH] ipv4: disable renewal_gw_after_dhcp_outage_for_assumed_var1 on 1.10 none

Description Beniamino Galvani 2017-11-28 08:18:45 UTC 
Failure of CI test renewal_gw_after_dhcp_outage_for_assumed_var1 with NM 1.10:

 * Prepare simulated test " testX " device
 * Add connection type " ethernet " named " ethie " for device " testX "
 * Bring " up " connection " ethie "
 When " default " is visible with command " ip r |grep testX " in " 30 " seconds
 When " inet 192 " is visible with command " ip a s |grep testX " in " 30 " seconds
 * Execute " ip netns exec testX_ns kill -SIGSTOP $(cat /tmp/testX_ns.pid) "
 * Execute " systemctl stop NetworkManager "
 * Execute " sudo rm -rf /etc/sysconfig/network-scripts/ifcfg-ethie "
 * Execute " systemctl start NetworkManager "
 When " default " is not visible with command " ip r |grep testX " in " 130 " seconds
 When " inet 192.168.99 " is not visible with command " ip a s testX " in " 10 " seconds
 * Execute " ip netns exec testX_ns kill -SIGCONT $(cat /tmp/testX_ns.pid) "
 Then " routers = 192.168.99.1 " is visible with command " nmcli con show testX " in " 400 " seconds
 Then " default " is visible with command " ip r| grep testX " in " 150 " seconds
   Exception: Did not see the pattern default in 150 seconds
Comment 2 Beniamino Galvani 2017-11-28 15:38:23 UTC 
I would fix this by:

 - improving the behavior on NM restart so that connections don't become
   external (with the patch by Thomas attached below).
 
 and

 - disable the test because, after the previous point, there is no reason
   to keep renewing leases for external connections
Comment 3 Beniamino Galvani 2017-11-28 15:39:12 UTC 
Created attachment 1359938 [details]
[NM PATCH] device: add "indicated" argument to nm_utils_match_connection()
Comment 4 Beniamino Galvani 2017-11-28 15:40:30 UTC 
Created attachment 1359939 [details]
[CI PATCH] ipv4: disable renewal_gw_after_dhcp_outage_for_assumed_var1  on 1.10
Comment 5 Thomas Haller 2017-11-28 15:54:17 UTC 
(In reply to Beniamino Galvani from comment #3)
> Created attachment 1359938 [details]
> [NM PATCH] device: add "indicated" argument to nm_utils_match_connection()

several spelling errors :)



rest lgtm
Comment 6 Beniamino Galvani 2017-11-30 13:55:47 UTC 
(In reply to Thomas Haller from comment #5)
> (In reply to Beniamino Galvani from comment #3)
> > Created attachment 1359938 [details]
> > [NM PATCH] device: add "indicated" argument to nm_utils_match_connection()
> 
> several spelling errors :)
> 
> rest lgtm

Fixed. Patch applied to master:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=cc74cffe12bab58e489b2ad734c93b137da101d0

and nm-1-10.

NM-CI pull request:

https://github.com/NetworkManager/NetworkManager-ci/pull/63
Comment 7 Beniamino Galvani 2017-11-30 17:59:54 UTC 
Note that 1.10.0 still does DHCP for external auto connections (and thus the test passes there), but 1.10.2 will not as touching external connections is wrong and interferes with user settings (for example see https://bugzilla.redhat.com/show_bug.cgi?id=1512316 )
Comment 11 Vladimir Benes 2018-01-15 09:49:00 UTC 
Test is now checking that NM doesn't touch device so that means default route goes away in 120 seconds for example.
Comment 14 errata-xmlrpc 2018-04-10 13:34:16 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0778