Description of problem: If removing the RBAC for notifications, the user can still see notifications popping up. Version-Release number of selected component (if applicable): 5.9.0.11 How reproducible: always Steps to Reproduce: 1. create a new role 2. disable Service UI, Core, Notifications 3. Actual results: user can still see notifications popping up in the Ops UI (I tested this by provisioning a VM) Expected results: notifications should not show up
Does the following sentence correctly capture the ask of this bz? "As a user in the sui, when rbac for notifications is not enabled, I do not want to be shown any notifications" Also, wondering if this should be a new product feature of the sui? (I'm secretly worried you want us to filter notifications by type) Also this feels like a REF :thinking:
Apologies, I'm confused by this ticket. In the Service UI currently, when notifications are turned off, they are disabled. Christian - Is this not the case? That is, are you still seeing notifications in the Service UI when the role is disabled? Would you mind clarifying what is not working in the Service UI?
Chris, yes, the role is disabled but I was still seeing notifications in the Self Service UI.
We need discussion, but here it is: https://github.com/ManageIQ/manageiq-ui-service/pull/1293/files The second part of this work might be revisiting miq_user_roles.yml and adding more product features
Allen, you set needinfo flag but didn't assign it to anyone which means it basically gets ignored. Needinfo is much more usefull when pointed at someone. What are the questions/info that you need? Sounds like we need to have a call with PM(s) to discuss what the requirement is.
(In reply to Allen W from comment #7) > We need discussion, but here it is: > https://github.com/ManageIQ/manageiq-ui-service/pull/1293/files > > The second part of this work might be revisiting miq_user_roles.yml and > adding more product features Allen, What do you want to revisit here?
Right! Thanks for that Dave. Loic, we should do a 👖 to talk this out but the gist is this: 1. The pr referenced earlier ensures notification showing is function of RBAC, ie role product features. This means, unless the role has the product feature, no notifications will be show. 2. Unless it is desired no existing roles see notifications, we will have to add the `sui_notifications` product feature to miq_user_roles.yml So essentially looking to get sign off on that approach. Implementing the pr, then adding the product feature to all existing roles that access SUI OR ALTERNATIVELY input on which roles should see notifications
https://github.com/ManageIQ/manageiq/pull/16817 Once that one is merged we can merge https://github.com/ManageIQ/manageiq-ui-service/pull/1293 THEN this can be closed! (cuz it'll be fixed)
Looooooooks like both prs made in in, we can now post this!
VERIFIED in 5.10.0.8. When disabled, there were no notifications in the SSUI after an ordering a service. Toggling the notifications on/off, had the desired affect.