Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1518325

Summary: oc set volumes not working for DaemonSets
Product: OpenShift Container Platform Reporter: Rich Megginson <rmeggins>
Component: ocAssignee: Maciej Szulik <maszulik>
Status: CLOSED ERRATA QA Contact: Xingxing Xia <xxia>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 3.8.0CC: aos-bugs, haowang, jokerman, mifiedle, mmccomas
Target Milestone: ---   
Target Release: 3.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Incorrect codec was used when patching resource. Consequence: Users were not able to set volume on a daemon set. Fix: Use proper codec when patching resources. Result: oc set volumes is working properly with daemon sets.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-13 22:27:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
oc set volumes with loglevel=8 none

Description Rich Megginson 2017-11-28 16:03:11 UTC 
Created attachment 1359958 [details]
oc set volumes with loglevel=8

Description of problem:

    oc set volumes daemonset/logging-forward-fluentd --remove \
       --name=filebufferstorage

gives

    error: daemonsets/logging-forward-fluentd no kind "DaemonSet" is registered for version "apps/v1beta1"


Version-Release number of selected component (if applicable):

$ oc version
oc v3.8.0-alpha.0+fe4f498-286
kubernetes v1.8.1+0d5291c
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://ip-172-18-11-161.ec2.internal:8443
openshift v3.8.0-alpha.0+fe4f498-286
kubernetes v1.8.1+0d5291c


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Juan Vallejo 2017-11-28 18:22:43 UTC 
PR: https://github.com/openshift/origin/pull/17497
Comment 2 Xingxing Xia 2017-12-01 09:54:36 UTC 
Tested in oc/OCP v3.8.0-alpha.0+af153e2-352 , `oc set volumes daemonset/...` works well in add/remove, regression test on other resource kinds (dc/deploy/rs) works well too
# oc set volume ds/hello-daemonset --add --name=v1 -m /data -n xxia-proj --config /root/xxia-test/admin.config
# oc set volume ds/hello-daemonset  
daemonsets/hello-daemonset
  empty directory as v1
    mounted at /data
# oc set volume daemonset/hello-daemonset --remove --name=v1 -n xxia-proj --config /root/xxia-test/admin.config
daemonset "hello-daemonset" updated

Currently PR doesn't go to OCP 3.8 (and OCP 3.8 env cannot be launched because it still misses some infra image in testing registry). Moving to MODIFIED
Comment 3 Xingxing Xia 2017-12-06 08:44:39 UTC 
Verified in OCP v3.8.1, same result as above comment
Comment 6 errata-xmlrpc 2019-03-13 22:27:23 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0403