Bug 1518795 - [F28 change] uwsgi should not require tcp_wrappers [NEEDINFO]
Summary: [F28 change] uwsgi should not require tcp_wrappers
Alias: None
Product: Fedora
Classification: Fedora
Component: uwsgi
Version: 28
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Jorge Gallegos
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1495181 1596070
TreeView+ depends on / blocked
Reported: 2017-11-29 15:01 UTC by Jakub Jelen
Modified: 2018-06-28 08:10 UTC (History)
2 users (show)

Fixed In Version: uwsgi-2.0.16-1.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2018-04-04 15:52:41 UTC
Type: Bug
jjelen: needinfo? (kad)

Attachments (Terms of Use)

Description Jakub Jelen 2017-11-29 15:01:33 UTC
As announced earlier this year, we plan to deprecate TCP wrappers out of Fedora services in a single release (Fedora 28) to avoid user confusion that some of the tools will be using it and some not.

For more information about the change or possible migration paths outside of the package itself, see the linked accepted Fedora 28 change.

This report is for a source package, that has "BuildRequires tcp_wrappers" in spec file and resulting packages depend on "libwrap.so.0". The changes to remove the dependency should be minimal, usually a configure switch, but let me know if you will need some assistance with the changes.

Additional info:


Comment 1 Jorge Gallegos 2017-11-30 00:00:13 UTC
in this case, it is a dependency on the tcp_wrapper headers from https://github.com/unbit/uwsgi/blob/master/plugins/router_access/router_access.c#L47 I will ping upstream about a workaround.

Comment 2 Jorge Gallegos 2017-11-30 00:08:19 UTC
Submitted https://github.com/unbit/uwsgi/issues/1689

Comment 3 Fedora End Of Life 2018-02-20 15:33:30 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 4 Jakub Jelen 2018-03-19 11:51:06 UTC
Thank you. But it seems that your package was not successfully built in F28 since the change. Can you check what was the reason and resubmit the builds? Thank you.

Comment 5 Jakub Jelen 2018-03-29 16:31:37 UTC
The one issue is fixed by this one:

It is already discussed upstream:

But the patch is still not there.

The other issue is fixed by my PR:

Then there is an issue with missing glfs.h in rawhide:


Then the spec file needs not to generate the subpackage for the removed module.

I filled the followint PR, which makes it building in Fedora 28, but because of the glfs, not in rawhide (at least not in mock):


Comment 6 Fedora Update System 2018-03-29 20:45:18 UTC
uwsgi-2.0.16-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-81823acb6d

Comment 7 Fedora Update System 2018-03-30 15:18:19 UTC
uwsgi-2.0.16-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-81823acb6d

Comment 8 Fedora Update System 2018-04-04 15:52:41 UTC
uwsgi-2.0.16-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.