Description of problem: Package libkolab fails to build from source in Fedora rawhide with following error: In file included from /builddir/build/BUILD/libkolab-1.0.2/kolabformat/mimeobject.cpp:20:0: /builddir/build/BUILD/libkolab-1.0.2/./conversion/kcalconversion.h:46:22: error: 'KDateTime' does not name a type; did you mean 'cDateTime'? KOLAB_EXPORT KDateTime toDate(const Kolab::cDateTime &dt); ^~~~~~~~~ cDateTime /builddir/build/BUILD/libkolab-1.0.2/./conversion/kcalconversion.h:47:47: error: 'KDateTime' does not name a type; did you mean 'cDateTime'? KOLAB_EXPORT cDateTime fromDate(const KDateTime &dt); ^~~~~~~~~ cDateTime Steps to Reproduce: koji build --scratch f28 libkolab-1.0.2-9.fc27.src.rpm Additional info: This package is tracked by Koschei. See: http://apps.fedoraproject.org/koschei/package/libkolab A difference between working and failing build root is listed on https://apps.fedoraproject.org/koschei/build/3784561
FYI, As of kdepim-runtime-17.12 release (which bundles a patched libkolab), nothing in fedora uses libkolab anymore as far as I can tell
I would like to keep libkolab in Fedora, just in case we package the Kolab server one day in Fedora.
Created attachment 1395253 [details] fails to build now even earlier Today, a scratch build on Rawhide failed even earlier: CMake Error at cmake/modules/FindSWIG.cmake:4 (find_package_handle_standard_args): Unknown CMake command "find_package_handle_standard_args".
https://src.fedoraproject.org/rpms/libkolab/c/35b5a5f8ade29c48bd032d4753a8325cf8cf1456?branch=master should fix that issue at least.
Thanks @Rex Dieter! now we get this error: [ 2%] Building CXX object CMakeFiles/kolab.dir/kolabformat/kolabobject.cpp.o /usr/bin/c++ -DKCOREADDONS_LIB -DKDEPIMLIBS_VERSION_MAJOR="" -DKDEPIMLIBS_VERSION_MINOR="" -DKDEPIMLIBS_VERSION_PATCH="" -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_XML_LIB -Dkolab_EXPORTS -I/builddir/build/BUILD/libkolab-1.0.2/build -I/builddir/build/BUILD/libkolab-1.0.2/kolabformatV2 -I/usr/lib64/cmake/Libkolabxml/../../../include/kolabxml -I/builddir/build/BUILD/libkolab-1.0.2/. -I/usr/include/python2.7 -isystem /usr/include/KF5/KCalCore -isystem /usr/include/KF5 -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/./mkspecs/linux-g++ -isystem /usr/include/KF5/KCalUtils -isystem /usr/include/KF5/KCalUtils/kcalutils -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/KF5/KCoreAddons -isystem /usr/include/KF5/KConfigGui -isystem /usr/include/qt5/QtXml -isystem /usr/include/KF5/KConfigCore -isystem /usr/include/KF5/KContacts -isystem /usr/include/KF5/KMime -isystem /usr/include/KF5/AkonadiCore -isystem /usr/include/KF5/KItemModels -isystem /usr/include/KF5/Akonadi/Notes -isystem /usr/include/KF5/akonadi/notes -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection -Wnon-virtual-dtor -Wno-long-long -ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-security -fno-exceptions -DQT_NO_EXCEPTIONS -fno-common -Woverloaded-virtual -fno-threadsafe-statics -fvisibility=hidden -Werror=return-type -fvisibility-inlines-hidden -fexceptions -UQT_NO_EXCEPTIONS -fPIC -g -std=c++11 -fPIC -fPIC -fexceptions -std=gnu++11 -o CMakeFiles/kolab.dir/kolabformat/kolabobject.cpp.o -c /builddir/build/BUILD/libkolab-1.0.2/kolabformat/kolabobject.cpp In file included from /builddir/build/BUILD/libkolab-1.0.2/kolabformat/v2helpers.h:23, from /builddir/build/BUILD/libkolab-1.0.2/kolabformat/kolabobject.cpp:20: /builddir/build/BUILD/libkolab-1.0.2/./kolabformatV2/kolabbase.h:40:10: fatal error: kdatetime.h: No such file or directory #include <kdatetime.h> ^~~~~~~~~~~~~ compilation terminated. make[2]: *** [CMakeFiles/kolab.dir/build.make:70: CMakeFiles/kolab.dir/kolabformat/kolabobject.cpp.o] Error 1 make[2]: Leaving directory '/builddir/build/BUILD/libkolab-1.0.2/build' In Kolab upstream, we are using an untagged (!!) version of libkolab 2.0. But I checked the file https://git.kolab.org/diffusion/LK/browse/master/kolabformatV2/kolabbase.h, it still references kdatetime.h
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle. Changing version to '28'.
*** Bug 1556048 has been marked as a duplicate of this bug. ***
I'll echo a comment from the dup'd bug, libkolab is (still) using a deprecated kdatetime api which was recently removed from kf5-kcalendarcore
Also from that bug, Rex said: "My recommendation is to retire this, at least until it's fixed and/or anything else really needs it." which I agree with. But note, please find a package that can Obsoletes: it, so that upgrades from F27 and earlier work without --allowerasing.
libkolabxml (something libkolab depends on) is one good candidate Otherwise, catch-all fedora-obsolete-packages is another
libkolabxml sounds good to me. it's best to use a 'real' package if one makes sense, the catch-all is more of a fallback.
OK, i'll take care of implementing the Obsoletes
Created attachment 1444892 [details] build.log
Created attachment 1444893 [details] root.log
Created attachment 1444894 [details] state.log
Re comment #12 Obsoletes: implemented awhile back, https://src.fedoraproject.org/rpms/libkolabxml/c/286610e929238bd5ef0f659de2915db05434c848
Dear Maintainer, your package has not been built successfully in F28. Action is required from you. If you can fix your package to build, perform a build in koji, and either create an update in bodhi, or close this bug without creating an update, if updating is not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to acknowledge this. Following the latest policy for such packages [2], your package will be orphaned if this bug remains in NEW state more than 8 weeks. [1] https://fedoraproject.org/wiki/Updates_Policy [2] https://fedoraproject.org/wiki/Fails_to_build_from_source#Package_Removal_for_Long-standing_FTBFS_bugs
I guess we all agree that this package cannot be revived? Should I just let it be orphaned, or should I actively orphan it? I will try the latter.
It would be best to *explicitly retire* it, not to orphan it. See https://fedoraproject.org/wiki/How_to_remove_a_package_at_end_of_life .
*** Bug 1604607 has been marked as a duplicate of this bug. ***
I have now retired the package libkolab, it is obsoleted by libkolabxml. I hope it worked. https://src.fedoraproject.org/rpms/libkolab/commits/master