Bug 1519719 - Review Request: php-phpunit-mock-objects5 - Mock Object library for PHPUnit
Summary: Review Request: php-phpunit-mock-objects5 - Mock Object library for PHPUnit
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1539554
TreeView+ depends on / blocked
Reported: 2017-12-01 09:56 UTC by Remi Collet
Modified: 2018-02-20 17:13 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2018-02-20 17:13:09 UTC
Type: ---
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Remi Collet 2017-12-01 09:56:54 UTC
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpunit/php-phpunit-mock-objects5.git/plain/php-phpunit-mock-objects5.spec?id=6c362a772380e7437688fe0a830ad195bd5c75de
SRPM URL: http://rpms.remirepo.net/SRPMS/php-phpunit-mock-objects5-5.0.0-0.remi.src.rpm
Mock Object library for PHPUnit

Fedora Account System Username: remi


New dependency on PHPUnit 6.5

WARNING: because of bug #1505030 fedora-review is unable to download to right spec file.

Latest changes (in my git) are mostly switch from boostrap to normal build (because of circular dependency on PHPUnit 6.5)

After import, php-phpunit-mock-objects4 will be removed from the repository.

Comment 1 Remi Collet 2017-12-01 10:00:32 UTC
If interested in PHPUnit 6.5 (for testing of this new version)
available in my repostiory

See: https://git.remirepo.net/cgit/rpms/php/phpunit/phpunit6.git/commit/?id=4aab3627f084f847c939abd37e02c18adc042666

Comment 5 Robert-André Mauchin 🐧 2018-02-05 13:27:14 UTC
 - Not needed in Fedora:


%{!?_licensedir:%global license %%doc}

Package approved.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (2 clause)", "Unknown or generated", "*No copyright* BSD
     (3 clause)". 143 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/php-phpunit-mock-objects5
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     phpunit6), /usr/share/php/PHPUnit6(php-phpunit-mock-objects4,
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

[x]: Run phpci static analyze on all php files.
     Note: phpCompatInfo version 5.0.11 DB version 1.28.0 built Jan 09 2018
     08:43:55 CET static analyze results in /home/bob/packaging/review/php-

Checking: php-phpunit-mock-objects5-5.0.6-2.fc28.noarch.rpm
php-phpunit-mock-objects5.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
php-phpunit-mock-objects5.noarch: W: obsolete-not-provided php-phpunit-mock-objects4
php-phpunit-mock-objects5.src: W: spelling-error %description -l en_US usr -> use, us, user
php-phpunit-mock-objects5.src: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Comment 6 Robert-André Mauchin 🐧 2018-02-05 13:29:02 UTC
Sh*t I forgot to check latest release, version 6.0.0 has been published 4 days ago, please bump your package.

Comment 7 Remi Collet 2018-02-06 05:02:55 UTC
(In reply to Robert-André Mauchin from comment #6)
> Sh*t I forgot to check latest release, version 6.0.0 has been published 4
> days ago, please bump your package.

This package is v5 (v6 is review #1541340)

v5 is required bu PHPUnit 6.5 (phpunit6 package is for now stalled at 6.4 because of this dependency)
v6 is required by PHPunit 7.0

Comment 9 Gwyn Ciesla 2018-02-06 14:54:58 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-phpunit-mock-objects5

Comment 10 Fedora Update System 2018-02-07 06:40:58 UTC
php-phpunit-mock-objects5-5.0.6-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5bba96e2fb

Comment 11 Fedora Update System 2018-02-07 14:10:04 UTC
php-phpunit-mock-objects5-5.0.6-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5bba96e2fb

Comment 12 Fedora Update System 2018-02-20 17:13:09 UTC
php-phpunit-mock-objects5-5.0.6-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.