Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1519759

Summary: Fix memory leaks
Product: Red Hat Enterprise Linux 7 Reporter: Peter Krempa <pkrempa>
Component: libvirtAssignee: Peter Krempa <pkrempa>
Status: CLOSED ERRATA QA Contact: Luyao Huang <lhuang>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.4CC: dyuan, jtomko, lmen, mtessun, pkrempa, rbalakri, xuzhang
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-3.9.0-5.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 11:00:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Peter Krempa 2017-12-01 12:08:31 UTC 
Description of problem:

There are a few memleaks in various parts of libvirt:

    ==861== 3 bytes in 1 blocks are definitely lost in loss record 3 of 168
    ==861==    at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
    ==861==    by 0x8C7FBC8: xmlStrndup (in /usr/lib64/libxml2.so.2.9.4)
    ==861==    by 0x5DCCDC2: virXMLPropString (virxml.c:510)
    ==861==    by 0x5DF1232: virDomainDiskSourceNetworkParse (domain_conf.c:8445)
    ==861==    by 0x5DF1728: virDomainDiskSourceParse (domain_conf.c:8576)
    ==861==    by 0x5DF41A5: virDomainDiskDefParseXML (domain_conf.c:9238)


    ==1277== 8 bytes in 4 blocks are definitely lost in loss record 39 of 131
    ==1277==    at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
    ==1277==    by 0x68BBBC8: xmlStrndup (in /usr/lib64/libxml2.so.2.9.4)
    ==1277==    by 0x53B1DC2: virXMLPropString (virxml.c:510)
    ==1277==    by 0x53D696A: virDomainDiskBackingStoreParse (domain_conf.c:8639)
    ==1277==    by 0x53DA684: virDomainDiskDefParseXML (domain_conf.c:9590)
    ==1277==    by 0x53F619F: virDomainDefParseXML (domain_conf.c:19233)\



    ==899== 39 bytes in 1 blocks are definitely lost in loss record 732 of 1,003
    ==899==    at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
    ==899==    by 0x8B68CE7: vasprintf (in /lib64/libc-2.25.so)
    ==899==    by 0x55498D2: virVasprintfInternal (virstring.c:708)
    ==899==    by 0x55499E7: virAsprintfInternal (virstring.c:729)
    ==899==    by 0x2BECFFF0: qemuGetMemoryBackingBasePath (qemu_conf.c:1757)
    ==899==    by 0x2BF23225: qemuStateInitialize (qemu_driver.c:893)

And possibly a few others
Comment 1 Ján Tomko 2017-12-01 12:13:38 UTC 
Could you post the steps to reproduce the leaks and the libvirt version where they happened?
Comment 2 Peter Krempa 2017-12-01 12:14:33 UTC 
no.
Comment 4 Luyao Huang 2017-12-04 07:56:39 UTC 
Test on libvirt-3.9.0-4.el7.x86_64:

1.
This is mem leak in qemuStateInitialize:

==30865== 39 bytes in 1 blocks are definitely lost in loss record 881 of 2,037
==30865==    at 0x4C29BC3: malloc (vg_replace_malloc.c:299)
==30865==    by 0x861FE6F: __vasprintf_chk (in /usr/lib64/libc-2.17.so)
==30865==    by 0x552D7B5: UnknownInlinedFun (stdio2.h:210)
==30865==    by 0x552D7B5: virVasprintfInternal (virstring.c:708)
==30865==    by 0x552D8AA: virAsprintfInternal (virstring.c:729)
==30865==    by 0x23621DE2: qemuGetMemoryBackingBasePath (qemu_conf.c:1774)
==30865==    by 0x236683BC: qemuStateInitialize (qemu_driver.c:893)
==30865==    by 0x55D460E: virStateInitialize (libvirt.c:770)
==30865==    by 0x124E7A: daemonRunStateInit (libvirtd.c:834)
==30865==    by 0x5534321: virThreadHelper (virthread.c:206)
==30865==    by 0x82F3DD4: start_thread (in /usr/lib64/libpthread-2.17.so)
==30865==    by 0x860694C: clone (in /usr/lib64/libc-2.17.so)

Reproduce step:

 valgrind --leak-check=full /usr/sbin/libvirtd

2.
This is mem leak when parse tls element for vxhs network protocol:

==30802== 4 bytes in 1 blocks are definitely lost in loss record 12 of 679
==30802==    at 0x4C29BC3: malloc (vg_replace_malloc.c:299)
==30802==    by 0x6BD4B78: xmlStrndup (in /usr/lib64/libxml2.so.2.9.1)
==30802==    by 0x5562BFA: virDomainDiskSourceNetworkParse (domain_conf.c:8435)
==30802==    by 0x5562BFA: virDomainDiskSourceParse (domain_conf.c:8565)
==30802==    by 0x5563A64: virDomainDiskDefParseXML (domain_conf.c:9227)
==30802==    by 0x55847C4: virDomainDefParseXML (domain_conf.c:19217)
==30802==    by 0x5586E89: virDomainDefParseNode (domain_conf.c:20067)
==30802==    by 0x5586FB1: virDomainDefParse (domain_conf.c:20011)
==30802==    by 0x2367ABBE: qemuDomainDefineXMLFlags (qemu_driver.c:7392)
==30802==    by 0x55E876D: virDomainDefineXML (libvirt-domain.c:6160)
==30802==    by 0x14F7CA: remoteDispatchDomainDefineXML (remote_dispatch.h:4446)
==30802==    by 0x14F7CA: remoteDispatchDomainDefineXMLHelper (remote_dispatch.h:4424)
==30802==    by 0x5659AB1: virNetServerProgramDispatchCall (virnetserverprogram.c:437)
==30802==    by 0x5659AB1: virNetServerProgramDispatch (virnetserverprogram.c:307)
==30802==    by 0x160C7C: virNetServerProcessMsg (virnetserver.c:148)
==30802==    by 0x160C7C: virNetServerHandleJob (virnetserver.c:169)

Reproduce step:

define a guest with vxhs protocol disk:

    <disk type='network' device='disk'>
      <driver name='qemu' type='raw' cache='none'/>
      <source protocol='vxhs' name='eb90327c-8302-4725-9e1b-4e85ed4dc251' tls='yes'>
        <host name='192.168.0.1' port='9999'/>
      </source>
      <target dev='vda' bus='virtio'/>
      <serial>eb90327c-8302-4725-9e1b-4e85ed4dc251</serial>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
    </disk>

3. 

This is mem leak when parse backingStore index element:

==31317== 2 bytes in 1 blocks are definitely lost in loss record 47 of 2,233
==31317==    at 0x4C29BC3: malloc (vg_replace_malloc.c:299)
==31317==    by 0x6BD4B78: xmlStrndup (in /usr/lib64/libxml2.so.2.9.1)
==31317==    by 0x5562F07: virDomainDiskBackingStoreParse.isra.66 (domain_conf.c:8628)
==31317==    by 0x55645BA: virDomainDiskDefParseXML (domain_conf.c:9579)
==31317==    by 0x55847C4: virDomainDefParseXML (domain_conf.c:19217)
==31317==    by 0x5587254: virDomainObjParseXML (domain_conf.c:19930)
==31317==    by 0x5587254: virDomainObjParseNode (domain_conf.c:20099)
==31317==    by 0x55876B4: virDomainObjParseFile (domain_conf.c:20118)
==31317==    by 0x5590B93: virDomainObjListLoadStatus (virdomainobjlist.c:515)
==31317==    by 0x5590B93: virDomainObjListLoadAllConfigs (virdomainobjlist.c:590)
==31317==    by 0x23668446: qemuStateInitialize (qemu_driver.c:912)
==31317==    by 0x55D460E: virStateInitialize (libvirt.c:770)
==31317==    by 0x124E7A: daemonRunStateInit (libvirtd.c:834)
==31317==    by 0x5534321: virThreadHelper (virthread.c:206)

Reproduce step:

prepare a guest which have external snapshot and use valgrind start libvirtd:

    <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2' cache='none'/>
      <source file='/var/lib/libvirt/images/RHEL-7.5-x86_64-latest.test2'/>
      <backingStore type='file' index='1'>
        <format type='qcow2'/>
        <source file='/var/lib/libvirt/images/RHEL-7.5-x86_64-latest.qcow2'/>
        <backingStore/>
      </backingStore>
      <target dev='vda' bus='virtio'/>
      <alias name='virtio-disk0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
    </disk>

# service libvirtd stop

# valgrind --leak-check=full /usr/sbin/libvirtd
Comment 6 Luyao Huang 2017-12-06 09:20:50 UTC 
Retest with the same steps in comment 4 on libvirt-3.9.0-5.el7.x86_64, didn't find any memory leak. Verify this bug.
Comment 10 errata-xmlrpc 2018-04-10 11:00:58 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0704