Bug 1520003 - minimal .spec file change to assist lessening load
Summary: minimal .spec file change to assist lessening load
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rpmgrill
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Roman Joost
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-01 21:55 UTC by R P Herrold
Modified: 2018-02-14 17:27 UTC (History)
4 users (show)

Fixed In Version: rpmgrill-0.32-2.fc27
Clone Of:
Environment:
Last Closed: 2018-02-14 17:27:54 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description R P Herrold 2017-12-01 21:55:57 UTC
Description of problem:

The incumbent .spec file has a hard require for clamav-data

clamav-data is fat, and usually not wanted on a buildfarm box; it also goes stale often.  

to address this, clamav created a sub-package called

   clamav-data-empty

which provides 

   data(clamav)


Version-Release number of selected component (if applicable):

all to date

======

Requested action:

Please amend the .spec file as follows, which will permit 
EITHER clamav-data 
OR clamav-data-empty 
to satisfy the Require


[herrold@centos-7 rpmgrill]$ diff -u rpmgrill.spec-0.31-1.fc28 rpmgrill.spec
--- rpmgrill.spec-0.31-1.fc28   2017-12-01 16:47:17.257860144 -0500
+++ rpmgrill.spec       2017-12-01 16:47:46.587519344 -0500
@@ -15,7 +15,7 @@
 
 # For the antivirus plugin
 Requires: clamav
-Requires: clamav-data
+Requires: data(clamav)
 
 # For checking desktop/icon files using /usr/bin/desktop-file-validate
 Requires: /usr/bin/desktop-file-validate
[herrold@centos-7 rpmgrill]$

Comment 1 R P Herrold 2017-12-01 21:59:10 UTC
This bug may permit avoiding the need to often update mentioned and requested in bug #1477130

Comment 2 R P Herrold 2017-12-01 22:02:12 UTC
I see comment 1 in 
   https://bugzilla.redhat.com/show_bug.cgi?id=1436291#c1

which says in relevant part:

>  at this point rpmgrill is officially in maintenance mode. Unless someone fixes it in their spare time it'll be something to fix on a "rainy day" unofficially

Please apply this so others may continue to work with rpmgrill while it remains in maintenance mode

Comment 3 Ed Santiago 2017-12-11 13:46:39 UTC
Roman, any chance  you could look into this? (I no longer have access to the rpmgrill repo)

Comment 4 Roman Joost 2018-01-15 23:47:58 UTC
Sorry for replying so late, but yes. I'll see if I can make the change ASAP in the next days.

Comment 5 Roman Joost 2018-01-16 00:47:42 UTC
I'm a bit worried that I'll end up with bug reports not having installed the preferred clamav-data package.

Maybe better to change the spec file to:

Requires: data(clamav)
Suggests: clamav-data

So that dnf picks clamav-data by default, but still allows you to pick clamav-data-empty?

Comment 6 R P Herrold 2018-01-29 21:22:19 UTC
Comment #5 works4me -- please commit this change

Comment 7 Fedora Update System 2018-02-01 00:45:14 UTC
rpmgrill-0.32-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-7ca2c0cdc5

Comment 8 Fedora Update System 2018-02-01 02:17:25 UTC
rpmgrill-0.32-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-477684233b

Comment 9 Fedora Update System 2018-02-01 19:09:37 UTC
rpmgrill-0.32-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-477684233b

Comment 10 Fedora Update System 2018-02-01 19:30:56 UTC
rpmgrill-0.32-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-7ca2c0cdc5

Comment 11 Fedora Update System 2018-02-14 17:09:42 UTC
rpmgrill-0.32-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2018-02-14 17:27:54 UTC
rpmgrill-0.32-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.