Bug 1520138 - Test for Fedora distribution missing, fails to start with nvidia driver installed
Summary: Test for Fedora distribution missing, fails to start with nvidia driver insta...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cura
Version: 27
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-03 12:23 UTC by Andrew Donaldson
Modified: 2017-12-19 19:45 UTC (History)
2 users (show)

Fixed In Version: cura-3.0.3-5.fc27
Clone Of:
Environment:
Last Closed: 2017-12-19 19:45:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Output of diff -p with fix applied (1.34 KB, patch)
2017-12-03 12:23 UTC, Andrew Donaldson
no flags Details | Diff

Description Andrew Donaldson 2017-12-03 12:23:47 UTC
Created attachment 1362239 [details]
Output of diff -p with fix applied

Description of problem: Cura fails to start if nvidia driver is installed. A fix is present in the code but doesn't detect Fedora properly.


Version-Release number of selected component (if applicable):
3.0.3-2.fc27.noarch and
3.0.3-3.fc27.noarch


How reproducible: Always


Steps to Reproduce:
1. Install nvidia drivers from rpmfusion
2. start cura

Actual results:
No content in main window


Expected results:
buttons, pictures etc should be shown


Additional info:
If started from the command line, output such as the following appears:
QOpenGLShaderProgram::uniformLocation(dpr): shader program is not linked
QOpenGLShaderProgram: could not create shader program
QOpenGLShader: could not create shader
QOpenGLShader: could not create shader
shader compilation failed: 


In /usr/bin/cura we see:
#WORKAROUND: GITHUB-88 GITHUB-385 GITHUB-612
if Platform.isLinux(): # Needed for platform.linux_distribution, which is not available on Windows and OSX
    # For Ubuntu: https://bugs.launchpad.net/ubuntu/+source/python-qt4/+bug/941826
    if platform.linux_distribution()[0] in ("debian", "Ubuntu", "LinuxMint"): # TODO: Needs a "if X11_GFX == 'nvidia'" here. The workaround is only needed on Ubuntu+NVidia drivers. Other drivers are not affected, but fine with this fix.


"Fedora" needs to be added to the if statement.

Patch attached.

Obviously it would be nice if this was fixed upstream. Hopefully this patch can be applied promptly for Fedora 27.

Comment 1 Miro Hrončok 2017-12-03 17:41:20 UTC
Will you propose this upstream as well?

Comment 2 Miro Hrončok 2017-12-03 17:48:53 UTC
Building a scratch build to test if it doesn't brek non-nvidia setups (like mine). Once finished, also please confirm, if it fixes it for you: https://koji.fedoraproject.org/koji/taskinfo?taskID=23522234

Comment 3 Miro Hrončok 2017-12-03 17:52:56 UTC
Accidental run it for f26, here's the correct one for f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=23522289

Comment 4 Andrew Donaldson 2017-12-04 09:57:46 UTC
(In reply to Miro Hrončok from comment #3)
> Accidental run it for f26, here's the correct one for f27:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=23522289

That build worked on my Fedora 27 with nvidia driver.
Inspecting the script, it looks right also.

Comment 5 Andrew Donaldson 2017-12-04 10:45:49 UTC
(In reply to Miro Hrončok from comment #1)
> Will you propose this upstream as well?

Done, pull request submitted.
https://github.com/Ultimaker/Cura/pull/2903

Comment 6 Fedora Update System 2017-12-04 14:24:22 UTC
cura-3.0.3-4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-012914a5d1

Comment 7 Fedora Update System 2017-12-04 17:01:55 UTC
cura-3.0.3-5.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-651c64e3d3

Comment 8 Fedora Update System 2017-12-08 23:27:44 UTC
cura-3.0.3-5.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-651c64e3d3

Comment 9 Fedora Update System 2017-12-19 19:45:56 UTC
cura-3.0.3-5.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.