Bug 1520542 - Multiple cloud volumes can't be added in Catalog
Summary: Multiple cloud volumes can't be added in Catalog
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.7.5
Assignee: Sam Lucidi
QA Contact: Vatsal Parekh
URL:
Whiteboard:
Depends On: 1506466
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-04 16:34 UTC by Satoe Imaishi
Modified: 2018-12-11 15:29 UTC (History)
9 users (show)

Fixed In Version: 5.7.4.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1506466
Environment:
Last Closed: 2018-12-11 15:29:18 UTC
Category: ---
Cloudforms Team: Openstack
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
recording (544.32 KB, video/mp4)
2017-12-12 09:09 UTC, Vatsal Parekh
no flags Details

Comment 2 CFME Bot 2017-12-04 17:31:32 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/166a4fa21b5d7f0f8f2cb07dc57c387b1acadd15

commit 166a4fa21b5d7f0f8f2cb07dc57c387b1acadd15
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Mon Dec 4 08:42:15 2017 +0100
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Dec 4 12:24:26 2017 -0500

    Merge pull request #2890 from mansam/fix-provisioning-workflow-volume-form
    
    Fix loop conditional on provisioning workflow volume form
    (cherry picked from commit 45d70e83af28dc3e9bed36cd45b8de7b6503bfed)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520542

 app/views/miq_request/_prov_dialog_volume_fieldset.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 3 Vatsal Parekh 2017-12-11 06:31:55 UTC
Able to verify this on Version 5.7.4.2.20171207173836_e563ef4

Comment 4 Vatsal Parekh 2017-12-12 09:07:41 UTC
So there a update on this BZ, this is half correct.
Please check the video attached to see exact behavior.

If you go to create volumes, create multiple volumes, and order them, it works.
But if you create multiple volumes, and go back to a different tab, and come back, only the first volume is visible. 
with this only 1 volume seen, created the request to provision, the output from `rails c` : MiqRequest.find(1)
 #<MiqProvisionRequest id: 1, description: "Provision from [cirros] to [vparekh_test]", approval_state: "approved", type: "MiqProvisionRequest", created_on: "2017-12-12 08:53:23", updated_on: "2017-12-12 08:54:20", fulfilled_on: nil, requester_id: 1, requester_name: "Administrator", request_type: "template", request_state: "active", message: "[EVM] VM [vparekh_test] Step [CheckProvisioned] St...", status: "Ok", options: {:initial_pass=>true, :src_vm_id=>[2, "cirros"], :miq_request_dialog_name=>"miq_provision_openstack_dialogs_template", :customize_enabled=>["enabled"], :current_tab_key=>:requester, :owner_phone=>nil, :owner_country=>nil, :owner_phone_mobile=>nil, :owner_title=>nil, :owner_first_name=>nil, :owner_manager=>nil, :owner_address=>nil, :owner_company=>nil, :owner_last_name=>nil, :owner_manager_mail=>nil, :owner_city=>nil, :owner_department=>nil, :owner_load_ldap=>nil, :owner_manager_phone=>nil, :owner_state=>nil, :owner_office=>nil, :owner_zip=>nil, :owner_email=>"vparekh", :request_notes=>nil, :vm_tags=>[], :placement_auto=>[true, 1], :placement_availability_zone=>[nil, nil], :cloud_tenant=>[nil, nil], :cloud_network=>[nil, nil], :security_groups=>[nil, nil], :floating_ip_address=>[nil, nil], :number_of_vms=>[1, "1"], :vm_description=>nil, :vm_prefix=>nil, :vm_name=>"vparekh_test", :schedule_type=>["immediately", "Immediately on Approval"], :schedule_time=>Wed, 13 Dec 2017 00:00:00 UTC +00:00, :retirement=>[0, "Indefinite"], :retirement_warn=>[604800, "1 Week"], :instance_type=>[1, "m1.tiny"], :guest_access_key_pair=>[nil, nil], :name=>nil, :size=>nil, :delete_on_terminate=>false, :customization_template_script=>nil, :dns_servers=>nil, :dns_suffixes=>nil, :addr_mode=>["dhcp", "DHCP"], :linux_host_name=>nil, :gateway=>nil, :linux_domain_name=>nil, :subnet_mask=>nil, :customization_template_id=>[nil, nil], :root_password=>nil, :hostname=>nil, :start_date=>"12/13/2017", :start_hour=>"00", :start_min=>"00", :src_vm_nics=>[], :src_vm_lans=>[], :src_ems_id=>[3, "RHOS11"], :name_1=>"vol1", :size_1=>"2", :volumes=>[{:name=>"vol1", :size=>"2"}], :requester_group=>"EvmGroup-super_administrator", :owner_group=>nil, :delivered_on=>2017-12-12 08:53:44 UTC, :user_message=>"[EVM] VM [vparekh_test] Step [CheckProvisioned] Status [Creating VM] Message [Creating VM] Current Retry Number [1]"}, userid: "admin", source_id: 2, source_type: "VmOrTemplate", destination_id: nil, destination_type: nil, tenant_id: 2, service_order_id: nil, process: true>

Comment 5 Vatsal Parekh 2017-12-12 09:09:44 UTC
Created attachment 1366484 [details]
recording

Volumes half fix recording

Comment 7 Sam Lucidi 2018-02-19 20:05:45 UTC
This was backported to Fine on January 10, 2018. https://github.com/ManageIQ/manageiq-ui-classic/pull/3043

Comment 8 Sam Lucidi 2018-02-19 20:06:47 UTC
Sorry, the above comment was unclear. To restate: the linked PR that fixed the second half of the bug was backported to Fine on January 10, 2018. https://github.com/ManageIQ/manageiq-ui-classic/pull/3043

Comment 9 CFME Bot 2018-02-27 15:06:18 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/ffad9d65e4b6c8a0306975337cc8c44b473c55a7

commit ffad9d65e4b6c8a0306975337cc8c44b473c55a7
Author:     Martin Hradil <himdel>
AuthorDate: Fri Dec 15 14:48:23 2017 +0100
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Feb 27 10:00:48 2018 -0500

    Merge pull request #3043 from mansam/fix-observation-of-cloned-volume-fieldsets
    
    Fix observation of cloned volume fieldsets
    (cherry picked from commit d4536f703bdbe64fdd865f1c24ede1fb62468961)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1520542

 .../miq_request/_prov_dialog_volume_fieldset.html.haml    | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)


Note You need to log in before you can comment on or make changes to this bug.