Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/749fc2d/perl-Data-Integer.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00683997-perl-Data-Integer/perl-Data-Integer-0.006-1.fc28.noarch.rpm Description: This module is about the native integer numerical data type. A native integer is one of the types of datum that can appear in the numeric part of a Perl scalar. This module supplies constants describing the native integer type. Fedora Account System Username: eclipseo
I believe the correct SRPM URL is <https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00683997-perl-Data-Integer/perl-Data-Integer-0.006-1.fc28.src.rpm>. I will use that for this review. URL and Source addresses are Ok. Source archive (SHA-256: 63b77ede3b639ce351525034863629af989abcbff4ab03b14fc4ead461ffa354) is original. Ok. Summary verified from lib/Data/Integer.pm. Ok. Description verified from lib/Data/Integer.pm. Ok. License verified from lib/Data/Integer.pm and README. Ok. No XS code, noarch BuildArch is Ok. FIX: Write dependency on a Perl language as `perl(:VERSION) >= 5.6' instead as `perl >= 0:5.006'. The `perl' package uses epoch and it pulls in unneeded packages. TODO: Do not package META.json. It's not intended for end users. TODO: Constrain `perl(Test::Pod)' dependency with `>= 1.00' (t/pod_syn.t:5). All tests pass. Ok. $ rpmlint perl-Data-Integer.spec ../SRPMS/perl-Data-Integer-0.006-1.fc28.src.rpm ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm drwxr-xr-x 2 root root 0 Dec 5 14:09 /usr/share/doc/perl-Data-Integer -rw-r--r-- 1 root root 3442 Aug 7 23:08 /usr/share/doc/perl-Data-Integer/Changes -rw-r--r-- 1 root root 1633 Aug 7 23:08 /usr/share/doc/perl-Data-Integer/META.json -rw-r--r-- 1 root root 741 Aug 7 23:08 /usr/share/doc/perl-Data-Integer/README -rw-r--r-- 1 root root 8177 Dec 5 14:09 /usr/share/man/man3/Data::Integer.3pm.gz drwxr-xr-x 2 root root 0 Dec 5 14:09 /usr/share/perl5/vendor_perl/Data -rw-r--r-- 1 root root 34570 Dec 5 14:09 /usr/share/perl5/vendor_perl/Data/Integer.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.1) 1 perl(Carp) 1 perl(Exporter) 1 perl(integer) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm | sort -f | uniq -c 1 perl(Data::Integer) = 0.006 1 perl-Data-Integer = 0.006-1.fc28 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm Binary dependencies resolvable. Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' item, consider fixing the `TODO' items and provide a new spec file. Resolution: Package NOT approved.
I have applied you recommendations, and will update all my other Perl packages suffering from the same issues accordingly. Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/047fc7f/perl-Data-Integer.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00684655-perl-Data-Integer/perl-Data-Integer-0.006-1.fc28.noarch.rpm
Damn, wrong RPM again. Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/047fc7f/perl-Data-Integer.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00684655-perl-Data-Integer/perl-Data-Integer-0.006-1.fc28.src.rpm
And thanks for the review!
Spec file changes: --- perl-Data-Integer.spec.old 2017-12-05 12:43:40.879000000 +0100 +++ perl-Data-Integer.spec 2017-12-06 08:44:07.666000000 +0100 @@ -6,7 +6,7 @@ URL: http://search.cpan.org/dist/Data-Integer/ Source0: http://www.cpan.org/authors/id/Z/ZE/ZEFRAM/Data-Integer-%{version}.tar.gz BuildArch: noarch -BuildRequires: perl >= 0:5.006 +BuildRequires: perl >= 5.6 BuildRequires: perl-generators BuildRequires: perl-interpreter BuildRequires: perl(Carp) @@ -18,7 +18,7 @@ BuildRequires: perl(strict) BuildRequires: perl(Test::More) BuildRequires: perl(Test::Pod::Coverage) -BuildRequires: perl(Test::Pod) +BuildRequires: perl(Test::Pod) >= 1.00 BuildRequires: perl(warnings) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) @@ -43,7 +43,7 @@ ./Build test %files -%doc Changes META.json README +%doc Changes README %{perl_vendorlib}/* %{_mandir}/man3/* > FIX: Write dependency on a Perl language as `perl(:VERSION) >= 5.6' instead > as `perl >= 0:5.006'. The `perl' package uses epoch and it pulls in > unneeded packages. FIX: This is still not correct. The correct RPM symbol is `perl(:VERSION)', not `perl'. > TODO: Do not package META.json. It's not intended for end users. Ok. > TODO: Constrain `perl(Test::Pod)' dependency with `>= 1.00' (t/pod_syn.t:5). Ok. Please fix the dependency and provide a new spec file.
Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/044a039/perl-Data-Integer.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685165-perl-Data-Integer/perl-Data-Integer-0.006-1.fc28.src.rpm SPEC diff: https://github.com/eclipseo/packaging/commit/044a03915082b110c40bbfbadc70c339554545de#diff-12ce820cb7d7c06d431cb39906fa6237
Spec file changes: --- perl-Data-Integer.spec.old 2017-12-06 08:44:07.666000000 +0100 +++ perl-Data-Integer.spec 2017-12-07 09:22:19.978000000 +0100 @@ -4,9 +4,9 @@ Summary: Details of the native integer data type License: GPL+ or Artistic URL: http://search.cpan.org/dist/Data-Integer/ -Source0: http://www.cpan.org/authors/id/Z/ZE/ZEFRAM/Data-Integer-%{version}.tar.gz +Source0: https://www.cpan.org/authors/id/Z/ZE/ZEFRAM/Data-Integer-%{version}.tar.gz BuildArch: noarch -BuildRequires: perl >= 5.6 +BuildRequires: perl(:VERSION) >= 5.6 BuildRequires: perl-generators BuildRequires: perl-interpreter BuildRequires: perl(Carp) > FIX: This is still not correct. The correct RPM symbol is `perl(:VERSION)', > not `perl'. Ok. The source archive is original (SHA-256: 63b77ede3b639ce351525034863629af989abcbff4ab03b14fc4ead461ffa354). Ok. $ rpmlint perl-Data-Integer.spec ../SRPMS/perl-Data-Integer-0.006-1.fc28.src.rpm ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. Package builds in F28 (https://koji.fedoraproject.org/koji/taskinfo?taskID=23562824). Ok. The package is good. Resolution: Package APPROVED.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Data-Integer. You may commit to the branch "f27" in about 10 minutes.
perl-Data-Integer-0.006-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-56be76145f
perl-Data-Integer-0.006-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-539a8b58e2
perl-Data-Integer-0.006-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-56be76145f
perl-Data-Integer-0.006-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-539a8b58e2
perl-Data-Integer-0.006-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
perl-Data-Integer-0.006-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
perl-Data-Integer-0.006-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-ea8e5d2eb5
perl-Data-Integer-0.006-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-ea8e5d2eb5
perl-Data-Integer-0.006-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.