Bug 1520582 - Review Request: perl-Mojolicious-Plugin-I18N - Internationalization Plugin for Mojolicious
Summary: Review Request: perl-Mojolicious-Plugin-I18N - Internationalization Plugin fo...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-04 18:55 UTC by Robert-André Mauchin 🐧
Modified: 2018-01-25 10:50 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-01-24 09:57:50 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2017-12-04 18:55:16 UTC
Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/749fc2d/perl-Mojolicious-Plugin-I18N.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00684004-perl-Mojolicious-Plugin-I18N/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm

Description: Mojolicious::Plugin::I18N is internationalization plugin for Mojolicious It
works with Mojolicious 4.0+.

Fedora Account System Username: eclipseo

Comment 3 Petr Pisar 2018-01-05 12:16:15 UTC
Url and Source0 are usable. Ok.
Source0 archive (SHA-256: 32fb5ef8037d954b7ecebef5c1b2b24b420abd829702312f4ad42794f52b514d) is original. Ok.
Summary verified from lib/Mojolicious/Plugin/I18N.pm. Ok.

TODO: The description text is missing a full stop before "It" word.

FIX: The License tag is wrong. lib/Mojolicious/Plugin/I18N.pm and README.pod states "Artistic 2.0". The specification at Build.PL:7 is probably a mistake.

FIX: Build-require 'perl(constant)' (lib/Mojolicious/Plugin/I18N.pm:153).
FIX: Build-require 'perl(I18N::LangTags::Detect)' (lib/Mojolicious/Plugin/I18N.pm:6).
FIX: Build-require 'perl(Mojo::Base)' (lib/Mojolicious/Plugin/I18N.pm:2).
FIX: Build-require 'perl(Mojo::URL)' (lib/Mojolicious/Plugin/I18N.pm:4).
FIX: Build-require 'perl(Mojolicious::Plugin)' (lib/Mojolicious/Plugin/I18N.pm:2)'.

FIX: Build-require 'perl(base)' (t/i18n.t:16).
FIX: Build-require 'perl(lib)' (t/i18n.t:2).
FIX: Build-require 'perl(Locale::Maketext)' (t/i18n.t:16).
FIX: Build-require 'perl(Mojolicious::Lite)' (t/i18n.t:29).

TODO: You should run-require 'perl(Mojolicious) >= 5' for the same reason as you build-require it.

Please correct all 'FIX' items, consider fixing 'TODO' items, and provide a new spec file.
Resolution: Package NOT approved.

Comment 5 Petr Pisar 2018-01-08 09:40:43 UTC
> TODO: The description text is missing a full stop before "It" word.
Ok.

> FIX: The License tag is wrong. lib/Mojolicious/Plugin/I18N.pm and README.pod
> states "Artistic 2.0". The specification at Build.PL:7 is probably a mistake.
Ok.

> FIX: Build-require 'perl(constant)' (lib/Mojolicious/Plugin/I18N.pm:153).
Ok.

> FIX: Build-require 'perl(I18N::LangTags::Detect)' (lib/Mojolicious/Plugin/I18N.pm:6).
Ok.

> FIX: Build-require 'perl(Mojo::Base)' (lib/Mojolicious/Plugin/I18N.pm:2).
Ok.

> FIX: Build-require 'perl(Mojo::URL)' (lib/Mojolicious/Plugin/I18N.pm:4).
Ok.

> FIX: Build-require 'perl(Mojolicious::Plugin)' (lib/Mojolicious/Plugin/I18N.pm:2)'.
Ok.

> FIX: Build-require 'perl(base)' (t/i18n.t:16).
Ok.

> FIX: Build-require 'perl(lib)' (t/i18n.t:2).
Ok.

> FIX: Build-require 'perl(Locale::Maketext)' (t/i18n.t:16).
Ok.

> FIX: Build-require 'perl(Mojolicious::Lite)' (t/i18n.t:29).
Ok.

> TODO: You should run-require 'perl(Mojolicious) >= 5' for the same reason as you build-require it.
Ok.

Fix: Build-require 'perl(utf8)' (t/i18n.t:3).

All tests pass. Ok.

$ rpmlint perl-Mojolicious-Plugin-I18N.spec ../SRPMS/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.src.rpm ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm 
perl-Mojolicious-Plugin-I18N.noarch: E: wrong-script-interpreter /usr/share/doc/perl-Mojolicious-Plugin-I18N/script/app_i18n_mail.pl /usr/bin/env perl
2 packages and 1 specfiles checked; 1 errors, 0 warnings.

rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jan  8 10:29 /usr/share/doc/perl-Mojolicious-Plugin-I18N
-rw-r--r--    1 root    root                      965 Aug 11  2015 /usr/share/doc/perl-Mojolicious-Plugin-I18N/Changes
drwxr-xr-x    2 root    root                        0 Aug 11  2015 /usr/share/doc/perl-Mojolicious-Plugin-I18N/script
-rw-r--r--    1 root    root                      586 Aug 11  2015 /usr/share/doc/perl-Mojolicious-Plugin-I18N/script/App.pm
-rw-r--r--    1 root    root                      446 Aug 11  2015 /usr/share/doc/perl-Mojolicious-Plugin-I18N/script/app_i18n_mail.pl
-rw-r--r--    1 root    root                       98 Aug 11  2015 /usr/share/doc/perl-Mojolicious-Plugin-I18N/script/test.mail.ep
-rw-r--r--    1 root    root                     3254 Jan  8 10:29 /usr/share/man/man3/Mojolicious::Plugin::I18N.3pm.gz
drwxr-xr-x    2 root    root                        0 Jan  8 10:29 /usr/share/perl5/vendor_perl/Mojolicious
drwxr-xr-x    2 root    root                        0 Jan  8 10:29 /usr/share/perl5/vendor_perl/Mojolicious/Plugin
-rw-r--r--    1 root    root                     8488 Jan  8 10:29 /usr/share/perl5/vendor_perl/Mojolicious/Plugin/I18N.pm
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(constant)
      1 perl(I18N::LangTags)
      1 perl(I18N::LangTags::Detect)
      1 perl(Mojo::Base)
      1 perl(Mojo::URL)
      1 perl(Mojolicious) >= 5
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Run-require 'perl(Mojolicious::Plugin)' (lib/Mojolicious/Plugin/I18N.pm:2).
FIX: Run-require 'perl(strict)' (lib/Mojolicious/Plugin/I18N.pm:143).
FIX: Run-require 'perl(warnings)' (lib/Mojolicious/Plugin/I18N.pm:144).
FIX: Constrain 'perl(I18N::LangTags)' run-time dependency with '>= 0.35' (META.json:36).

$ rpm -q --provides -p ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm | sort -f | uniq -c
      1 perl(Mojolicious::Plugin::I18N) = 1.6
      1 perl(Mojolicious::Plugin::I18N::_Handler)
      1 perl-Mojolicious-Plugin-I18N = 1.6-1.fc28
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm 
Binary dependencies resolvable. Ok.

The package builds in F28 (https://koji.fedoraproject.org/koji/taskinfo?taskID=24071493). Ok.

Please correct all 'FIX' items and provide a new spec file.
Resolution: Package NOT approved.

Comment 7 Petr Pisar 2018-01-08 14:59:29 UTC
> Fix: Build-require 'perl(utf8)' (t/i18n.t:3).
Ok.

$ rpmlint perl-Mojolicious-Plugin-I18N.spec ../SRPMS/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.src.rpm ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm 
perl-Mojolicious-Plugin-I18N.noarch: E: wrong-script-interpreter /usr/share/doc/perl-Mojolicious-Plugin-I18N/script/app_i18n_mail.pl /usr/bin/env perl
2 packages and 1 specfiles checked; 1 errors, 0 warnings.

rpmlint is Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm |sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(constant)
      1 perl(I18N::LangTags)
      1 perl(I18N::LangTags) >= 0.35
      1 perl(I18N::LangTags::Detect)
      1 perl(Mojo::Base)
      1 perl(Mojo::URL)
      1 perl(Mojolicious) >= 5
      1 perl(Mojolicious::Plugin)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

TODO: Filter the less specific 'perl(I18N::LangTags)' dependency without the version. It only pollutes the repository database.

$ resolvedeps rawhide ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F28 (https://koji.fedoraproject.org/koji/taskinfo?taskID=24076144). Ok.

Please consider fixing the 'TODO' item before building this package.
Resolution: Package APPROVED.

Comment 8 Robert-André Mauchin 🐧 2018-01-08 18:25:58 UTC
>TODO: Filter the less specific 'perl(I18N::LangTags)' dependency without the version.

I'm not entirely sure how to do that. Using %global __requires_exclude ?

Comment 9 Petr Pisar 2018-01-09 08:18:33 UTC
Yes. This could do it:

%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(I18N::LangTags\\)$

Comment 10 Gwyn Ciesla 2018-01-09 13:24:08 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Mojolicious-Plugin-I18N. You may commit to the branch "f27" in about 10 minutes.

Comment 11 Fedora Update System 2018-01-09 23:04:00 UTC
perl-Mojolicious-Plugin-I18N-1.6-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-48b68ecee8

Comment 12 Fedora Update System 2018-01-09 23:09:34 UTC
perl-Mojolicious-Plugin-I18N-1.6-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8ecf44c366

Comment 13 Fedora Update System 2018-01-10 15:54:51 UTC
perl-Mojolicious-Plugin-I18N-1.6-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8ecf44c366

Comment 14 Fedora Update System 2018-01-10 16:15:25 UTC
perl-Mojolicious-Plugin-I18N-1.6-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-48b68ecee8

Comment 15 Fedora Update System 2018-01-24 09:57:50 UTC
perl-Mojolicious-Plugin-I18N-1.6-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2018-01-25 10:50:55 UTC
perl-Mojolicious-Plugin-I18N-1.6-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.