Bug 1520751 - [GSS]nfs-ganesha crashing after enabling ganesha.enable on a volume
Summary: [GSS]nfs-ganesha crashing after enabling ganesha.enable on a volume
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: nfs-ganesha
Version: rhgs-3.3
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: RHGS 3.4.0
Assignee: Daniel Gryniewicz
QA Contact: Manisha Saini
URL:
Whiteboard:
: 1528376 (view as bug list)
Depends On:
Blocks: 1503138
TreeView+ depends on / blocked
 
Reported: 2017-12-05 04:54 UTC by Abhishek Kumar
Modified: 2021-06-10 13:49 UTC (History)
15 users (show)

Fixed In Version: nfs-ganesha-2.5.5-1
Doc Type: Bug Fix
Doc Text:
NFS-Ganesha crashed on NFS version 3 request if the GUARDED flag was set to true. The GUARDED flag checks for the presence of a duplicate file before performing the create or open call and should fail the request with NFS3ERR_EXIST if a duplicate file exists. With this fix, the GUARDED flag can handle the NFS version 3 create request and does not crash NFS-Ganesha.
Clone Of:
Environment:
Last Closed: 2018-09-04 06:54:24 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2018:2610 0 None None None 2018-09-04 06:55:33 UTC

Description Abhishek Kumar 2017-12-05 04:54:17 UTC
Description of problem:

nfs-ganesha crashing after enabling ganesha.enable on a volume

Version-Release number of selected component (if applicable):

RHGS 3.3.1

nfs-ganesha-2.4.4-17.el7rhgs.x86_64                         Fri Dec  1 16:14:01 2017
nfs-ganesha-gluster-2.4.4-17.el7rhgs.x86_64                 Fri Dec  1 16:14:03 2017
nfs-utils-1.3.0-0.48.el7_4.x86_64                           Fri Dec  1 16:13:36 2017

How reproducible:

Cu environment

Steps to Reproduce:
1. Create a nfs-ganesha HA setup
2. try to set ganesha.enable on 
3. nfs-ganesha crashes.

Actual results:

nfs-ganesha crashing after enabling ganesha.enable

Expected results:

nfs-ganesha shouldn't crash

Additional info:

Comment 6 Jiffin 2017-12-05 05:51:48 UTC
Hi Abhishek,

It seems following commit got fixed this issue in upstream https://review.gerrithub.io/#/c/355473/. The patch will be available as part of 2.5 nfs-ganesha(RHGS 3.4). Requesting Dan to confirm the same.
      
--
Jiffin

Comment 8 Daniel Gryniewicz 2017-12-05 12:30:00 UTC
Jiffin is correct.  That is the correct fix.

Comment 14 Daniel Gryniewicz 2017-12-05 15:41:53 UTC
Note the workaround is unrelated to the patch; the patch fixes the issue, no workaround necessary.  Without the patch, the workaround is needed (but will continue to be needed every time the situation comes up)

Comment 21 Daniel Gryniewicz 2017-12-07 17:34:43 UTC
I think it's a coincidence.  Probably the file(s) in question were deleted as part of the server move.

I'm not aware of any way to find which files are triggering the crash, I'm sorry.  Which files are opened GUARDED is up to the client workload, and we have no way of finding them after the fact.  In addition the codepath in question doesn't log anything useful.  Logs could be added, but if we're giving them a patch, we should give them the fix.

Even if they are found, removing them is only a temporary workaround. The next time they are not deleted by the client workload (the original bug was due to a crash in the client), the server will start crashing again.  This means that the workaround is not very effective; it will allow the boot, but the crash will manifest again at some unknown point in the future.

The only way to fully fix the issue is to apply the patch.

Comment 29 Bipin Kunal 2017-12-22 07:57:38 UTC
*** Bug 1528376 has been marked as a duplicate of this bug. ***

Comment 38 Kaleb KEITHLEY 2018-02-05 09:09:35 UTC
RHEA-2018:32427 was filed in error.

this BZ is included in RHEA-2018:32429

Yes, nfs-ganesha-2.5.5-1 will be in RHGS-3.4

Comment 45 Daniel Gryniewicz 2018-05-09 12:14:01 UTC
Agreed.

Comment 47 Daniel Gryniewicz 2018-08-31 13:26:41 UTC
"if the GUARDED flag was set to true, and the file existed."

Comment 49 errata-xmlrpc 2018-09-04 06:54:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:2610


Note You need to log in before you can comment on or make changes to this bug.