Description of problem: Should disable bind button when the binding creation wizard not loaded completely. Version-Release number of selected component (if applicable): v3.7.9 How reproducible: Always Steps to Reproduce: 1. Select one serviceclass to provision 2. Goto overview page, click 'create binding' for provisioned service. 3. Click enabled ’Bind‘ button when opened wizard not loaded completely yet. 4. Wait for wizard loading completely, and click ‘Bind’ button Actual results: 3. After a while, the close button will change to button with text 'Bind' in the fresh wizard. Click that button, could close the wizard. 4. The 'Close' button works well. Expected results: 3. Should always keep button with text 'Close'. Additional info:
Created attachment 1363094 [details] wizard_loading_completely
Created attachment 1363095 [details] wizard_not_loading_completely
I believe this is working properly. The initial page informs you what the binding will do and waits upon the user to confirm by pressing the 'Bind' button. Once that is pressed the bind operation begins and the results pages is shown to show the user hte progress of the operation.
The point is that should keep the 'Close' button instead of changing the button text to 'Bind' when results page is shown if users click "Bind" in the initial page which content not loaded completely. For more information, please see attachment.
We should fix the problem with the bind button, but it also worries me that this dialog is taking so long to load in the first place. It looks like we are loading the service classes and all plans always when we shouldn't need to. From this context at least, we already have both. The simple fix is to disable the bind button until everything loads, but it would be better to pass in the service class and service plan to the dialog to avoid unnecessary requests.
Agreed. I see that it is possible to only retrieve the service class for the service instance and the service plans for just that service class. I will address this as well as the button enablement.
PR: https://github.com/openshift/origin-web-console/pull/2585
Commits pushed to master at https://github.com/openshift/origin-web-console https://github.com/openshift/origin-web-console/commit/2e311e664303aeb20e76b0ecd1079c18bf1e9b0c Bug 1520828 - Do not enable Bind button until data fetched Also, do not fetch all the service classes and plans when only a single service class and its plans are necessary. https://github.com/openshift/origin-web-console/commit/61898e3d689188f96f3b0c0218206cb117f5e8e4 Merge pull request #2585 from jeff-phillips-18/bind Automatic merge from submit-queue. Bug 1520828 - Do not enable Bind button until data fetched Also, do not fetch all the service classes and plans when only a single service class and its plans are necessary.
The bug verification process was covered by testing schedule, the issue has been fixed. move to verified.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:3748