Bug 1521216 - Choosing Redeploy from cockpit, should generate new gdeploy configuration file
Summary: Choosing Redeploy from cockpit, should generate new gdeploy configuration file
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: Gdeploy
Version: 0.10.8-2.2
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ovirt-4.1.9
: ---
Assignee: Gobinda Das
QA Contact: SATHEESARAN
URL:
Whiteboard:
Depends On:
Blocks: 1521215
TreeView+ depends on / blocked
 
Reported: 2017-12-06 02:23 UTC by SATHEESARAN
Modified: 2018-01-24 10:40 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1521215
Environment:
Last Closed: 2018-01-24 10:40:59 UTC
oVirt Team: Gluster
Embargoed:
rule-engine: ovirt-4.1?
sasundar: planning_ack?
rule-engine: devel_ack+
sasundar: testing_ack+


Attachments (Terms of Use)

Description SATHEESARAN 2017-12-06 02:23:21 UTC
+++ This bug was initially created as a clone of Bug #1521215 +++

Description of problem:
-----------------------
When the gluster deployment fails, cockpit UI throws the status in the text area and provides the option to redeploy. If chosen to redeploy, the generated gdeploy config file tab is shown, intending the user to make changes to the existing gdeploy conf file.

At the same time, it allows the user to navigate to other tabs. If user changes the values, in those tabs, and comes back the generated gdeploy conf file tab, new gdeploy config file is not generated

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
cockpit-ovirt-0.10.9

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Provide the non-existing disk for bricks, say sdz and continue deployment from cockpit. Installation will fail, and cockpit provides option to 'Redeploy'
2. Go to the bricks tab, update the disk as 'sdb'
3. Navigate to the gdeploy conf file tab.

Actual results:
---------------
gdeploy conf file still contains the old data ( disk sdz ), which means the new gdeploy conf file is not generated post updating the disks in brick tab

Expected results:
-----------------
While choosing 'Redeploy', if the user corrects any of the input then new gdeploy config file should be generated

Comment 1 Gobinda Das 2018-01-05 09:37:18 UTC
Hi SAS,
I am not able to reproduce in my dev environment which is master code base.

Steps followed:
1- Leave all values as defult with wrong hosts,then deployment fails.
ex. device: sdb

2- Clicked "Redeploy" -> Back (Brick wizard) -> changed device to "sdd" and changed size also -> Next ->
gdeploy.conf file generated with "sdd" entries and given size as  well.

Comment 2 SATHEESARAN 2018-01-12 09:40:47 UTC
(In reply to Gobinda Das from comment #1)
> Hi SAS,
> I am not able to reproduce in my dev environment which is master code base.
> 
> Steps followed:
> 1- Leave all values as defult with wrong hosts,then deployment fails.
> ex. device: sdb
> 
> 2- Clicked "Redeploy" -> Back (Brick wizard) -> changed device to "sdd" and
> changed size also -> Next ->
> gdeploy.conf file generated with "sdd" entries and given size as  well.

Gobinda,

The issue is found with latest cockpit-ovirt-dashboard available in RHV 4.1.8

If the issue now not found in master, then there should be some patch that should have fixed it. Please move this to bug to ON_QA with the latest available cockpit-ovirt-dashboard as fixed-in-version

QE will verify this bug for 4.1.9 or 4.2, based on where the fix has landed.

Comment 3 SATHEESARAN 2018-01-12 09:52:22 UTC
As per comment#1, this issue is **not** found with master, and Gobinda was unable to find the patch that solved the issue.

I will retest the issue with cockpit-ovirt-dashboard available with RHV 4.1.9.
If this issue is not found, then this bug could be targeted for RHV 4.1.9 and moved ON_QA

Comment 4 SATHEESARAN 2018-01-23 10:42:22 UTC
(In reply to SATHEESARAN from comment #3)
> As per comment#1, this issue is **not** found with master, and Gobinda was
> unable to find the patch that solved the issue.
> 
> I will retest the issue with cockpit-ovirt-dashboard available with RHV
> 4.1.9.
> If this issue is not found, then this bug could be targeted for RHV 4.1.9
> and moved ON_QA

Tested with RHV 4.1.9, and this issue is not observed.
After clicking 'Redeploy' user could edit the values which gets reflected in the generated gdeploy config file.

So this problem is fixed in RHV 4.1.9 as mentioned in comment3


Sahina,

Could you move this bug to ON_QA, with release version set to RHV 4.1.9, so that it could be verified ?

Comment 5 SATHEESARAN 2018-01-23 10:54:41 UTC
As mentioned in comment4, this issue is not seen with cockpit-ovirt-dasboard-0.10.10 with RHV 4.1.9

Comment 6 Sandro Bonazzola 2018-01-24 10:40:59 UTC
This bugzilla is included in oVirt 4.1.9 release, published on Jan 24th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.1.9 release, published on Jan 24th 2018, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.