Bug 1522388 - [RFE] Allow deploy metrics with no-default storageclass
Summary: [RFE] Allow deploy metrics with no-default storageclass
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Hawkular
Version: 3.7.1
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 3.7.z
Assignee: John Sanda
QA Contact: Junqi Zhao
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-06 03:13 UTC by Anping Li
Modified: 2021-09-09 12:54 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-21 01:33:29 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Anping Li 2017-12-06 03:13:33 UTC
Description of problem:
By default, when openshift_metrics_cassandra_storage_type=dynamic, the metrics will use the default storageclass.  There is no way to deploy metrics with non-default storage class.

It is better to use an inventory variable to specify the storageclass. The candiate variables are openshift_metrics_cassandra_storage_type=storageclassname, openshift_metrics_cassandra_storage_class=storageclassname

Version-Release number of selected component (if applicable):
3.7

How reproducible:
Always

Steps to Reproduce:
1) There are multiple storageclass, try to deploy metrics with non-default storageclass.

Actual results:
The openshift-admin must change the default storageclass before deploy metrics

Expected results:
There are some variables to specify the storageclass name

Comment 1 Anping Li 2017-12-12 02:08:43 UTC
@Matt, Could we fix it in v3.7.z?

Comment 2 Matt Wringe 2017-12-12 14:37:14 UTC
@anli: we could fix it in v3.7.z, this should be a fairly simple change to how ansible does things

@snegrea: will you have time to look into this soon?

Comment 5 Anping Li 2018-03-29 02:24:17 UTC
*** Bug 1561799 has been marked as a duplicate of this bug. ***

Comment 6 Mark McKinstry 2018-03-29 16:38:12 UTC
There's an undocumented variable to tell it what storage class to use: openshift_metrics_cassanda_pvc_storage_class_name . 


https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_metrics/tasks/generate_cassandra_pvcs.yaml#L44

Comment 7 Mark McKinstry 2018-03-29 17:11:42 UTC
Also note the variable name is spelled 'openshift_metrics_cassanda_pvc_storage_class_name' in the code, it should probably be changed to 'openshift_metrics_cassandra_pvc_storage_class_name' with the corrected spelling of 'cassandra' .

Comment 14 openshift-github-bot 2018-07-19 19:47:01 UTC
Commits pushed to master at https://github.com/openshift/openshift-docs

https://github.com/openshift/openshift-docs/commit/cee64799b583a29cb14bdeb1ed3efba9c287fa21
Bug 1522388 Add openshift_metrics_cassandra_storage_class_name variable and description

https://github.com/openshift/openshift-docs/commit/4eaaf7bf6034259eb6d1adda21d406ecc0e5bcab
Merge pull request #10045 from bmcelvee/BZ1522388

Bug 1522388 Add openshift_metrics_cassandra_storage_class_name variable and description

Comment 17 Anping Li 2018-08-21 01:33:29 UTC
@john, Yes, It is doc issue.


Note You need to log in before you can comment on or make changes to this bug.