+++ This bug was initially created as a clone of Bug #1515266 +++ Description of problem: EC delays PARENT_DOWN propagation until all pending requests have completed, but heal operations are ignored. This can cause unexpected results when a heal operation is running while the volume is being unmounted. Version-Release number of selected component (if applicable): master How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: --- Additional comment from Ashish Pandey on 2017-11-22 04:51:00 EST --- Xavi, This issue is true for afr also. Do you think we can fix it in some common place like syntask infra? Or we have to deal with it separately. Ashish --- Additional comment from Worker Ant on 2017-11-22 05:33:32 EST --- REVIEW: https://review.gluster.org/18840 (cluster/ec: Prevent self-heal to work after PARENT_DOWN) posted (#1) for review on master by Xavier Hernandez --- Additional comment from Xavi Hernandez on 2017-11-22 13:23:31 EST --- (In reply to Ashish Pandey from comment #1) > Xavi, > > This issue is true for afr also. Do you think we can fix it in some common > place > like syntask infra? Or we have to deal with it separately. > > Ashish I'm not sure how synctask could help here. It should have access to some information telling if the xlator that has initiated the operation is shutting down or not (I don't think we have this). But even then, aborting a single operation doesn't guarantee that the caller do not attempt another synctask operation (for example healing the next entry of a directory) still delaying the shutdown and causing multiple failures on fops that have not really failed (it will probably add noise to the logs). I think this is better to be handled inside the xlator itself. If AFR already tracks ongoing regular operations, I think it would be relatively easy to include heals in the checks, though I haven't looked at it. --- Additional comment from Worker Ant on 2017-11-28 04:12:20 EST --- COMMIT: https://review.gluster.org/18840 committed in master by \"Xavier Hernandez\" <jahernan> with a commit message- cluster/ec: Prevent self-heal to work after PARENT_DOWN When the volume is being stopped, PARENT_DOWN event is received. This instructs EC to wait until all pending operations are completed before declaring itself down. However heal operations are ignored and allowed to continue even after having said it was down. This may cause unexpected results and crashes. To solve this, heal operations are considered exactly equal as any other operation and EC won't propagate PARENT_DOWN until all operations, including healing, are complete. To avoid big delays if this happens in the middle of a big heal, a check has been added to quit current heal if shutdown is detected. Change-Id: I26645e236ebd115eb22c7ad4972461111a2d2034 BUG: 1515266 Signed-off-by: Xavier Hernandez <jahernan>
REVIEW: https://review.gluster.org/18942 (cluster/ec: Prevent self-heal to work after PARENT_DOWN) posted (#1) for review on release-3.13 by Sunil Kumar Acharya
This bug reported is against a version of Gluster that is no longer maintained (or has been EOL'd). See https://www.gluster.org/release-schedule/ for the versions currently maintained. As a result this bug is being closed. If the bug persists on a maintained version of gluster or against the mainline gluster repository, request that it be reopened and the Version field be marked appropriately.