Bug 1522847 - gNFS Bug Fixes
Summary: gNFS Bug Fixes
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: GlusterFS
Classification: Community
Component: nfs
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-06 15:08 UTC by Shreyas Siravara
Modified: 2018-11-21 05:43 UTC (History)
1 user (show)

Fixed In Version: glusterfs-4.0.0
Clone Of:
Environment:
Last Closed: 2018-11-21 05:43:15 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Shreyas Siravara 2017-12-06 15:08:24 UTC
Description of problem: Various bug fixes for gNFS

Comment 1 Worker Ant 2017-12-06 15:16:44 UTC
REVIEW: https://review.gluster.org/18959 (nfs: Add locking to auth-cache, fix some bugs) posted (#1) for review on master by

Comment 2 Worker Ant 2017-12-06 15:19:12 UTC
REVIEW: https://review.gluster.org/18939 (gNFSd: Auto re-register NFS/Mount programs with rpcbind periodically) posted (#2) for review on master by

Comment 3 Worker Ant 2017-12-06 16:05:56 UTC
REVIEW: https://review.gluster.org/18963 (nfs: Enable multi-core epoll support in gNFSd) posted (#1) for review on master by Shreyas Siravara

Comment 4 Worker Ant 2017-12-06 16:06:59 UTC
REVIEW: https://review.gluster.org/18964 (nfs: Enable multi-core epoll support in gNFSd) posted (#1) for review on master by Shreyas Siravara

Comment 5 Worker Ant 2017-12-06 16:07:59 UTC
REVIEW: https://review.gluster.org/18965 (nfs: Check if FQDN is authorized before unmounting clients) posted (#1) for review on master by

Comment 6 Worker Ant 2017-12-06 17:21:45 UTC
REVIEW: https://review.gluster.org/18967 ([nfs] exports_auth per (sub) volume) posted (#1) for review on master by

Comment 7 Worker Ant 2017-12-06 19:37:27 UTC
REVIEW: https://review.gluster.org/18971 (nfs: Correctly reconfigure NFS options) posted (#1) for review on master by

Comment 8 Worker Ant 2017-12-06 20:05:55 UTC
REVIEW: https://review.gluster.org/18973 (glusterd: Allow volume stop to succeed if certain processes are already dead) posted (#1) for review on master by

Comment 9 Worker Ant 2017-12-06 20:53:13 UTC
COMMIT: https://review.gluster.org/18965 committed in master by  with a commit message- nfs: Check if FQDN is authorized before unmounting clients

Summary:
- We have a thread that checks if connected clients are "still" authorized for a mount.
- This thread is currently only checking the IP (regression from the 3.4 -> 3.6 rebase, perhaps).
- This diff adds code toe check the IP *and* the FQDN before unmounting the client.

Test Plan: Tested on devserver, auth prove tests.

Reviewers: rwareing, kvigor

Reviewed By: kvigor

Change-Id: I441a4436d8df064d2f09a2539acb780ab53943f6
BUG: 1522847
Reviewed-on: https://review.gluster.org/18193
Reviewed-by: Shreyas Siravara <sshreyas>
CentOS-regression: Gluster Build System <jenkins.org>
Smoke: Gluster Build System <jenkins.org>
Signed-off-by: Siri Uppalapati <siri>

Comment 10 Worker Ant 2017-12-06 21:10:09 UTC
REVISION POSTED: https://review.gluster.org/18973 (glusterd: Allow volume stop to succeed if certain processes are already dead) posted (#2) for review on master by

Comment 11 Worker Ant 2017-12-06 21:32:25 UTC
REVIEW: https://review.gluster.org/18975 (Fixes gNFSd gf_update_latency crashes) posted (#1) for review on master by

Comment 12 Worker Ant 2017-12-07 03:44:39 UTC
COMMIT: https://review.gluster.org/18975 committed in master by  with a commit message- Fixes gNFSd gf_update_latency crashes

Summary:
- Per title, does a bounds check on the frame->op and bails from the
  function if it's invalid preventing the crash

Test Plan: Prove tests

Reviewers: dph, jackl

Reviewed By: jackl

FB-commit-id: e67cc15

Change-Id: If1a5a9c0630573d4a6615050a9114ccf532551c7
BUG: 1522847
Signed-off-by: Kevin Vigor <kvigor>
Reviewed-on: https://review.gluster.org/16847
CentOS-regression: Gluster Build System <jenkins.org>
NetBSD-regression: NetBSD Build System <jenkins.org>
Smoke: Gluster Build System <jenkins.org>
Reviewed-by: Shreyas Siravara <sshreyas>

Comment 13 Worker Ant 2017-12-07 16:07:09 UTC
REVIEW: https://review.gluster.org/19004 (exports: Reference count export items) posted (#1) for review on master by Shreyas Siravara

Comment 14 Worker Ant 2017-12-07 16:12:44 UTC
REVIEW: https://review.gluster.org/19005 (exports: Reference count export items) posted (#1) for review on master by Shreyas Siravara

Comment 15 Worker Ant 2017-12-08 20:40:38 UTC
COMMIT: https://review.gluster.org/18964 committed in master by \"Shreyas Siravara\" <sshreyas> with a commit message- nfs: Enable multi-core epoll support in gNFSd

Change-Id: Ie8a7b1ba04b0e83f5ec7a09f9d181fe59be479ca
BUG: 1522847
Signed-off-by: Shreyas Siravara <sshreyas>

Comment 16 Worker Ant 2017-12-08 22:33:53 UTC
COMMIT: https://review.gluster.org/19005 committed in master by \"Shreyas Siravara\" <sshreyas> with a commit message- nfs: Reference count export items

Export items are used in the auth cache and need to be reference
counted to avoid use-after free bugs.

Change-Id: I5cdcdc1cc6abad26c7077d66a14f263da07678ac
BUG: 1522847
Signed-off-by: Shreyas Siravara <sshreyas>

Comment 17 Shyamsundar 2018-03-15 11:22:36 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.0.0, please open a new bug report.

glusterfs-4.0.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-March/000092.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 18 Worker Ant 2018-03-28 03:16:57 UTC
REVIEW: https://review.gluster.org/18967 ([nfs] exports_auth per (sub) volume) posted (#7) for review on master by Amar Tumballi

Comment 19 Jiffin 2018-11-21 05:43:15 UTC
There is not much development happening towards past year and not planning in upcoming releases as well. Hence closing the bug as defered for the time being. Please reopen the bug if needed


Note You need to log in before you can comment on or make changes to this bug.