Bug 1522950 - io-threads is unnecessarily calling accurate time calls on every FOP
Summary: io-threads is unnecessarily calling accurate time calls on every FOP
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: io-threads
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-06 19:35 UTC by Shreyas Siravara
Modified: 2018-03-15 11:23 UTC (History)
1 user (show)

Fixed In Version: glusterfs-4.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-15 11:23:27 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Shreyas Siravara 2017-12-06 19:35:54 UTC
Description of problem: io-threads is unnecessarily calling accurate time calls on every FOP

Comment 1 Worker Ant 2017-12-06 19:38:16 UTC
REVIEW: https://review.gluster.org/18972 (performance/io-threads: Reduce the number of timing calls in iot_worker) posted (#1) for review on master by Shreyas Siravara

Comment 2 Worker Ant 2017-12-07 02:42:00 UTC
COMMIT: https://review.gluster.org/18972 committed in master by \"Shreyas Siravara\" <sshreyas> with a commit message- performance/io-threads: Reduce the number of timing calls in iot_worker

Summary:
- Reduce the amount of unnecessary timing calls
in iot_worker servicing.
- The current logic is unnecessarily accurate and
hurts performance for many small FOPS.

Change-Id: I6db4f1ad9a48d9d474bb251a2204969061021954
BUG: 1522950
Signed-off-by: Shreyas Siravara <sshreyas>
Reviewed-on: http://review.gluster.org/16081
Smoke: Gluster Build System <jenkins.org>
NetBSD-regression: NetBSD Build System <jenkins.org>
CentOS-regression: Gluster Build System <jenkins.org>
Reviewed-by: Kevin Vigor <kvigor>

Comment 3 Shyamsundar 2018-03-15 11:23:27 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.0.0, please open a new bug report.

glusterfs-4.0.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-March/000092.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.