RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1523016 - crash in nft list on ppc64 system
Summary: crash in nft list on ppc64 system
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: nftables
Version: 7.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Phil Sutter
QA Contact: Li Shuang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-07 02:42 UTC by Li Shuang
Modified: 2018-04-10 16:09 UTC (History)
2 users (show)

Fixed In Version: nftables-0.8-6.el7
Doc Type: Bug Fix
Doc Text:
Cause: Incorrect handling of 'ct helper' statement could lead to nft command crash. Consequence: Trying to list a ruleset which contained a 'ct helper' statement in one of its rules would lead to nft command crash under certain conditions (seen with 'ct helper tftp' on big-endian machines). Fix: Problematic piece of code was fixed. Result: Crash does not happen anymore.
Clone Of:
Environment:
Last Closed: 2018-04-10 16:09:09 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2018:0882 0 None None None 2018-04-10 16:09:34 UTC

Comment 4 Phil Sutter 2017-12-09 16:01:31 UTC
Bug found, patch submitted upstream: https://marc.info/?l=netfilter-devel&m=151283476531297&w=2

Comment 6 Phil Sutter 2017-12-12 16:52:38 UTC
Hi Li Shuang,

Yes, this looks like the same issue. The problem depended on which value was given to 'ct helper' expression, so might happen on little-endian as well under certain circumstances.

BTW, upstream applied my patch:

commit a2c55e04d5a1187914cba2c02810db94de499ace (origin/master, origin/HEAD)
Author: Phil Sutter <phil>
Date:   Sat Dec 9 16:52:29 2017 +0100

    src: fix protocol context update on big-endian systems
    
    There is an obscure bug on big-endian systems when trying to list a rule
    containing the expression 'ct helper tftp' which triggers the assert()
    call in mpz_get_type().
    
    Florian identified the cause: ct_expr_pctx_update() is called for the
    relational expression which calls mpz_get_uint32() to get RHS value
    (assuming it is a protocol number). On big-endian systems, the
    misinterpreted value exceeds UINT_MAX.
    
    Expressions' pctx_update() callback should only be called for protocol
    matches, so ct_meta_common_postprocess() lacked a check for 'left->flags
    & EXPR_F_PROTOCOL' like the one already present in
    payload_expr_pctx_update().
    
    In order to fix this in a clean way, this patch introduces a wrapper
    relational_expr_pctx_update() to be used instead of directly calling
    LHS's pctx_update() callback which unifies the necessary checks (and
    adds one more assert):
    
    - assert(expr->ops->type == EXPR_RELATIONAL)
      -> This is new, just to ensure the wrapper is called properly.
    - assert(expr->op == OP_EQ)
      -> This was moved from {ct,meta,payload}_expr_pctx_update().
    - left->ops->pctx_update != NULL
      -> This was taken from expr_evaluate_relational(), a necessary
         requirement for the introduced wrapper to function at all.
    - (left->flags & EXPR_F_PROTOCOL) != 0
      -> The crucial missing check which led to the problem.
    
    Suggested-by: Florian Westphal <fw>
    Signed-off-by: Phil Sutter <phil>
    Signed-off-by: Florian Westphal <fw>

Comment 7 Phil Sutter 2017-12-13 12:45:19 UTC
Hi Li Shuang,

Same question here: Would you be able to help in testing for this ticket? I think a crash fix would justify late addon into RHEL7.5.

Thanks, Phil

Comment 8 Li Shuang 2017-12-14 01:01:55 UTC
(In reply to Phil Sutter from comment #7)
> Hi Li Shuang,
> 
> Same question here: Would you be able to help in testing for this ticket? I
> think a crash fix would justify late addon into RHEL7.5.

Sure. My tests could cover this, and I took this one.

Comment 17 errata-xmlrpc 2018-04-10 16:09:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0882


Note You need to log in before you can comment on or make changes to this bug.