Package Name: python-murano-tests-tempest Package Description: Tempest plugin for the murano project. Package URL: https://github.com/openstack/murano-tempest-plugin.git RDO Username: karelyatin
license check: [chkumar246@ironfist murano-tempest-plugin]$ licensecheck -r . ./.coveragerc: *No copyright* UNKNOWN ./.gitreview: *No copyright* UNKNOWN ./.mailmap: *No copyright* UNKNOWN ./.testr.conf: *No copyright* UNKNOWN ./CONTRIBUTING.rst: *No copyright* UNKNOWN ./HACKING.rst: *No copyright* UNKNOWN ./LICENSE: *No copyright* Apache (v2.0) ./README.rst: *No copyright* UNKNOWN ./babel.cfg: *No copyright* UNKNOWN ./requirements.txt: *No copyright* UNKNOWN ./setup.cfg: *No copyright* Apache ./setup.py: Apache (v2.0) GENERATED FILE ./test-requirements.txt: *No copyright* UNKNOWN ./tox.ini: *No copyright* UNKNOWN ./murano_tempest_tests/clients.py: Apache (v2.0) ./murano_tempest_tests/config.py: Apache (v2.0) ./murano_tempest_tests/plugin.py: Apache (v2.0) ./murano_tempest_tests/utils.py: Apache (v2.0) ./doc/source/conf.py: *No copyright* Apache (v2.0) ./doc/source/index.rst: *No copyright* UNKNOWN ./doc/source/readme.rst: *No copyright* UNKNOWN ./releasenotes/source/conf.py: *No copyright* Apache (v2.0) GENERATED FILE ./releasenotes/source/index.rst: *No copyright* UNKNOWN ./releasenotes/source/unreleased.rst: *No copyright* UNKNOWN ./doc/source/admin/index.rst: *No copyright* UNKNOWN ./doc/source/cli/index.rst: *No copyright* UNKNOWN ./doc/source/configuration/index.rst: *No copyright* UNKNOWN ./doc/source/contributor/contributing.rst: *No copyright* UNKNOWN ./doc/source/contributor/index.rst: *No copyright* UNKNOWN ./doc/source/install/common_configure.rst: *No copyright* UNKNOWN ./doc/source/install/common_prerequisites.rst: *No copyright* UNKNOWN ./doc/source/install/get_started.rst: *No copyright* UNKNOWN ./doc/source/install/index.rst: *No copyright* UNKNOWN ./doc/source/install/install-obs.rst: *No copyright* UNKNOWN ./doc/source/install/install-rdo.rst: *No copyright* UNKNOWN ./doc/source/install/install-ubuntu.rst: *No copyright* UNKNOWN ./doc/source/install/install.rst: *No copyright* UNKNOWN ./doc/source/install/next-steps.rst: *No copyright* UNKNOWN ./doc/source/install/verify.rst: *No copyright* UNKNOWN ./doc/source/library/index.rst: *No copyright* UNKNOWN ./doc/source/reference/index.rst: *No copyright* UNKNOWN ./doc/source/user/index.rst: *No copyright* UNKNOWN ./murano_tempest_tests/extras/MockApp/logo.png: UNKNOWN ./murano_tempest_tests/extras/io.murano.apps.test.ApacheHttpServerCustom/manifest.yaml: *No copyright* Apache (v2.0) ./murano_tempest_tests/extras/io.murano.apps.test.Lighttpd/manifest.yaml: *No copyright* Apache (v2.0) ./murano_tempest_tests/extras/io.murano.apps.test.UpdateExecutor/manifest.yaml: *No copyright* Apache (v2.0) ./murano_tempest_tests/extras/io.murano.apps.test.VM/manifest.yaml: *No copyright* Apache (v2.0) ./murano_tempest_tests/services/application_catalog/application_catalog_client.py: Apache (v2.0) ./murano_tempest_tests/services/artifacts/artifacts_client.py: Apache (v2.0) ./murano_tempest_tests/services/service_broker/service_broker_client.py: Apache (v2.0) ./murano_tempest_tests/extras/MockApp/Classes/mock_muranopl.yaml: *No copyright* UNKNOWN ./murano_tempest_tests/extras/MockApp/UI/ui.yaml: *No copyright* Apache (v2.0) ./murano_tempest_tests/extras/io.murano.apps.test.ApacheHttpServerCustom/Classes/ApacheHttpServer.yaml: *No copyright* Apache (v2.0) ./murano_tempest_tests/extras/io.murano.apps.test.ApacheHttpServerCustom/Resources/index.html: *No copyright* UNKNOWN ./murano_tempest_tests/extras/io.murano.apps.test.Lighttpd/Classes/Lighttpd.yaml: *No copyright* Apache (v2.0) ./murano_tempest_tests/extras/io.murano.apps.test.Lighttpd/Resources/DeployLighttpd.template: *No copyright* Apache (v2.0) ./murano_tempest_tests/extras/io.murano.apps.test.UpdateExecutor/Classes/UpdateExecutor.yaml: *No copyright* Apache (v2.0) ./murano_tempest_tests/extras/io.murano.apps.test.VM/Classes/VM.yaml: *No copyright* Apache (v2.0) ./murano_tempest_tests/extras/io.murano.apps.test.VM/Resources/index.html: *No copyright* UNKNOWN ./murano_tempest_tests/tests/api/application_catalog/base.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_categories.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_categories_negative.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_deployments.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_env_templates.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_env_templates_negative.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_environments.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_environments_negative.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_repository.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_repository_negative.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_services.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_services_negative.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_sessions.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_sessions_negative.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_static_actions.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/test_static_actions_negative.py: Apache (v2.0) ./murano_tempest_tests/tests/api/service_broker/base.py: Apache (v2.0) ./murano_tempest_tests/tests/api/service_broker/test_service_broker_actions.py: Apache (v2.0) ./murano_tempest_tests/tests/api/service_broker/test_service_broker_negative.py: Apache (v2.0) ./murano_tempest_tests/tests/scenario/application_catalog/base.py: Apache (v2.0) ./murano_tempest_tests/tests/scenario/application_catalog/test_cinder_volumes.py: Apache (v2.0) ./murano_tempest_tests/tests/scenario/application_catalog/test_deployment.py: Apache (v2.0) ./murano_tempest_tests/tests/scenario/application_catalog/test_security_groups.py: *No copyright* Apache (v2.0) ./murano_tempest_tests/extras/io.murano.apps.test.Lighttpd/Resources/scripts/deployLighttpd.sh: *No copyright* Apache (v2.0) ./murano_tempest_tests/extras/io.murano.apps.test.UpdateExecutor/Resources/scripts/update.sh: *No copyright* Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/artifacts/base.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/artifacts/test_repository.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/artifacts/test_versioning.py: Apache (v2.0) ./murano_tempest_tests/tests/api/application_catalog/artifacts/test_versioning_negative.py: Apache (v2.0) It's a valid Apache v2.0 license
SRPM to use https://logs.rdoproject.org/56/10856/3/check/DLRN-rpmbuild/Zd7601c7ed5f34148a547712d5a2a2369/centos/current/python-murano-tests-tempest-0.0.1-0.20171207123435.fe0ce2f.el7.centos.src.rpm
The package looks sane hence approving the package. The package is approved now. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or generated", "*No copyright* Apache (v2.0)". 47 files have unknown license. Detailed output of licensecheck in /home/chkumar246/arena/rdo_projects/package_review/python-murano- tests-tempest/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -murano-tests-tempest , python-murano-tests-tempest-doc , python3 -murano-tests-tempest [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define upstream_version 0.0.1.dev141 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python2-murano-tests-tempest-0.0.1-0.20171207123435.fe0ce2f.fc28.noarch.rpm python-murano-tests-tempest-doc-0.0.1-0.20171207123435.fe0ce2f.fc28.noarch.rpm python3-murano-tests-tempest-0.0.1-0.20171207123435.fe0ce2f.fc28.noarch.rpm python-murano-tests-tempest-0.0.1-0.20171207123435.fe0ce2f.fc28.src.rpm python2-murano-tests-tempest.noarch: E: description-line-too-long C Additionally it provides a plugin to automatically load these tests into Tempest. python2-murano-tests-tempest.noarch: E: no-changelogname-tag python-murano-tests-tempest-doc.noarch: W: summary-not-capitalized C python-murano-tests-tempest documentation python-murano-tests-tempest-doc.noarch: E: no-changelogname-tag python-murano-tests-tempest-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-murano-tests-tempest-doc/html/objects.inv python-murano-tests-tempest-doc.noarch: W: file-not-utf8 /usr/share/doc/python-murano-tests-tempest-doc/html/objects.inv python3-murano-tests-tempest.noarch: W: summary-not-capitalized C python-murano-tests-tempest documentation python3-murano-tests-tempest.noarch: E: description-line-too-long C Additionally it provides a plugin to automatically load these tests into Tempest. python3-murano-tests-tempest.noarch: E: no-changelogname-tag python-murano-tests-tempest.src: E: description-line-too-long C Additionally it provides a plugin to automatically load these tests into Tempest. python-murano-tests-tempest.src: E: no-changelogname-tag python-murano-tests-tempest.src: W: invalid-url Source0: murano-tempest-plugin-0.0.1.dev141-0.20171207123435.fe0ce2f.tar.gz 4 packages and 0 specfiles checked; 7 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- python2-murano-tests-tempest.noarch: E: description-line-too-long C Additionally it provides a plugin to automatically load these tests into Tempest. python2-murano-tests-tempest.noarch: E: no-changelogname-tag python2-murano-tests-tempest.noarch: W: invalid-url URL: https://git.openstack.org/cgit/openstack/murano-tempest-plugin/ <urlopen error [Errno -2] Name or service not known> python-murano-tests-tempest-doc.noarch: W: summary-not-capitalized C python-murano-tests-tempest documentation python-murano-tests-tempest-doc.noarch: E: no-changelogname-tag python-murano-tests-tempest-doc.noarch: W: invalid-url URL: https://git.openstack.org/cgit/openstack/murano-tempest-plugin/ <urlopen error [Errno -2] Name or service not known> python-murano-tests-tempest-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-murano-tests-tempest-doc/html/objects.inv python-murano-tests-tempest-doc.noarch: W: file-not-utf8 /usr/share/doc/python-murano-tests-tempest-doc/html/objects.inv python3-murano-tests-tempest.noarch: W: summary-not-capitalized C python-murano-tests-tempest documentation python3-murano-tests-tempest.noarch: E: description-line-too-long C Additionally it provides a plugin to automatically load these tests into Tempest. python3-murano-tests-tempest.noarch: E: no-changelogname-tag python3-murano-tests-tempest.noarch: W: invalid-url URL: https://git.openstack.org/cgit/openstack/murano-tempest-plugin/ <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 5 errors, 7 warnings. Requires -------- python2-murano-tests-tempest (rpmlib, GLIBC filtered): python(abi) python-oslo-config python-oslo-serialization python-oslo-utils python-pbr python-six python-tempest python-testtools python-murano-tests-tempest-doc (rpmlib, GLIBC filtered): python3-murano-tests-tempest (rpmlib, GLIBC filtered): python(abi) python3-oslo-config python3-oslo-serialization python3-oslo-utils python3-pbr python3-six python3-tempest python3-testtools Provides -------- python2-murano-tests-tempest: python-murano-tests-tempest python2-murano-tests-tempest python2.7dist(murano-tempest-plugin) python2dist(murano-tempest-plugin) python-murano-tests-tempest-doc: python-murano-tests-tempest-doc python3-murano-tests-tempest: python3-murano-tests-tempest python3.6dist(murano-tempest-plugin) python3dist(murano-tempest-plugin) Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m dlrn-master -r -b 1523058 Buildroot used: dlrn-fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package is imported in RDO Here is the dist-git link with spec: https://github.com/rdo-packages/murano-tempest-plugin-distgit/commit/84f7116bf602d4ccb4ad9ae35b575c625d0bae8e and srpm from trunk.rdoproject.org: https://trunk.rdoproject.org/centos7-master/current/python-murano-tests-tempest-0.0.1-0.20171211121316.64f763a.el7.centos.src.rpm