Bug 1523407 - Please upgrade python-django-filter to 1.0.2
Summary: Please upgrade python-django-filter to 1.0.2
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-django-filter
Version: 27
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-07 22:02 UTC by Ralf Baechle
Modified: 2017-12-19 21:56 UTC (History)
4 users (show)

Fixed In Version: python-django-filter-1.0.2-1.fc28 python-django-filter-1.0.2-1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-19 19:47:55 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github carltongibson django-filter issues 673 0 None None None 2017-12-07 22:02:45 UTC

Description Ralf Baechle 2017-12-07 22:02:46 UTC
Description of problem:
The patchtracking system patchwork (not part of Fedora but extremly important for the kernel community, for example) fails as follows with today's (2017-12-07) F27:

# PYTHONPATH=/var/www/patchwork python patchwork/wsgi.py
Traceback (most recent call last):
  File "patchwork/wsgi.py", line 30, in <module>
    application = get_wsgi_application()
  File "/usr/lib/python2.7/site-packages/django/core/wsgi.py", line 13, in get_wsgi_application
    django.setup(set_prefix=False)
  File "/usr/lib/python2.7/site-packages/django/__init__.py", line 27, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/usr/lib/python2.7/site-packages/django/apps/registry.py", line 85, in populate
    app_config = AppConfig.create(entry)
  File "/usr/lib/python2.7/site-packages/django/apps/config.py", line 94, in create
    module = import_module(entry)
  File "/usr/lib64/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/usr/lib/python2.7/site-packages/django_filters/__init__.py", line 4, in <module>
    from .filterset import FilterSet
  File "/usr/lib/python2.7/site-packages/django_filters/filterset.py", line 17, in <module>
    from .filters import (Filter, CharFilter, BooleanFilter, BaseInFilter, BaseRangeFilter,
  File "/usr/lib/python2.7/site-packages/django_filters/filters.py", line 17, in <module>
    from .fields import (
  File "/usr/lib/python2.7/site-packages/django_filters/fields.py", line 14, in <module>
    from .widgets import RangeWidget, LookupTypeWidget, CSVWidget, BaseCSVWidget
  File "/usr/lib/python2.7/site-packages/django_filters/widgets.py", line 13, in <module>
    from django.forms.widgets import flatatt
ImportError: cannot import name flatatt

Patchwork is just an example triggering this django-filter issue and how I discovered it; other django-filter users should trigger it as well.

Version-Release number of selected component (if applicable):
python-django-filter-1.0.1-2.fc26.

How reproducible:
Always

Steps to Reproduce:
1. Install patchwork and support packages (Apache, Mysql etc.)
2. Run patchwork like PYTHONPATH=/var/www/patchwork python patchwork/wsgi.py
3.

Actual results:
Fails as above.

Expected results:
Patchwork executes normally.

Additional info:
There is an django-filter upstream bug in https://github.com/carltongibson/django-filter/issues/673 which is resolved with the recommendation of upgrading to 1.0.2.

Since it's easy I've locally built a 1.0.2 package which solves this issue for me.  It's reasonably straight forward as only the tarball needs to be upgraded and the patch used by the python-django-filter-1.0.1-2.fc26 package needs to be upgraded; the one patch applied on top is obsoleted by 1.0.2.

The 1.0.2 tarball can be downloaded directly from https://pypi.python.org/packages/33/5d/86a3d783f337cadc9ad52d43817b63a9d2f088cf85aec62b1ef766b943f2/django-filter-1.0.2.tar.gz (very cute URL, I know ...) or from https://pypi.python.org/simple/django-filter/

Comment 1 Miro Hrončok 2017-12-08 17:38:14 UTC
There is a open PR for updating to 1.0.2 and dropping python2 support for rawhide. I will split it and backport the 1.0.2 part to Fedora 27.

BTW Is using Python 3 an option for you? Fedora will eventually (soon) update to Django 2 and that does not support Legacy Python any more.

Comment 2 Fedora Update System 2017-12-08 17:52:03 UTC
python-django-filter-1.0.2-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d905a2caff

Comment 3 Fedora Update System 2017-12-10 00:33:46 UTC
python-django-filter-1.0.2-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d905a2caff

Comment 4 Fedora Update System 2017-12-19 19:47:55 UTC
python-django-filter-1.0.2-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 5 Ralf Baechle 2017-12-19 21:56:22 UTC
I've tested the new package and this solves my issues.

Thanks!


Note You need to log in before you can comment on or make changes to this bug.