Bug 1524123 - Improper error message in vdsm-tool ovn-config
Summary: Improper error message in vdsm-tool ovn-config
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-provider-ovn
Classification: oVirt
Component: driver
Version: 1.2.1
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-4.2.1
: ---
Assignee: Marcin Mirecki
QA Contact: Mor
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-10 09:04 UTC by Mor
Modified: 2018-02-12 11:46 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-02-12 11:46:41 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 85385 0 master MERGED vdsm-tool ovn-config must state required number of args in case of missing args 2017-12-14 15:45:41 UTC

Description Mor 2017-12-10 09:04:26 UTC
Description of problem:
"vdsm-tool ovn-config" command on OVN host outputs improper error message.

Version-Release number of selected component (if applicable):
vdsm-4.20.9-1.el7ev.x86_64
ovirt-provider-ovn-driver-1.2.1-1.el7ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. On OVN host, run vdsm-tool ovn-config (without extra args).

Actual results:
"Error:  Command does not take extra argument"

Expected results:
"Command takes exactly 1 argument" or "Command requires extra arguments"

Additional info:
 ovn-config
usage: 
 /usr/bin/vdsm-tool [options] ovn-config IP-central [tunneling-IP|tunneling-network]
    Configures the ovn-controller on the host.

    Parameters:
    IP-central - the IP of the engine (the host where OVN central is located)
    tunneling-IP - the local IP which is to be used for OVN tunneling
    tunneling-network - the vdsm network name which is to be used for OVN tunneling

Comment 1 Mor 2017-12-10 10:01:56 UTC
* 2 arguments to be precise

Comment 2 Marcin Mirecki 2018-01-03 11:58:34 UTC
Fixed in  1.2.3

Comment 3 Mor 2018-01-07 08:21:22 UTC
# vdsm-tool ovn-config
Error:  Command takes exactly 3 arguments

ovn-config IP-central [tunneling-IP|tunneling-network]
ovn-config requires two parameters (one is optional)?

Comment 4 Mor 2018-01-07 11:33:52 UTC
* one is option of two.

Comment 5 Mor 2018-01-14 10:15:52 UTC
Verified on:
ovirt-provider-ovn-driver-1.2.4-1.el7ev.noarch
RHV 4.2.1.1-0.1.el7

Comment 6 Sandro Bonazzola 2018-02-12 11:46:41 UTC
This bugzilla is included in oVirt 4.2.1 release, published on Feb 12th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.