Bug 1524192 - [RFE] Define %{dist} as %{?distprefix}.fc#
Summary: [RFE] Define %{dist} as %{?distprefix}.fc#
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-release
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dennis Gilmore
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-10 16:33 UTC by Nicolas Mailhot
Modified: 2018-06-22 23:24 UTC (History)
11 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2018-02-02 00:13:03 UTC


Attachments (Terms of Use)

Description Nicolas Mailhot 2017-12-10 16:33:43 UTC
fedora-release should define %dist as

%dist %{?distprefix}.fc#

in /usr/lib/rpm/macros.d/macros.dist

This way other macros could compute a dist prefix without clobbering dist itself

An example of complex dist prefix is the one Fedora Packaging guidelines require for snapshots in:
https://fedoraproject.org/wiki/Packaging:Versioning#More_complex_versioning

An snapshot automation macro is proposed in
https://fedoraproject.org/wiki/Forge-hosted_projects_packaging_automation

Right now it has to redefine %{dist} in a non-reversible way

Comment 1 Jason Tibbitts 2018-01-12 00:57:11 UTC
For the record, I agree with this.  I've run into the problem this solves a couple of times in my macro experiments.

Is there any reason we can't just do this?  It's a trivial one-line tweak to the spec, though there's also a spec in the upstream repository and so I'm not entirely sure where this change would happen.

Comment 2 Kevin Fenzi 2018-01-19 19:24:28 UTC
I'm fine with this too, can someone submit a PR to fedora-release upstream doing this? It not I can try and do so sometime...

Comment 4 Kevin Fenzi 2018-02-02 00:13:03 UTC
Done and just built in rawhide. Should show up in tomorrow's compose.


Note You need to log in before you can comment on or make changes to this bug.