Bug 1524368 - openStack public tenant image visibility
Summary: openStack public tenant image visibility
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.10.0
Assignee: Alexander Demicev
QA Contact: Ido Ovadia
URL:
Whiteboard:
: 1546539 (view as bug list)
Depends On:
Blocks: 1598520
TreeView+ depends on / blocked
 
Reported: 2017-12-11 10:59 UTC by Gellert Kis
Modified: 2021-12-10 15:29 UTC (History)
20 users (show)

Fixed In Version: 5.10.0.31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1598520 (view as bug list)
Environment:
5.8
Last Closed: 2019-02-11 14:02:14 UTC
Category: Bug
Cloudforms Team: Openstack
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 5 Gellert Kis 2018-01-05 11:10:38 UTC
Hi,

Any news on this ? Do you see TenantName(summary) page ,shows number of all images in your setup ?

Comment 6 Alexander Demicev 2018-01-05 12:37:00 UTC
Hi, 
We were unable to reproduce bug on OSP12, yes, summary page shows number of all images and in images detail view I can see public images from all tenants.

Comment 7 Gellert Kis 2018-01-05 14:53:06 UTC
It might be different in OSP8 . There in detail view public images are not visible from other tenants belong to other user. 

One more possibility : 
In your setup the public images are belong to another OSP user ? Or the same OSP user authenticated in cloudforms provider ?
Must be owned by other user , not the same. 

In our setup the public images for other OSP users are missing in detail .

Comment 8 Gellert Kis 2018-01-05 14:57:38 UTC
One more important point is that OSP user authenticated at provider page in CF , in NOT admin . but regular OSP user having tenants.

Comment 9 Alexander Demicev 2018-01-08 12:08:24 UTC
Hi, OSP user authenticated at provider page is not admin, and I can see public images, that belong to other tenant. I get the same output from openstack cli.

Comment 29 Asad Rao 2018-05-04 11:17:34 UTC
Hi Engineers,
This issue was reported by me at support case to Neha Chugh,
I want to say that, the issue is only raised when we bound the user to specific tenant in cloudforms using RBAC.
When we just add a single tenant in cloudforms it shows all the respective images which are visible for that project in OSP too.
And we are using OSP10.

Comment 30 Asad Rao 2018-05-05 09:48:57 UTC
(In reply to Gellert Kis from comment #8)
> One more important point is that OSP user authenticated at provider page in
> CF , in NOT admin . but regular OSP user having tenants.

Hey! Did the team figure out the real cause of the bug ?

Comment 31 Gellert Kis 2018-05-07 06:53:16 UTC
Hi Asad, 

Thank you for your comment, we have same observation. 
Cause is inside how internally code works in cloudForms , you can find more explanation with details at https://github.com/ManageIQ/manageiq/pull/17058 .

Please prefer a comment in support case for future request , as we are not allowed sharing public comment on bugzilla with customer related information.

Thanks, and Kind Regards,
Gellert

Comment 32 Neha Chugh 2018-06-04 12:52:08 UTC
Hello Omri,

Customer is looking for the solution since a month, though the patches are not verified so we cannot provide the suggested patch to the customer for implementation purpose.

Can you please verify the patch and accordingly update the BZ so to make progress in the  case.

Thanks and Regards,
Neha Chugh

Comment 38 Alexander Demicev 2018-07-03 09:45:47 UTC
PR was merged
https://github.com/ManageIQ/manageiq/pull/17058

Comment 41 Jad Haj Yahya 2018-07-09 09:00:18 UTC
tested on 5.10.0.3

Public Image appears on Tenenat2 summary page but still missing on Tenant2 (All Images) page

Also image is not for instance provisioning

Comment 43 Alexander Demicev 2018-10-10 08:34:35 UTC
*** Bug 1546539 has been marked as a duplicate of this bug. ***

Comment 45 CFME Bot 2018-10-11 14:02:24 UTC
New commit detected on ManageIQ/manageiq/hammer:

https://github.com/ManageIQ/manageiq/commit/15058e549987cba58b342ba3d675719093212ffe
commit 15058e549987cba58b342ba3d675719093212ffe
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Wed Oct 10 14:08:21 2018 -0400
Commit:     Gregg Tanzillo <gtanzill>
CommitDate: Wed Oct 10 14:08:21 2018 -0400

    Merge pull request #17851 from alexander-demichev/named-scopes-templates

    Add tenant filtering for templates in provisioning and summary pages

    (cherry picked from commit 142a184d4619fd9d3ecebb6cff71ccd13667832e)

    https://bugzilla.redhat.com/show_bug.cgi?id=1524368

 app/models/manageiq/providers/cloud_manager/template.rb | 8 +-
 spec/lib/rbac/filterer_spec.rb | 78 +-
 spec/models/manageiq/providers/cloud_manager/template_spec.rb | 9 +-
 3 files changed, 75 insertions(+), 20 deletions(-)

Comment 46 Satoe Imaishi 2018-10-25 14:03:03 UTC
https://github.com/ManageIQ/manageiq/pull/18128

Comment 50 CFME Bot 2018-12-19 17:25:50 UTC
New commit detected on ManageIQ/manageiq/hammer:

https://github.com/ManageIQ/manageiq/commit/297b4f701e85b8431e5175273dbc4a9e3b676ce6
commit 297b4f701e85b8431e5175273dbc4a9e3b676ce6
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Tue Dec 18 11:58:25 2018 -0500
Commit:     Gregg Tanzillo <gtanzill>
CommitDate: Tue Dec 18 11:58:25 2018 -0500

    Merge pull request #18128 from alexander-demichev/fix-rbac-for-templates

    Fix RBAC call for templates and vms

    (cherry picked from commit cd982a488b48a189e4aabf2f1a21ae7007dda5fb)

    https://bugzilla.redhat.com/show_bug.cgi?id=1524368

 app/models/manageiq/providers/cloud_manager/template.rb | 11 -
 app/models/vm_or_template.rb | 16 +-
 spec/factories/vm_or_template.rb | 4 +
 spec/lib/rbac/filterer_spec.rb | 74 +-
 spec/models/manageiq/providers/cloud_manager/template_spec.rb | 28 -
 spec/models/manageiq/providers/cloud_manager/vm_or_template_spec.rb | 28 +
 spec/models/mixins/cloud_tenancy_mixin_spec.rb | 2 +-
 7 files changed, 105 insertions(+), 58 deletions(-)

Comment 51 Jad Haj Yahya 2019-01-16 08:30:38 UTC
Verified on 5.10.0.31


Note You need to log in before you can comment on or make changes to this bug.