Bug 1524700 - AttributeError: 'NoneType' object has no attribute 'name'
Summary: AttributeError: 'NoneType' object has no attribute 'name'
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 28
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedBlocker abrt_hash:3d9ef2908c6...
: 1529645 1531946 1533301 1534024 1534026 1536785 (view as bug list)
Depends On:
Blocks: F28BetaBlocker
TreeView+ depends on / blocked
 
Reported: 2017-12-11 21:20 UTC by satellitgo
Modified: 2018-04-20 18:14 UTC (History)
30 users (show)

Fixed In Version: anaconda-28.22.2-2 anaconda-28.22.2-3.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-06 19:37:55 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: anaconda-tb (861.98 KB, text/plain)
2017-12-11 21:20 UTC, satellitgo
no flags Details
File: anaconda.log (11.53 KB, text/plain)
2017-12-11 21:20 UTC, satellitgo
no flags Details
File: environ (521 bytes, text/plain)
2017-12-11 21:20 UTC, satellitgo
no flags Details
File: journalctl (428.89 KB, text/plain)
2017-12-11 21:20 UTC, satellitgo
no flags Details
File: lsblk_output (2.46 KB, text/plain)
2017-12-11 21:20 UTC, satellitgo
no flags Details
File: lvm.log (248.75 KB, text/plain)
2017-12-11 21:20 UTC, satellitgo
no flags Details
File: nmcli_dev_list (2.09 KB, text/plain)
2017-12-11 21:20 UTC, satellitgo
no flags Details
File: os_info (529 bytes, text/plain)
2017-12-11 21:20 UTC, satellitgo
no flags Details
File: program.log (58.62 KB, text/plain)
2017-12-11 21:20 UTC, satellitgo
no flags Details
File: storage.log (172.75 KB, text/plain)
2017-12-11 21:20 UTC, satellitgo
no flags Details
File: ifcfg.log (13.69 KB, text/plain)
2017-12-11 21:20 UTC, satellitgo
no flags Details
anaconda tb (554.79 KB, text/plain)
2018-01-18 22:23 UTC, Chris Murphy
no flags Details

Description satellitgo 2017-12-11 21:20:10 UTC
Description of problem:
try to use mediawriter usb with f28 Rawhide 20171210.n2 live soas to do a liveinst
bios boot.  failed t do a restore disk wih usb harddisk with existing install of f27 rawhide wks

Version-Release number of selected component:
anaconda-core-28.12-1.fc28.x86_64

The following was filed automatically by anaconda:
anaconda 28.12-1 exception report
Traceback (most recent call first):
  File "/usr/lib64/python3.6/site-packages/pyanaconda/storage/osinstall.py", line 1700, in _mark_protected_device
    if device.name in self.protected_dev_names:
  File "/usr/lib/python3.6/site-packages/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/usr/lib64/python3.6/site-packages/pyanaconda/storage/osinstall.py", line 1662, in reset
    self._mark_protected_device(dev)
  File "/usr/lib/python3.6/site-packages/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/usr/lib64/python3.6/site-packages/pyanaconda/storage/osinstall.py", line 2158, in storage_initialize
    storage.reset()
  File "/usr/lib64/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib64/python3.6/site-packages/pyanaconda/threading.py", line 252, in run
    threading.Thread.run(self)
AttributeError: 'NoneType' object has no attribute 'name'

Additional info:
addons:         com_redhat_kdump
blivet-gui-utils.log: 
cmdline:        /usr/bin/python3  /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base
cmdline_file:   BOOT_IMAGE=vmlinuz initrd=initrd.img root=live:CDLABEL=Fedora-SoaS-Live-Rawhide-2017121 rd.live.image quiet
executable:     /sbin/anaconda
hashmarkername: anaconda
kernel:         4.15.0-0.rc2.git2.1.fc28.x86_64
other involved packages: python3-libs-3.6.3-4.fc28.x86_64, python3-blivet-3.0.0-0.1.b1.fc28.noarch
product:        Fedora
release:        Fedora release 28 (Rawhide)
type:           anaconda
version:        rawhide

Comment 1 satellitgo 2017-12-11 21:20:17 UTC
Created attachment 1366295 [details]
File: anaconda-tb

Comment 2 satellitgo 2017-12-11 21:20:19 UTC
Created attachment 1366296 [details]
File: anaconda.log

Comment 3 satellitgo 2017-12-11 21:20:20 UTC
Created attachment 1366298 [details]
File: environ

Comment 4 satellitgo 2017-12-11 21:20:22 UTC
Created attachment 1366299 [details]
File: journalctl

Comment 5 satellitgo 2017-12-11 21:20:23 UTC
Created attachment 1366300 [details]
File: lsblk_output

Comment 6 satellitgo 2017-12-11 21:20:25 UTC
Created attachment 1366301 [details]
File: lvm.log

Comment 7 satellitgo 2017-12-11 21:20:26 UTC
Created attachment 1366302 [details]
File: nmcli_dev_list

Comment 8 satellitgo 2017-12-11 21:20:28 UTC
Created attachment 1366303 [details]
File: os_info

Comment 9 satellitgo 2017-12-11 21:20:29 UTC
Created attachment 1366304 [details]
File: program.log

Comment 10 satellitgo 2017-12-11 21:20:31 UTC
Created attachment 1366305 [details]
File: storage.log

Comment 11 satellitgo 2017-12-11 21:20:33 UTC
Created attachment 1366306 [details]
File: ifcfg.log

Comment 12 Felixb 2017-12-29 05:05:43 UTC
*** Bug 1529645 has been marked as a duplicate of this bug. ***

Comment 13 ng0177 2018-01-06 19:16:34 UTC
*** Bug 1531946 has been marked as a duplicate of this bug. ***

Comment 14 Hayden 2018-01-12 20:36:42 UTC
*** Bug 1534024 has been marked as a duplicate of this bug. ***

Comment 15 Hayden 2018-01-12 20:45:37 UTC
*** Bug 1534026 has been marked as a duplicate of this bug. ***

Comment 16 Chris Murphy 2018-01-18 22:04:07 UTC
Similar problem has been detected:

1. Launch
2. Language screen, continue
3. Main hub appears, then crash before clicking on anything else

addons:         com_redhat_kdump
blivet-gui-utils.log: 
cmdline:        /usr/bin/python3  /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base
cmdline_file:   BOOT_IMAGE=/images/pxeboot/vmlinuz root=live:CDLABEL=Fedora-WS-Live-Rawhide-20180117- rd.live.image quiet
hashmarkername: anaconda
kernel:         4.15.0-0.rc8.git0.1.fc28.x86_64
other involved packages: python3-libs-3.6.4-3.fc28.x86_64, python3-blivet-3.0.0-0.1.b1.fc28.noarch
package:        anaconda-core-28.17-1.fc28.x86_64
packaging.log:  
product:        Fedora
reason:         AttributeError: 'NoneType' object has no attribute 'name'
release:        Fedora release 28 (Rawhide)
version:        rawhide

Comment 17 Fedora Blocker Bugs Application 2018-01-18 22:19:39 UTC
Proposed as a Blocker for 28-beta by Fedora user chrismurphy using the blocker tracking app because:

 Always crashes shortly after launch, either at the language select screen or the hub.
a.
Reject or disallow invalid disk and volume configurations without crashing.
b.
 Bug hinders execution of required Beta test plans or dramatically reduces test coverage

Comment 18 Chris Murphy 2018-01-18 22:22:31 UTC
USB stick media made from Fedora-Workstation-Live-x86_64-Rawhide-20180117.n.1.iso

Still a bug with anaconda-28.17-1.fc28.x86_64. Always crashes, 100% reproducible.

Comment 19 Chris Murphy 2018-01-18 22:23:19 UTC
Created attachment 1383068 [details]
anaconda tb

Comment 20 ng0177 2018-01-21 07:11:24 UTC
*** Bug 1536785 has been marked as a duplicate of this bug. ***

Comment 21 Jiri Konecny 2018-01-22 10:08:56 UTC
Hello,

This bug is happening because of the `_find_live_backing_device` method which was migrated from blivet recently. It is adding device with liveinst (USB stick) to the protected dev array but this device can't be found by Blivet.

If I skip that call to avoid raising the exception then the liveinst USB stick can be used for installation.

We need to find a solution to avoid the crash but do not add the USB stick to the devices for installation. Maybe Blivet needs to understand that device and return it correctly when `get_device_by_name` is called?

Comment 22 Vojtech Trefny 2018-01-22 14:25:33 UTC
The problem is actually that blivet is not able to find partitions on the LiveUSB. Anaconda checks `/proc/mounts` to get "live" devices and asks blivet to ignore "sda1" and it is not in devicetree because blivet doesn't detect partitions on the sda drive.

Comment 23 Adam Williamson 2018-01-29 00:41:05 UTC
is there any need for the prior two comments to be private?

Comment 24 Kamil Páral 2018-01-29 12:36:42 UTC
Marking the comments public.

+1 blocker per "The installer must run when launched normally from the release-blocking images. "
https://fedoraproject.org/wiki/Basic_Release_Criteria#Installer_must_run

Comment 25 František Zatloukal 2018-01-29 12:37:42 UTC
+1 blocker

Comment 26 Lukas Brabec 2018-01-29 12:38:30 UTC
+1 blocker

Comment 27 Kamil Páral 2018-01-29 12:39:44 UTC
Marking as accepted blocker.

Comment 28 Alessio 2018-01-30 14:09:06 UTC
Similar problem has been detected:

Fedora Workstation Live on Macbook Pro

addons:         com_redhat_kdump
cmdline:        /usr/bin/python3  /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base
cmdline_file:   BOOT_IMAGE=/images/pxeboot/vmlinuz root=live:CDLABEL=Fedora-WS-Live-Rawhide-20180126- rd.live.image quiet
hashmarkername: anaconda
kernel:         4.15.0-0.rc9.git3.1.fc28.x86_64
other involved packages: python3-libs-3.6.4-9.fc28.x86_64, python3-blivet-3.0.0-0.1.b1.fc28.noarch
package:        anaconda-core-28.18-1.fc28.x86_64
packaging.log:  
product:        Fedora
reason:         AttributeError: 'NoneType' object has no attribute 'name'
release:        Fedora release 28 (Rawhide)
version:        rawhide

Comment 29 David Lehman 2018-02-14 18:48:44 UTC
In blivet-2.x mark_protected_device was only called after we had obtained a valid device while detecting existing devices. When adapting the code in preparation for moving it into anaconda, that code was moved into the InstallerStorage.reset method. There is nothing wrong with this, but there is also no guarantee that the protected device specs will resolve to actual devices. The code should reflect this by only trying to mark a device protected if a device object was found.

Comment 30 Fedora End Of Life 2018-02-20 15:34:38 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 31 Adam Williamson 2018-03-07 20:08:56 UTC
Ping? This is a Beta blocker, and we are now in Beta freeze. This needs to be fixed soon. Thanks.

Comment 32 David Lehman 2018-03-08 15:00:56 UTC
Blivet is not going to understand partitions on a device with an iso9660 filesystem on it. Putting a file system and multiple disklabels on the same block device is not something that can be represented sanely by a tree model. The solution is going to have to involve something along the lines of marking the disk protected in the case that the live device is a partition.

Comment 33 David Lehman 2018-03-08 16:47:54 UTC
Please try this updates image:

  https://fedorapeople.org/~dlehman/updates/1524700.0.img


It tries to determine the disk for live backing devices that are partitions and mark the disk as protected instead of the partition.

Comment 34 Adam Williamson 2018-03-08 18:41:32 UTC
That seems to work; the USB stick isn't shown as an available install target device, and the installer doesn't crash.

Comment 35 David Lehman 2018-03-08 23:18:44 UTC
Pull request: https://github.com/rhinstaller/anaconda/pull/1381

Comment 36 Chris Murphy 2018-03-10 05:48:20 UTC
Similar problem has been detected:

Fedora-Workstation-Live-x86_64-28-20180309.n.0.iso
Crash after choosing language, as hub draws, before choosing installation destination.

addons:         com_redhat_kdump
blivet-gui-utils.log: 
cmdline:        /usr/bin/python3  /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base
cmdline_file:   BOOT_IMAGE=/images/pxeboot/vmlinuz root=live:CDLABEL=Fedora-WS-Live-28-20180309-n-0 rd.live.image systemd.wants=sshd systemd.mask=alsa-state elevator=noop
hashmarkername: anaconda
kernel:         4.16.0-0.rc4.git0.1.fc28.x86_64
other involved packages: python3-libs-3.6.4-16.fc28.x86_64, python3-blivet-3.0.0-0.2.b1.fc28.noarch
package:        anaconda-core-28.22.2-1.fc28.x86_64
packaging.log:  
product:        Fedora
reason:         AttributeError: 'NoneType' object has no attribute 'name'
release:        Fedora release 28 (Twenty Eight)
version:        28

Comment 37 Chris Murphy 2018-03-10 08:49:03 UTC
Working for me with https://fedorapeople.org/~dlehman/updates/1524700.0.img

Comment 38 satellitgo 2018-03-10 22:04:23 UTC
Fedora-SoaS-Live-x86_64-28-20180309.n.0
28-22.2.1

1)-installs correctly to f27 QEMU/kvm user session

2)- fails to install with FMW USB to external USB HD
"No protocol specified"

screenshot attached to follow

Comment 40 satellitgo 2018-03-11 13:47:21 UTC
Fedora-Cinnamon-Live-x86_64-28-20180309.n.0.iso burned with f28 brasero to dvd-r
installs to external usb hard drive (after reclaim space - bios boot)
-very slow install

Comment 41 satellitgo 2018-03-11 22:18:34 UTC
Fedora-KDE-Live-x86_64-28-20180310.n.0.iso

1-)fails to install with FMW USB to external USB HD
"No protocol specified"

Comment 42 satellitgo 2018-03-11 23:42:36 UTC
Fedora-KDE-Live-x86_64-28-20180310.n.0.iso burned with f28 brasero to dvd-r
installs to external usb hard drive (after reclaim space - bios boot)
-very slow install

Comment 43 František Zatloukal 2018-03-12 13:03:14 UTC
Similar problem has been detected:

Anaconda crashes as soon as it' s launched from Workstation Live on Bare metal.

addons:         com_redhat_kdump
cmdline:        /usr/bin/python3  /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base
cmdline_file:   BOOT_IMAGE=/images/pxeboot/vmlinuz root=live:CDLABEL=Fedora-WS-Live-28-20180310-n-0 rd.live.image quiet
hashmarkername: anaconda
kernel:         4.16.0-0.rc4.git0.1.fc28.x86_64
other involved packages: python3-libs-3.6.4-16.fc28.x86_64, python3-blivet-3.0.0-0.2.b1.fc28.noarch
package:        anaconda-core-28.22.2-1.fc28.x86_64
packaging.log:  
product:        Fedora
reason:         AttributeError: 'NoneType' object has no attribute 'name'
release:        Fedora release 28 (Twenty Eight)
version:        28

Comment 44 Adam Williamson 2018-03-12 15:11:15 UTC
*** Bug 1533301 has been marked as a duplicate of this bug. ***

Comment 45 Fedora Update System 2018-03-12 17:37:22 UTC
anaconda-28.22.2-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b623ca92af

Comment 46 Fedora Update System 2018-03-13 15:09:09 UTC
anaconda-28.22.2-3.fc28, python-blivet-3.0.0-0.4.b1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-b623ca92af

Comment 47 František Zatloukal 2018-03-13 15:23:31 UTC
It's fixed in anaconda-28.22.2-3.fc28.

Comment 48 Fedora Update System 2018-03-14 01:51:01 UTC
anaconda-28.22.2-3.fc28, python-blivet-3.0.0-0.4.b1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 49 satellitgo 2018-03-28 21:19:47 UTC
*** Bug 1561766 has been marked as a duplicate of this bug. ***

Comment 50 satellitgo 2018-03-28 21:27:33 UTC
https://bugzilla.redhat.com/show_bug.cgi?id=1561766 has 
FMW failure for KDE Live KDE beta1.1

Comment 51 Adam Williamson 2018-03-28 21:48:02 UTC
I don't think that is really a dupe, if you had to hit 'rescan disks' to get to it. This bug is a blocker because all you had to do was run the installer. Hitting 'rescan disks' is not a blocker path.

Comment 52 Fedora Update System 2018-04-05 16:23:33 UTC
anaconda-28.22.3-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9fd9270cd5

Comment 53 Fedora Update System 2018-04-06 18:55:37 UTC
anaconda-28.22.3-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9fd9270cd5

Comment 54 Adam Williamson 2018-04-06 19:37:55 UTC
gah, stoppit, Bodhi.

Comment 55 John Reiser 2018-04-20 18:14:51 UTC
Similar problem has been detected:

UEFI boot on x86_64 from F28 beta Workstation Live on USB flash memory.
Run live system ("Try fedora") then choose "install to harddrive" icon.
Select both SSD (nvme0n1) and rotating (sda) for Custom partioning; both have GPT label.
Re-format existing nvme0n1p4 as ext4  for use as root partition (/).
Keep existing nvme0n1p3 (ext4, contains Fedora 27) as unmounted.
Re-use existing nvme0n1p1 (fat16, EFI-SP) as /boot/efi; do not reformat.
Re-use existing sda5 as /home.


addons:         com_redhat_kdump
blivet-gui-utils.log: 
cmdline:        /usr/bin/python3  /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base
cmdline_file:   BOOT_IMAGE=/images/pxeboot/vmlinuz root=live:CDLABEL=Fedora-WS-Live-28-20180415-n-0 rd.live.image rd.live.check quiet
hashmarkername: anaconda
kernel:         4.16.1-300.fc28.x86_64
other involved packages: python3-libs-3.6.5-1.fc28.x86_64, python3-blivet-3.0.0-0.6.1.b1.fc28.noarch
package:        anaconda-core-28.22.7-1.fc28.x86_64
packaging.log:  
product:        Fedora
reason:         AttributeError: 'NoneType' object has no attribute 'name'
release:        Fedora release 28 (Twenty Eight)
version:        28


Note You need to log in before you can comment on or make changes to this bug.