Bug 1524733 - Package review: ansible-role-redhat-subscription - Ansible role to configure RHSM for TripleO
Summary: Package review: ansible-role-redhat-subscription - Ansible role to configure ...
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: trunk
Hardware: All
OS: Linux
Target Milestone: ---
: trunk
Assignee: Javier Peña
QA Contact: hguemar
Depends On:
Blocks: RDO-QUEENS 1526506 1570207 1582321 1620134 1620143
TreeView+ depends on / blocked
Reported: 2017-12-11 22:25 UTC by Emilien Macchi
Modified: 2018-08-22 14:28 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1526506 (view as bug list)
Last Closed: 2018-01-09 14:13:42 UTC
jpena: rdo-review+

Attachments (Terms of Use)
spec file (1.10 KB, text/x-matlab)
2017-12-11 22:32 UTC, Emilien Macchi
no flags Details
spec file (1.10 KB, text/x-matlab)
2017-12-11 23:15 UTC, Emilien Macchi
no flags Details

Description Emilien Macchi 2017-12-11 22:25:49 UTC
TripleO Support for configuring RHSM with an ansible role. It needs to be packaged.

Comment 1 Emilien Macchi 2017-12-11 22:32:36 UTC
Created attachment 1366355 [details]
spec file

Comment 2 Alan Pevec 2017-12-11 23:10:19 UTC
How does this role compare to proposed rhsm_repository module?


Comment 3 Emilien Macchi 2017-12-11 23:15:04 UTC
Created attachment 1366369 [details]
spec file

Comment 4 Emilien Macchi 2017-12-11 23:18:27 UTC
It's a good question Alan, I wasn't aware about https://github.com/ansible/ansible/pull/28292 ...
If we go with https://github.com/ansible/ansible/pull/28292 then I'm not sure why we need a role, right?

Sam, can you help us here before we import things?

Comment 5 Sam Doran 2017-12-12 14:15:52 UTC
I would say the two are unrelated. Regardless of the modules use, we still will need a role to handle the options and logic. If/when a module for managing RHSM repos is merged, it would be fairly easy to modify the role to use that module instead.

Comment 6 Emilien Macchi 2017-12-13 02:13:58 UTC
I confirm what Sam said, we still need this role, and this role will actually use the new module in core.

The repo was moved to OpenStack: https://github.com/openstack/ansible-role-redhat-subscription

Please let me know any blocker to make the import.


Comment 7 Javier Peña 2017-12-13 09:06:20 UTC
In the long run, I think we should be able to handle this functionality using a mix of http://docs.ansible.com/ansible/latest/redhat_subscription_module.html (which is still a preview) and https://github.com/ansible/ansible/pull/28292, but I agree that for the short term it should be ok.

Running licensecheck on the repo, I see there is an issue. We have a commit [1] that changes the module license to Apache 2.0, however there is a file licensed with GPL v3 [2], and there is no license file in the repo. Could you fix this?

[1]- https://github.com/openstack/ansible-role-redhat-subscription/commit/cb72219341208b1265ef9b6fd29a951c037443b7
[2]- https://github.com/openstack/ansible-role-redhat-subscription/blob/master/library/redhat_repos.py

Comment 8 Emilien Macchi 2017-12-13 13:28:56 UTC
Javier, we're adding the LICENSE here: https://review.openstack.org/#/c/527561/4/LICENSE

Licence was changed so it matches other OpenStack projects. I don't see any problem.

Let me know what's the next step.

Comment 9 Haïkel Guémar 2017-12-13 14:13:55 UTC
I asked original author to approve the licensing change. Let's assume here that licensing is fixed (author is from RH) and continue review and link Emilien review in the spec.

Comment 10 Javier Peña 2017-12-13 14:17:53 UTC
Author just approved the change, this is the current licensecheck (just for the record, but it will be different once the initial change is merged):

$ licensecheck -r .
./.travis.yml: *No copyright* UNKNOWN
./README.md: *No copyright* UNKNOWN
./defaults/main.yml: *No copyright* UNKNOWN
./library/redhat_repos.py: *No copyright* GPL (v3 or later)
./meta/main.yml: *No copyright* UNKNOWN
./tasks/main.yml: *No copyright* UNKNOWN
./templates/rhsm.conf.j2: *No copyright* UNKNOWN
./tests/Vagrantfile: *No copyright* UNKNOWN
./tests/inventory: *No copyright* UNKNOWN
./tests/test.yml: *No copyright* UNKNOWN
./tests/vagrant.yml: *No copyright* UNKNOWN
./vars/main.yml: *No copyright* UNKNOWN

Comment 12 Javier Peña 2017-12-14 16:58:16 UTC
Review notes:

- The Source0 and %define notes are expected, since the SRPM was generated by DLRN.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
     generated", "*No copyright* Apache (v2.0)". 22 files have unknown
     license. Detailed output of licensecheck in /tmp/ansible-role-redhat-
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/ansible
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/ansible
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Python eggs must not download any dependencies during the build
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[-]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define upstream_version
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Checking: ansible-role-redhat-subscription-0.0.1-0.20171214151812.99c534d.el7.centos.noarch.rpm
ansible-role-redhat-subscription.noarch: W: summary-ended-with-dot C Ansible role for setting up Red Hat Subscription Management.
ansible-role-redhat-subscription.noarch: E: no-changelogname-tag
ansible-role-redhat-subscription.noarch: E: non-executable-script /usr/share/ansible/roles/redhat-subscription/library/redhat_repos.py 644 /usr/bin/python 
ansible-role-redhat-subscription.src: W: summary-ended-with-dot C Ansible role for setting up Red Hat Subscription Management.
ansible-role-redhat-subscription.src: E: no-changelogname-tag
ansible-role-redhat-subscription.src: W: invalid-url Source0: ansible-role-redhat-subscription-0.0.1.dev16-0.20171214151812.99c534d.tar.gz
2 packages and 0 specfiles checked; 3 errors, 3 warnings.

Rpmlint (installed packages)
ansible-role-redhat-subscription.noarch: W: summary-ended-with-dot C Ansible role for setting up Red Hat Subscription Management.
ansible-role-redhat-subscription.noarch: E: no-changelogname-tag
ansible-role-redhat-subscription.noarch: W: invalid-url URL: https://git.openstack.org/cgit/openstack/ansible-role-redhat-subscription <urlopen error [Errno -2] Name or service not known>
ansible-role-redhat-subscription.noarch: E: non-executable-script /usr/share/ansible/roles/redhat-subscription/library/redhat_repos.py 0644L /usr/bin/python
1 packages and 0 specfiles checked; 2 errors, 2 warnings.

ansible-role-redhat-subscription (rpmlib, GLIBC filtered):


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -n ansible-role-redhat-subscription -r -m dlrn
Buildroot used: dlrn-centos7-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP

The package is APPROVED.

Comment 13 Javier Peña 2018-01-09 14:13:42 UTC
The package is already available in RDO Trunk, closing bug.

Note You need to log in before you can comment on or make changes to this bug.