1524805 – Disconnected install fails at service catalog imagePullPolicy: Always

Bug 1524805 - Disconnected install fails at service catalog imagePullPolicy: Always

Summary: Disconnected install fails at service catalog imagePullPolicy: Always

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	OpenShift Container Platform
Classification:	Red Hat
Component:	Installer
Sub Component:
Version:	3.7.0
Hardware:	Unspecified
OS:	Unspecified
Priority:	medium
Severity:	medium
Target Milestone:	---
Target Release:	3.9.0
Assignee:	Fabian von Feilitzsch
QA Contact:	Gan Huang
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2017-12-12 06:30 UTC by Takayoshi Kimura
Modified:	2018-08-01 06:02 UTC (History)
CC List:	8 users (show)
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:	Cause: The service catalog would always try to pull a newer image from the configured registry Consequence: Disconnected installs would fail to deploy the service catalog, as the registry is not available Fix: Changed imagePullPolicy to ifNotPresent Result: If the image is present, the service catalog will not attempt to pull it again, and the disconnected install of the service catalog will proceed.
Clone Of:
Environment:
Last Closed:	2018-03-28 14:15:24 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2018:0489	0	None	None	None	2018-03-28 14:15:53 UTC

Description Takayoshi Kimura 2017-12-12 06:30:58 UTC

Description of problem:

Disconnected install with pre-synced images fails at service catalog because it's using imagePullPolicy: Always hard-coded.

https://docs.openshift.com/container-platform/3.7/install_config/install/disconnected_install.html#disconnected-syncing-images

Version-Release number of the following components:

$ rpm -q openshift-ansible
openshift-ansible-3.7.9-1.git.7.eedd332.el7.noarch
$ rpm -q ansible
ansible-2.4.1.0-1.el7.noarch
$ ansible --version
ansible 2.4.1.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/nekop/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, May  3 2017, 07:55:04) [GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]

How reproducible:

Always

Steps to Reproduce:
1. Perform disconnect
2.
3.

Actual results:

Failed at TASK [openshift_service_catalog : wait for api server to be ready] 

Expected results:

No fail and it uses imagePullPolicy: IfNotPresent

Additional info:

We may want to review other "imagePullPolicy: Always" usages.

$ find /usr/share/ansible/openshift-ansible/ -type f | xargs grep 'imagePullPolicy: Always'
/usr/share/ansible/openshift-ansible/roles/lib_openshift/src/test/integration/oc_obj.yml:                  imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/lib_openshift/src/test/integration/oc_obj.yml:                  imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_examples/files/examples/v1.3/quickstart-templates/apicast-gateway-template.yml:          imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_examples/files/examples/v1.4/cfme-templates/jboss-middleware-manager-template.yaml:          imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_examples/files/examples/v1.5/cfme-templates/jboss-middleware-manager-template.yaml:          imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_examples/files/examples/v3.6/cfme-templates/jboss-middleware-manager-template.yaml:          imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_examples/files/examples/v3.7/cfme-templates/jboss-middleware-manager-template.yaml:          imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_hosted_templates/files/v1.0/enterprise/logging-deployer.yaml:      imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_hosted_templates/files/v1.0/origin/logging-deployer.yaml:      imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_hosted_templates/files/v1.1/enterprise/logging-deployer.yaml:      imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_hosted_templates/files/v1.1/origin/logging-deployer.yaml:      imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_hosted_templates/files/v1.2/enterprise/logging-deployer.yaml:      imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_hosted_templates/files/v1.2/origin/logging-deployer.yaml:        imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_hosted_templates/files/v1.3/enterprise/logging-deployer.yaml:        imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_hosted_templates/files/v1.3/origin/logging-deployer.yaml:        imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_hosted_templates/files/v1.4/enterprise/logging-deployer.yaml:        imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_hosted_templates/files/v1.4/origin/logging-deployer.yaml:        imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_service_catalog/templates/api_server.j2:        imagePullPolicy: Always
/usr/share/ansible/openshift-ansible/roles/openshift_service_catalog/templates/controller_manager.j2:        imagePullPolicy: Always

Comment 2 Fabian von Feilitzsch 2018-01-22 19:09:31 UTC

https://github.com/openshift/openshift-ansible/pull/6819

Comment 4 openshift-github-bot 2018-01-24 22:43:24 UTC

Commits pushed to master at https://github.com/openshift/openshift-ansible

https://github.com/openshift/openshift-ansible/commit/4fca5efde8ac210b96846a553153a444c13be4fb
Bug 1524805- ServiceCatalog now works disconnected

Change imagePullPolicy for service catalog from Always to IfNotPresent,
      allowing service catalog to install in a disconnected setting

https://github.com/openshift/openshift-ansible/commit/0905e3ffb267317da5ae743f201438e2aca96f86
Merge pull request #6819 from fabianvf/1524805-service-catalog-pull-policy

Automatic merge from submit-queue.

Bug 1524805- ServiceCatalog now works disconnected

Change imagePullPolicy for service catalog from Always to IfNotPresent,
      allowing service catalog to install in a disconnected setting

https://bugzilla.redhat.com/show_bug.cgi?id=1524805

Comment 5 Johnny Liu 2018-01-25 05:35:53 UTC

This bug is targeted for 3.9, while this bug is attached to a 3.5/3.6/3.7 errata, pls attach it to a correct errata.

Comment 8 Gan Huang 2018-01-30 08:48:01 UTC

Tested in openshift-ansible-3.9.0-0.31.0.git.0.e0a0ad8.el7.noarch

The imagePullPolicy of CFME templates is still Always, according to the bug, there seems a fix needed for CFME template as well.

# find /usr/share/ansible/openshift-ansible/ -type f | xargs grep 'imagePullPolicy: Always' |grep '3\.9'
/usr/share/ansible/openshift-ansible/roles/openshift_examples/files/examples/v3.9/cfme-templates/jboss-middleware-manager-template.yaml:          imagePullPolicy: Always

Comment 9 Fabian von Feilitzsch 2018-02-08 22:02:53 UTC

https://github.com/openshift/openshift-ansible/pull/7079

Comment 10 openshift-github-bot 2018-02-08 22:23:35 UTC

Commits pushed to master at https://github.com/openshift/openshift-ansible

https://github.com/openshift/openshift-ansible/commit/1815a3bf3d68d68027aa163606bcce80a8effe53
Bug 1524805- CFME example now works disconnected

https://github.com/openshift/openshift-ansible/commit/26a72e6bb86d8c85c41c269bf1bd4dd8f3a5cd15
Merge pull request #7079 from fabianvf/1524805-cloudforms-pull-policy

Bug 1524805- CFME example now works disconnected

Comment 11 Gan Huang 2018-02-23 06:23:25 UTC

Verified in openshift-ansible-3.9.0-0.48.0.git.0.2fb33db.el7.noarch.rpm

imagePullPolicy had been changed to IfNotPresent:
# oc get ds -n kube-service-catalog -o yaml |grep imagePullPolicy
          imagePullPolicy: IfNotPresent
          imagePullPolicy: IfNotPresent

All the imagePullPolicy had been updated accordingly:
# find /usr/share/ansible/openshift-ansible/ -type f | xargs grep 'imagePullPolicy: Always' |grep '3\.9'

Comment 14 errata-xmlrpc 2018-03-28 14:15:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489

Note You need to log in before you can comment on or make changes to this bug.