Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1525216

Summary: NPE in engine when trying to recover from failed VM import
Product: Red Hat Enterprise Virtualization Manager Reporter: Gordon Watson <gwatson>
Component: ovirt-engineAssignee: Nobody <nobody>
Status: CLOSED DUPLICATE QA Contact: meital avital <mavital>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.1.1CC: gwatson, lsurette, rbalakri, Rhev-m-bugs, srevivo, tjelinek, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-14 09:33:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Gordon Watson 2017-12-12 19:49:13 UTC
Description of problem:

After a VM import failure, an NPE occurred, and the associated engine tasks/job were not cleaned up;

2017-12-01 16:38:33,349-03 ERROR [org.ovirt.engine.core.bll.tasks.CommandAsyncTask] (org.ovirt.thread.pool-7-thread-41) [] [within thread]: endAction for action type ImportVm threw an except
ion.: java.lang.NullPointerException
        at org.ovirt.engine.core.bll.network.VmInterfaceManager.removeAll(VmInterfaceManager.java:135) [bll.jar:]
        at org.ovirt.engine.core.bll.exportimport.ImportVmCommand.removeVmNetworkInterfaces(ImportVmCommand.java:1178) [bll.jar:]
        at org.ovirt.engine.core.bll.exportimport.ImportVmCommand.endWithFailure(ImportVmCommand.java:1146) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.internalEndWithFailure(CommandBase.java:768) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.endActionInTransactionScope(CommandBase.java:697) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.runInTransaction(CommandBase.java:2057) [bll.jar:]
        at org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInNewTransaction(TransactionSupport.java:202) [utils.jar:]
        at org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInRequired(TransactionSupport.java:137) [utils.jar:]
        at org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInScope(TransactionSupport.java:105) [utils.jar:]
        at org.ovirt.engine.core.bll.CommandBase.endAction(CommandBase.java:559) [bll.jar:]
        at org.ovirt.engine.core.bll.tasks.DecoratedCommand.endAction(DecoratedCommand.java:17) [bll.jar:]
        at org.ovirt.engine.core.bll.tasks.CoCoAsyncTaskHelper.endAction(CoCoAsyncTaskHelper.java:337) [bll.jar:]
        at org.ovirt.engine.core.bll.tasks.CommandCoordinatorImpl.endAction(CommandCoordinatorImpl.java:340) [bll.jar:]
        at org.ovirt.engine.core.bll.tasks.CommandAsyncTask.endCommandAction(CommandAsyncTask.java:154) [bll.jar:]
        at org.ovirt.engine.core.bll.tasks.CommandAsyncTask.lambda$endActionIfNecessary$0(CommandAsyncTask.java:106) [bll.jar:]
        at org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil$InternalWrapperRunnable.run(ThreadPoolUtil.java:84) [utils.jar:]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [rt.jar:1.8.0_144]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [rt.jar:1.8.0_144]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [rt.jar:1.8.0_144]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [rt.jar:1.8.0_144]
        at java.lang.Thread.run(Thread.java:748) [rt.jar:1.8.0_144]



Version-Release number of selected component (if applicable):

RHV 4.1.6
RHEL 7.4 hosts w/vdsm-4.19.31-1
  

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:

Expected results:

Additional info:

Comment 1 Yaniv Kaul 2017-12-12 19:56:10 UTC
Dup of bug 1489795 ?

Comment 2 Gordon Watson 2017-12-12 20:06:22 UTC
Yaniv,

You're too quick for me. I was just adding a follow-up comment, when you responded. I had searched for other bugs, and only found one, BZ 1435813. I didn't find the one you mentioned, interestingly. 

Anyway, so fixed in 4.1.7, right ?

Thanks, GFW.

Comment 5 Yaniv Kaul 2017-12-12 20:47:41 UTC
(In reply to Gordon Watson from comment #2)
> Yaniv,
> 
> You're too quick for me. I was just adding a follow-up comment, when you
> responded. I had searched for other bugs, and only found one, BZ 1435813. I
> didn't find the one you mentioned, interestingly. 

The secret sauce is google on: "engine.core.bll.network.VmInterfaceManager.removeAll"

> 
> Anyway, so fixed in 4.1.7, right ?

Yes.

> 
> Thanks, GFW.

Comment 6 Tomas Jelinek 2017-12-14 09:33:56 UTC

*** This bug has been marked as a duplicate of bug 1489795 ***