Bug 1525435 - ovirt-engine-hyper-upgrade --help has too long lines
Summary: ovirt-engine-hyper-upgrade --help has too long lines
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-fast-forward-upgrade
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ovirt-4.2.4
: 4.2.0
Assignee: Douglas Schilling Landgraf
QA Contact: Jiri Belka
URL:
Whiteboard:
Depends On:
Blocks: 1366900
TreeView+ depends on / blocked
 
Reported: 2017-12-13 10:33 UTC by Jiri Belka
Modified: 2019-05-16 13:08 UTC (History)
1 user (show)

Fixed In Version: ovirt-fast-forward-upgrade-1.0.0-1.el7ev
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-28 07:00:00 UTC
oVirt Team: Integration
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Jiri Belka 2017-12-13 10:33:17 UTC
Description of problem:

i hate really hate such long lines - maybe it's called by some people DOS era - lines ideally should not be longer that 80 chars.

# ovirt-engine-hyper-upgrade --help | awk '{ print length($0),$0 }'
75 usage: ovirt-engine-hyper-upgrade [-h] [--backup] [--backup-dir BACKUP_DIR]
67                                   [--upgrade-to-rhv UPGRADE_TO_RHV]
0 
32 Tool to upgrade RHV environments
0 
19 optional arguments:
55   -h, --help            show this help message and exit
60   --backup              Execute engine-backup before upgrade
25   --backup-dir BACKUP_DIR
118                         Directory where the engine-backup will save the backup file. If not provided, it will use /tmp
33   --upgrade-to-rhv UPGRADE_TO_RHV
57                         Upgrade to specifc version of RHV
0 
15 Example of use:
47 ovirt-engine-hyper-upgrade --upgrade-to-rhv=4.1



Example of use:
ovirt-engine-hyper-upgrade --upgrade-to-rhv=4.1

Version-Release number of selected component (if applicable):
ovirt-engine-hyper-upgrade-1.0.0-3.el7ev.noarch.rpm

How reproducible:
100%

Steps to Reproduce:
1. --help
2.
3.

Actual results:
see if it too trendy with length

Expected results:
oldschoold unix 80 chars length max (if applicable)

Additional info:

Comment 2 Douglas Schilling Landgraf 2017-12-14 18:57:28 UTC
https://github.com/oVirt/ovirt-engine-hyper-upgrade/pull/10

Comment 3 Jiri Belka 2017-12-18 14:38:13 UTC
ok

# ovirt-engine-hyper-upgrade --help | awk '{ print length($0),$0 }'      
75 usage: ovirt-engine-hyper-upgrade [-h] [--backup] [--backup-dir BACKUP_DIR]
0 
32 Tool to upgrade RHV environments
0 
19 optional arguments:
55   -h, --help            show this help message and exit
60   --backup              Execute engine-backup before upgrade
25   --backup-dir BACKUP_DIR
78                         Directory where the engine-backup will save the output
57                         If not provided, it will use /tmp
0 
15 Example of use:
47 ovirt-engine-hyper-upgrade --upgrade-to-rhv=4.1
[root@10-37-138-240 yum.repos.d]# rpm -q ovirt-engine-hyper-upgrade
ovirt-engine-hyper-upgrade-1.0.0-4.el7ev.noarch

Comment 4 Franta Kust 2019-05-16 13:08:52 UTC
BZ<2>Jira Resync


Note You need to log in before you can comment on or make changes to this bug.